From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: broonie@kernel.org, Bard Liao <yung-chuan.liao@linux.intel.com>,
lgirdwood@gmail.com, rafael@kernel.org, linux-pm@vger.kernel.org,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH] ASoC: SDCA: Add NO_DIRECT_COMPLETE flag to class driver
Date: Wed, 21 Jan 2026 16:08:51 +0100 [thread overview]
Message-ID: <9be645d1-4de2-4ff2-890e-6f0149b07c57@linux.dev> (raw)
In-Reply-To: <aXDPAjgEgHvrezVz@opensource.cirrus.com>
>> You lost me with this sentence:
>>
>> "
>> For SoundWire itself the soundwire host resumes all children
>> before a suspend, which dodges the direct complete.
>> "
>>
>> If the direct-complete optimization is not used, then do you
>> actually see a different behavior with this NO_DIRECT_COMPLETE
>> flag set?
>
> The flag is applied to the auxiliary device children of the
> soundwire device. The direct complete doesn't affect the
> soundwire device, but it it does affect the function devices
> children.
Ah ok, yes the host only resumes devices one level down, so the function level isn't affected by the .prepare logic.
I guess I was confused by the 'class driver' title but the change is not in sdca_class.c but in sdca_class_function.c...
The change looks good, so here's my
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
next prev parent reply other threads:[~2026-01-21 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 13:17 [PATCH] ASoC: SDCA: Add NO_DIRECT_COMPLETE flag to class driver Charles Keepax
2026-01-20 16:50 ` Pierre-Louis Bossart
2026-01-20 17:45 ` Charles Keepax
2026-01-21 12:41 ` Pierre-Louis Bossart
2026-01-21 13:05 ` Charles Keepax
2026-01-21 15:08 ` Pierre-Louis Bossart [this message]
2026-01-22 13:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9be645d1-4de2-4ff2-890e-6f0149b07c57@linux.dev \
--to=pierre-louis.bossart@linux.dev \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rafael@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox