From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CADBD40F8E2 for ; Wed, 21 Jan 2026 15:10:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769008262; cv=none; b=GeS+zWX4rfci0c8F5ElKfE3nnqrnA5vyy15Y8/LxK5taRQ4dLu6I5/zTlDStR0WwZX1UOAqv7bdYpYtWnq84vMzjFzQAoY2C5yVO4kUfyxDblE5e4jCMz73p79V9Vf8sgVpFNxtqXxgiTLEKS50Hhkyl3BO7h6rlrcsNIPhcsIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769008262; c=relaxed/simple; bh=lCDxlM+yqCQMKmrEqArUSKF4KYldS3/T92SOB6whHEw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ogCUv27f+94Pic4GdUNxYoKYyLTtQQQSnFuKcurcTYDB+gki23Rcq8PK2xZzs6bbwLbdyKiBMsIjBmIPurZBgVC4VScDRy71aFiLSN2VdVEYIfttutwDRp+SogsmevLG3Fht+yNVwxvQBWlrJE+vOFU9ukV5BY3lXGaH9vpIbvY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=CkhAf3dP; arc=none smtp.client-ip=95.215.58.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="CkhAf3dP" Message-ID: <9be645d1-4de2-4ff2-890e-6f0149b07c57@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1769008257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e+iZ9dhXRVI9aGNccTo0SytDWA0FNnDAw0/vu2LGl1o=; b=CkhAf3dPb/NK3Ul9GJ4ZPtGWVzFOtb0gdNapXOOeOODIXxNJhGeSs2e0nCN+KaQrYkbvet eiuxJyabKa7chIRNI8Gl0U2z+uehJu0u7Um2N/2pjPWYpWqVID1ppn+XEH6JYzoGfovFyn JyQJ+sphbSJhR52Bt2I26x/3F8PqMYM= Date: Wed, 21 Jan 2026 16:08:51 +0100 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] ASoC: SDCA: Add NO_DIRECT_COMPLETE flag to class driver To: Charles Keepax Cc: broonie@kernel.org, Bard Liao , lgirdwood@gmail.com, rafael@kernel.org, linux-pm@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com References: <20260115131727.373738-1-ckeepax@opensource.cirrus.com> <43cb31d5-1423-4354-8eb1-68afbac622da@linux.dev> <74596131-4d06-449e-8ba9-30b35e0e2064@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT >> You lost me with this sentence: >> >> " >> For SoundWire itself the soundwire host resumes all children >> before a suspend, which dodges the direct complete. >> " >> >> If the direct-complete optimization is not used, then do you >> actually see a different behavior with this NO_DIRECT_COMPLETE >> flag set? > > The flag is applied to the auxiliary device children of the > soundwire device. The direct complete doesn't affect the > soundwire device, but it it does affect the function devices > children. Ah ok, yes the host only resumes devices one level down, so the function level isn't affected by the .prepare logic. I guess I was confused by the 'class driver' title but the change is not in sdca_class.c but in sdca_class_function.c... The change looks good, so here's my Reviewed-by: Pierre-Louis Bossart