From: Choi Chanwoo <cwchoi00@gmail.com>
To: Yaxiong Tian <tianyaxiong@kylinos.cn>,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
cw00.choi@samsung.com, zhanjie9@hisilicon.com, nm@ti.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] PM / devfreq: Optimize error return value of governor_show()
Date: Thu, 30 Apr 2026 06:50:13 +0900 [thread overview]
Message-ID: <9c96df3d-5505-4786-8507-9493314d21a9@gmail.com> (raw)
In-Reply-To: <20260401033128.67925-1-tianyaxiong@kylinos.cn>
2026-04-01 PM 12:31에 Yaxiong Tian 이(가) 쓴 글:
> When df->governor is NULL, governor_show() returns -EINVAL, which
> confuses users.
>
> To fix this issue, return -ENOENT to indicate that no governor is
> currently set for the device.
>
> Signed-off-by: Yaxiong Tian <tianyaxiong@kylinos.cn>
> ---
> drivers/devfreq/devfreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 975f82d7a9d1..c40568d2a4dc 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -1377,7 +1377,7 @@ static ssize_t governor_show(struct device *dev,
> struct devfreq *df = to_devfreq(dev);
>
> if (!df->governor)
> - return -EINVAL;
> + return -ENOENT;
>
> return sprintf(buf, "%s\n", df->governor->name);
> }
Hi,
Applied it. Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2026-04-29 21:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 3:28 [PATCH v2 0/4] Fix some errors in the devfreq core layer when governor is NULL Yaxiong Tian
2026-04-01 3:30 ` [PATCH v2 1/4] PM / devfreq: Fix possible null pointer issue in devfreq_add_governor() Yaxiong Tian
2026-04-02 3:06 ` Jie Zhan
2026-04-29 21:49 ` Choi Chanwoo
2026-04-01 3:30 ` [PATCH v2 2/4] PM / devfreq: Fix available_governors_show() when no governor is set Yaxiong Tian
2026-04-02 3:10 ` Jie Zhan
2026-04-29 21:49 ` Choi Chanwoo
2026-04-01 3:31 ` [PATCH v2 3/4] PM / devfreq: Fix governor_store() failing when device has no current governor Yaxiong Tian
2026-04-02 3:21 ` Jie Zhan
2026-04-02 5:47 ` Yaxiong Tian
2026-04-02 6:52 ` Jie Zhan
2026-04-29 22:28 ` Choi Chanwoo
2026-04-30 3:29 ` Yaxiong Tian
2026-04-30 3:20 ` [PATCH v3 " Yaxiong Tian
2026-04-01 3:31 ` [PATCH v2 4/4] PM / devfreq: Optimize error return value of governor_show() Yaxiong Tian
2026-04-02 3:38 ` Jie Zhan
2026-04-29 21:50 ` Choi Chanwoo [this message]
2026-04-28 2:50 ` [PATCH v2 0/4] Fix some errors in the devfreq core layer when governor is NULL Jie Zhan
2026-04-28 2:59 ` Yaxiong Tian
2026-04-29 2:04 ` Jie Zhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c96df3d-5505-4786-8507-9493314d21a9@gmail.com \
--to=cwchoi00@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=tianyaxiong@kylinos.cn \
--cc=zhanjie9@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox