linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Zhang, Rui" <rui.zhang@intel.com>
To: "daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
	"Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: powercap ABI clarification
Date: Mon, 27 May 2024 14:19:06 +0000	[thread overview]
Message-ID: <9c97e4f8549744b1e2464a3b632f0716514ff55c.camel@intel.com> (raw)
In-Reply-To: <59e5a949-ef20-4f11-a0a7-247c457f1dd3@linaro.org>

On Mon, 2024-05-27 at 14:55 +0200, Daniel Lezcano wrote:
> 
> Hi Srinivas,
> 
> the powercap ABI exports some constraint files. Even if I suspect
> their 
> semantic it is not really clear how they should behave.
> 
>        │   ├──constraint_0_name
>        │   ├──constraint_0_power_limit_uw
>        │   ├──constraint_0_time_window_us
>        │   ├──constraint_1_name
>        │   ├──constraint_1_power_limit_uw
>        │   ├──constraint_1_time_window_us
> 
> Are the constraints controller specific? I mean, each controller
> defines 
> their constraints? Or is it supposed to behave the same way whatever
> the 
> controller?

Currently we have three controllers, MSR RAPL, MMIO RAPL and TPMI RAPL.
They are actually the same feature (RAPL) via different register
Interfaces.
So their behaviors are consistent.

> 
> Is the time window giving the duration of the power_limit_uw
> constraint? 
> Or is it an average power during this time window?

The average power during this time window.
The constraint is always effective after we set it.

> 
> What is the purpose of min|max_time_window_us?

It is the upper/lower limit for users to set a meaningful time window.

> 
> Can we set several constraints or are they mutually exclusive?

My understanding is that they can both take effect.
"Two power limits can be specified, corresponding to time windows of
different sizes. Each power limit provides inde-
pendent clamping control that would permit the processor cores to go
below OS-requested state to meet the power
limits."

> 
> Is there any documentation describing with more details the ABIs?
> 
Interesting, I just found this one,
Documentation/ABI/testing/sysfs-class-powercap, should we move it to
stable? Other than that, I don't know.

thanks,
rui


  reply	other threads:[~2024-05-27 14:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27 12:55 powercap ABI clarification Daniel Lezcano
2024-05-27 14:19 ` Zhang, Rui [this message]
2024-05-27 15:19   ` Pandruvada, Srinivas
2024-05-27 15:50   ` Daniel Lezcano
2024-05-28  4:59     ` Zhang, Rui
2024-05-28  6:40       ` Pandruvada, Srinivas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c97e4f8549744b1e2464a3b632f0716514ff55c.camel@intel.com \
    --to=rui.zhang@intel.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=srinivas.pandruvada@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).