From: Perry Yuan <perry.yuan@amd.com>
To: <rafael.j.wysocki@intel.com>, <Mario.Limonciello@amd.com>,
<viresh.kumar@linaro.org>, <gautham.shenoy@amd.com>
Cc: <Xinmei.Huang@amd.com>, <Xiaojian.Du@amd.com>, <Li.Meng@amd.com>,
<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v12 3/9] cpufreq: introduce init_boost callback to initialize boost state for pstate drivers
Date: Wed, 19 Jun 2024 17:16:36 +0800 [thread overview]
Message-ID: <9d1ba8e29feddcfcee0b8a91be3d6950bfa00720.1718787627.git.perry.yuan@amd.com> (raw)
In-Reply-To: <cover.1718787627.git.perry.yuan@amd.com>
Introduce a new init_boost callback in cpufreq to initialize the boost
state for specific pstate drivers. This initialization is required before
calling the set_boost interface for each CPU.
The init_boost callback will set up and synchronize each CPU's current
boost state before invoking the set_boost function. Without this step,
the boost state may be inconsistent across CPUs.
Signed-off-by: Perry Yuan <perry.yuan@amd.com>
---
drivers/cpufreq/cpufreq.c | 13 +++++++++++--
include/linux/cpufreq.h | 2 ++
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 1fdabb660231..64c6770e24c8 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1429,8 +1429,17 @@ static int cpufreq_online(unsigned int cpu)
goto out_free_policy;
}
- /* Let the per-policy boost flag mirror the cpufreq_driver boost during init */
- policy->boost_enabled = cpufreq_boost_enabled() && policy_has_boost_freq(policy);
+ /* init boost state to prepare set_boost callback for each CPU */
+ if (cpufreq_driver->init_boost) {
+ ret = cpufreq_driver->init_boost(policy);
+ if (ret)
+ pr_debug("%s: %d: boost initialization failed\n", __func__,
+ __LINE__);
+ goto out_offline_policy;
+ } else {
+ /* Let the per-policy boost flag mirror the cpufreq_driver boost during init */
+ policy->boost_enabled = cpufreq_boost_enabled() && policy_has_boost_freq(policy);
+ }
/*
* The initialization has succeeded and the policy is online.
diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
index 20f7e98ee8af..0698c0292d8f 100644
--- a/include/linux/cpufreq.h
+++ b/include/linux/cpufreq.h
@@ -409,6 +409,8 @@ struct cpufreq_driver {
bool boost_enabled;
int (*set_boost)(struct cpufreq_policy *policy, int state);
+ /* initialize boost state to be consistent before calling set_boost */
+ int (*init_boost)(struct cpufreq_policy *policy);
/*
* Set by drivers that want to register with the energy model after the
* policy is properly initialized, but before the governor is started.
--
2.34.1
next prev parent reply other threads:[~2024-06-19 9:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 9:16 [PATCH v12 0/9] AMD Pstate Driver Core Performance Boost Perry Yuan
2024-06-19 9:16 ` [PATCH v12 1/9] cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h Perry Yuan
2024-06-19 9:16 ` [PATCH v12 2/9] cpufreq: simplify boolean parsing with kstrtobool in store function Perry Yuan
2024-06-21 4:30 ` Gautham R.Shenoy
2024-06-19 9:16 ` Perry Yuan [this message]
2024-06-19 17:37 ` [PATCH v12 3/9] cpufreq: introduce init_boost callback to initialize boost state for pstate drivers Mario Limonciello
2024-06-19 9:16 ` [PATCH v12 4/9] cpufreq: amd-pstate: initialize new core precision boost state Perry Yuan
2024-06-19 19:32 ` Mario Limonciello
2024-06-21 5:23 ` Gautham R.Shenoy
2024-06-19 9:16 ` [PATCH v12 5/9] cpufreq: amd-pstate: implement cpb_boost sysfs entry for boost control Perry Yuan
2024-06-19 19:39 ` Mario Limonciello
2024-06-21 5:36 ` Gautham R.Shenoy
2024-06-19 9:16 ` [PATCH v12 6/9] cpufreq: amd-pstate: Add set_boost callback for active mode Perry Yuan
2024-06-19 19:40 ` Mario Limonciello
2024-06-21 5:39 ` Gautham R.Shenoy
2024-06-21 5:54 ` Yuan, Perry
2024-06-19 9:16 ` [PATCH v12 7/9] cpufreq: amd-pstate: fix the MSR highest perf will be reset issue while cpb boost off Perry Yuan
2024-06-21 5:46 ` Gautham R.Shenoy
2024-06-21 5:56 ` Yuan, Perry
2024-06-19 9:16 ` [PATCH v12 8/9] Documentation: cpufreq: amd-pstate: introduce the new cpu boost control method Perry Yuan
2024-06-19 19:40 ` Mario Limonciello
2024-06-19 9:16 ` [PATCH v12 9/9] Documentation: cpufreq: amd-pstate: update doc for Per CPU " Perry Yuan
2024-06-19 19:45 ` Mario Limonciello
2024-06-21 6:42 ` Gautham R.Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d1ba8e29feddcfcee0b8a91be3d6950bfa00720.1718787627.git.perry.yuan@amd.com \
--to=perry.yuan@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=Xinmei.Huang@amd.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).