From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5911FC0650F for ; Thu, 8 Aug 2019 12:28:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3642B21883 for ; Thu, 8 Aug 2019 12:28:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727649AbfHHM2k (ORCPT ); Thu, 8 Aug 2019 08:28:40 -0400 Received: from mga05.intel.com ([192.55.52.43]:62417 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727096AbfHHM2k (ORCPT ); Thu, 8 Aug 2019 08:28:40 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 05:28:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,361,1559545200"; d="scan'208";a="374835021" Received: from rbhardw1-mobl.gar.corp.intel.com (HELO [10.252.86.4]) ([10.252.86.4]) by fmsmga006.fm.intel.com with ESMTP; 08 Aug 2019 05:28:36 -0700 Subject: Re: [PATCH] x86/cpu: Add Elkhart Lake to Intel family To: Peter Zijlstra Cc: x86@kernel.org, bp@suse.de, Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Kan Liang , Qiuxu Zhuo , Len Brown , Thomas Gleixner , Linux PM References: <20190808101045.19239-1-rajneesh.bhardwaj@linux.intel.com> <20190808104253.GG2369@hirez.programming.kicks-ass.net> From: "Bhardwaj, Rajneesh" Message-ID: <9d7241a1-5c2c-2369-5b1d-68912cc430b4@linux.intel.com> Date: Thu, 8 Aug 2019 17:58:35 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190808104253.GG2369@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hello Peter, Thanks for the review. On 08-Aug-19 4:12 PM, Peter Zijlstra wrote: > On Thu, Aug 08, 2019 at 03:40:45PM +0530, Rajneesh Bhardwaj wrote: >> Elkhart Lake is Atom based SoC that uses model number 0x96. CPUID details >> will be documented in a future version of Intel Software Development >> Manual. >> >> Cc: bp@suse.de >> Cc: Borislav Petkov >> Cc: Dave Hansen >> Cc: "H. Peter Anvin" >> Cc: Kan Liang >> Cc: Peter Zijlstra >> Cc: Qiuxu Zhuo >> Cc: Len Brown >> Cc: Thomas Gleixner >> Cc: x86-ml >> Cc: Linux PM >> Signed-off-by: Rajneesh Bhardwaj >> --- >> arch/x86/include/asm/intel-family.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/x86/include/asm/intel-family.h b/arch/x86/include/asm/intel-family.h >> index 0278aa66ef62..06e94ae65f28 100644 >> --- a/arch/x86/include/asm/intel-family.h >> +++ b/arch/x86/include/asm/intel-family.h >> @@ -79,6 +79,7 @@ >> #define INTEL_FAM6_ATOM_GOLDMONT_PLUS 0x7A /* Gemini Lake */ >> >> #define INTEL_FAM6_ATOM_TREMONT_X 0x86 /* Jacobsville */ >> +#define INTEL_FAM6_ATOM_ELKHART_LAKE 0x96 /*Elkhart Lake */ > Almost, please try again. Did you mean "It should be after Gemini Lake"? And / Or a Space inside comment before 'E' ? I kept it at the current location because of increasing chronological order within Atom section but i can move it to another place. Please let me know if my understanding is correct? I can send a v2 addressing your suggestion. Thank you, Rajneesh