From: Shuah Khan <skhan@linuxfoundation.org>
To: "Mateusz Jaśkiewicz" <jaskiewiczteo@gmail.com>,
"Shuah Khan" <shuah@kernel.org>
Cc: Thomas Renninger <trenn@suse.com>,
"John B. Wyatt IV" <jwyatt@redhat.com>,
John Kacur <jkacur@redhat.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v4] cpupower: Implement powercap enabled setters
Date: Wed, 3 Jun 2026 12:17:19 -0600 [thread overview]
Message-ID: <9e4994be-008d-4c0b-9bb0-1ff782ad00f5@linuxfoundation.org> (raw)
In-Reply-To: <20260528153248.4114324-1-jaskiewiczteo@gmail.com>
On 5/28/26 09:32, Mateusz Jaśkiewicz wrote:
> powercap_set_enabled() and powercap_zone_set_enabled() are part of the
> public libcpupower API, but both currently return success without
> updating sysfs.
You are right that cpupower set_enable API simply returns success.
Does intel-rapl:0 implement store function on your system?
It doesn't on mine.
cd /sys/devices/virtual/powercap/intel-rapl/intel-rapl:0
echo 1 > enabled
bash: echo: write error: Function not implemented
>
> Write the requested value to the matching enabled attribute so callers
> can actually enable or disable the powercap control type or zone, and
> report write failures back to the caller.
>
The patch loos good. Is there an existing use-case for this?
thanks,
-- Shuah
prev parent reply other threads:[~2026-06-03 18:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 22:35 [PATCH] cpupower: Implement powercap enabled setters Mateusz Jaśkiewicz
2026-05-11 21:01 ` Shuah Khan
2026-05-12 16:11 ` [PATCH v2] " Mateusz Jaśkiewicz
2026-05-14 21:28 ` Shuah Khan
2026-05-26 19:53 ` Shuah Khan
2026-05-27 8:12 ` [PATCH v3] " Mateusz Jaśkiewicz
2026-05-27 15:26 ` Shuah Khan
2026-05-28 15:32 ` [PATCH v4] " Mateusz Jaśkiewicz
2026-06-03 18:17 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4994be-008d-4c0b-9bb0-1ff782ad00f5@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=jaskiewiczteo@gmail.com \
--cc=jkacur@redhat.com \
--cc=jwyatt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox