From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 815D2C0015E for ; Mon, 19 Jun 2023 09:45:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230110AbjFSJpN (ORCPT ); Mon, 19 Jun 2023 05:45:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231615AbjFSJpM (ORCPT ); Mon, 19 Jun 2023 05:45:12 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4BAE1A6 for ; Mon, 19 Jun 2023 02:45:09 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-4f8467e39cfso3962775e87.3 for ; Mon, 19 Jun 2023 02:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687167908; x=1689759908; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VVP/pUDXtLdUgoAxy1tfvAzLhw5MZG/sIJ+AbfxkcTY=; b=QGXoqIdMO+enjF727yqG2zusjrFhlifxAoGCITnJJfQhHq35L3YiZD/4qcYnnb99mb TlzgStRwvsFoivNO69ub5C/jqDT1WLDTrvNBJFFvgn5ZI0dlLQjGqh+1CqwToXkh+da3 yirpTpZdjMxtyU29t6y3Jmak3Pgj/+gT66ahxoANPgJcq/s3DmSAx6r82WBrTTLbrgRp vq8Up40HiZLO+nACVkyK1eyHT8PDFurHE1tmi/PA8dI5ItNADiEu486Z6x8u/en8wcJX L7gDIsf6pZ7dyM+gohfi02O1rtu4W091uAq6hqJx7mjr/JyXNufQiCuSNBiqlXDZjXYX wOQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687167908; x=1689759908; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VVP/pUDXtLdUgoAxy1tfvAzLhw5MZG/sIJ+AbfxkcTY=; b=ZzOSZgglip8/ju9UlPzerh5EjqBONzHl+OeaV9L2GqmXpc4b11gohyTxEB96EV75Rm qY/tDOz56EzHEtTQJgc3CBRRtLYkFNhMzlCZvetpiDQRyXWocxOMkNzIXuM7/gO8G9WZ 2IIT5ZjfFhkWBrkvR8H9rgW/9DGRcmAIAfhwnCVwXs8PjD96w9T9z1DxYkKzxDUENdZl Q2EYX1SsdH9qZNyjmjPyxfBSWEubqSZORv1HhvZasCWEHHujNg5taln+HjVg5qpMLMGI g92MPv1FX/0B4vQ+vihHUnlctfialdn9dlC0wX34tKuTx9+HsqKvTnnZCaRP+GcvKGjL KxIQ== X-Gm-Message-State: AC+VfDzVUakWwv9hQ1xIhU47V6IRjphAtknFovEamBTtNI0WNjLceGb/ eqC7Hz7L1FcHUA5AHN8e29TQ2uz+oLk1vuxe5BM= X-Google-Smtp-Source: ACHHUZ7mo2jbiTXNbEp1T4Qh05oNT1imtkieFd0Ropw/bbl2lsEraDw4RZ56MIGDHwhiaGdmxwnevw== X-Received: by 2002:a05:6512:2f4:b0:4f8:57c2:3936 with SMTP id m20-20020a05651202f400b004f857c23936mr4407428lfq.26.1687167907672; Mon, 19 Jun 2023 02:45:07 -0700 (PDT) Received: from [192.168.1.101] (abyl242.neoplus.adsl.tpnet.pl. [83.9.31.242]) by smtp.gmail.com with ESMTPSA id b6-20020ac25e86000000b004f842e58d08sm1886506lfq.84.2023.06.19.02.45.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jun 2023 02:45:07 -0700 (PDT) Message-ID: <9e890ca0-396d-fb97-a7d5-db13b8fdbb92@linaro.org> Date: Mon, 19 Jun 2023 11:45:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/2] interconnect: qcom: rpmh: add optional mask to send as vote Content-Language: en-US To: Neil Armstrong , Andy Gross , Bjorn Andersson , Georgi Djakov Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230619-topic-sm8550-upstream-interconnect-mask-vote-v1-0-66663c0aa592@linaro.org> <20230619-topic-sm8550-upstream-interconnect-mask-vote-v1-1-66663c0aa592@linaro.org> From: Konrad Dybcio In-Reply-To: <20230619-topic-sm8550-upstream-interconnect-mask-vote-v1-1-66663c0aa592@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 19.06.2023 10:24, Neil Armstrong wrote: > On the SM8550 SoC, some nodes requires a specific bit mark > instead of a bandwidth when voting. > > Add an enable_mask variable to be used to vote when a node > is enabled in an aggregate loop. > > Signed-off-by: Neil Armstrong > --- Would be nice to mention that it's literally this commit: https://git.codelinaro.org/clo/la/kernel/msm-5.15/-/commit/2d1573e0206998151b342e6b52a4c0f7234d7e36 For the code: Reviewed-by: Konrad Dybcio Konrad > drivers/interconnect/qcom/bcm-voter.c | 5 +++++ > drivers/interconnect/qcom/icc-rpmh.h | 2 ++ > 2 files changed, 7 insertions(+) > > diff --git a/drivers/interconnect/qcom/bcm-voter.c b/drivers/interconnect/qcom/bcm-voter.c > index 8f385f9c2dd3..d5f2a6b5376b 100644 > --- a/drivers/interconnect/qcom/bcm-voter.c > +++ b/drivers/interconnect/qcom/bcm-voter.c > @@ -83,6 +83,11 @@ static void bcm_aggregate(struct qcom_icc_bcm *bcm) > > temp = agg_peak[bucket] * bcm->vote_scale; > bcm->vote_y[bucket] = bcm_div(temp, bcm->aux_data.unit); > + > + if (bcm->enable_mask && (bcm->vote_x[bucket] || bcm->vote_y[bucket])) { > + bcm->vote_x[bucket] = 0; > + bcm->vote_y[bucket] = bcm->enable_mask; > + } > } > > if (bcm->keepalive && bcm->vote_x[QCOM_ICC_BUCKET_AMC] == 0 && > diff --git a/drivers/interconnect/qcom/icc-rpmh.h b/drivers/interconnect/qcom/icc-rpmh.h > index 04391c1ba465..7843d8864d6b 100644 > --- a/drivers/interconnect/qcom/icc-rpmh.h > +++ b/drivers/interconnect/qcom/icc-rpmh.h > @@ -81,6 +81,7 @@ struct qcom_icc_node { > * @vote_x: aggregated threshold values, represents sum_bw when @type is bw bcm > * @vote_y: aggregated threshold values, represents peak_bw when @type is bw bcm > * @vote_scale: scaling factor for vote_x and vote_y > + * @enable_mask: optional mask to send as vote instead of vote_x/vote_y > * @dirty: flag used to indicate whether the bcm needs to be committed > * @keepalive: flag used to indicate whether a keepalive is required > * @aux_data: auxiliary data used when calculating threshold values and > @@ -97,6 +98,7 @@ struct qcom_icc_bcm { > u64 vote_x[QCOM_ICC_NUM_BUCKETS]; > u64 vote_y[QCOM_ICC_NUM_BUCKETS]; > u64 vote_scale; > + u32 enable_mask; > bool dirty; > bool keepalive; > struct bcm_db aux_data; >