From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Adam Skladowski <a39.skl@gmail.com>
Cc: phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Georgi Djakov <djakov@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] interconnect: qcom: Add MSM8937 interconnect provider driver
Date: Mon, 10 Jun 2024 14:54:13 +0200 [thread overview]
Message-ID: <9f5b9f75-528f-447b-9056-30c10f84fa98@linaro.org> (raw)
In-Reply-To: <20240609182112.13032-5-a39.skl@gmail.com>
On 09/06/2024 20:20, Adam Skladowski wrote:
> Add driver for interconnect busses found in MSM8937 based platforms.
> The topology consists of four NoCs that are partially controlled
> by a RPM processor.
>
> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
> ---
> +
> +static const struct of_device_id msm8937_noc_of_match[] = {
> + { .compatible = "qcom,msm8937-bimc", .data = &msm8937_bimc },
> + { .compatible = "qcom,msm8937-pcnoc", .data = &msm8937_pcnoc },
> + { .compatible = "qcom,msm8937-snoc", .data = &msm8937_snoc },
> + { .compatible = "qcom,msm8937-snoc-mm", .data = &msm8937_snoc_mm },
Please run scripts/checkpatch.pl and fix reported warnings. Then please
run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-10 12:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-09 18:20 [PATCH 0/7] msm8937/msm8976/qcs404 icc patches Adam Skladowski
2024-06-09 18:20 ` [PATCH 1/7] dt-bindings: interconnect: Add Qualcomm MSM8976 DT bindings Adam Skladowski
2024-06-10 12:50 ` Krzysztof Kozlowski
2024-06-09 18:20 ` [PATCH 2/7] interconnect: qcom: Add MSM8976 interconnect provider driver Adam Skladowski
2024-06-10 12:52 ` Krzysztof Kozlowski
2024-06-09 18:20 ` [PATCH 3/7] dt-bindings: interconnect: Add Qualcomm MSM8937 DT bindings Adam Skladowski
2024-06-10 12:53 ` Krzysztof Kozlowski
2024-06-09 18:20 ` [PATCH 4/7] interconnect: qcom: Add MSM8937 interconnect provider driver Adam Skladowski
2024-06-10 12:54 ` Krzysztof Kozlowski [this message]
2024-06-09 18:20 ` [PATCH 5/7] interconnect: qcom: qcs404: Introduce AP-owned nodes Adam Skladowski
2024-06-09 18:20 ` [PATCH 6/7] interconnect: qcom: qcs404: Add regmaps and more bus descriptions Adam Skladowski
2024-06-10 9:55 ` kernel test robot
2024-06-10 13:17 ` kernel test robot
2024-06-09 18:21 ` [PATCH 7/7] dt-bindings: interconnect: qcom: msm8939: Fix example Adam Skladowski
2024-06-10 12:57 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f5b9f75-528f-447b-9056-30c10f84fa98@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a39.skl@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox