Linux Power Management development
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Kaushlendra Kumar <kaushlendra.kumar@intel.com>,
	rafael@kernel.org,  lenb@kernel.org
Cc: linux-pm@vger.kernel.org
Subject: Re: [PATCH] intel_idle: Fix C6S and C10 latency values for Pantherlake
Date: Tue, 11 Aug 2026 13:06:00 +0300	[thread overview]
Message-ID: <9f75245a24905368dade4d172727933c4e1a74af.camel@gmail.com> (raw)
In-Reply-To: <20260811081729.186571-1-kaushlendra.kumar@intel.com>

Hi,

The current value are based on what I measured using wult/pbe tool.

I think it will be better to explain the problem and how this patch
fixes it, give some details about workload. And ideally, also provided
turbostat output when it runs in parallel with the workload before and
after this patch. Then we have can see CPU frequency and idle profile
of your workload with and without this patch.

Thanks!

On Tue, 2026-08-11 at 13:47 +0530, Kaushlendra Kumar wrote:
> Correct the values using BIOS ACPI _CST characterization data read from
> a Pantherlake device via
> /sys/devices/system/cpu/cpu0/cpuidle/stateN/{latency,residency}:
> 
>   C6S: exit_latency 300->127, target_residency 300->381
>   C10: exit_latency 370->1048, target_residency 2500->3144
> 
> Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
> ---
>  drivers/idle/intel_idle.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index 651408df9c24..0b5c94c7cd3a 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -1010,16 +1010,16 @@ static struct cpuidle_state ptl_cstates[] __initdata = {
>  		.name = "C6S",
>  		.desc = "MWAIT 0x21",
>  		.flags = MWAIT2flg(0x21) | CPUIDLE_FLAG_TLB_FLUSHED,
> -		.exit_latency = 300,
> -		.target_residency = 300,
> +		.exit_latency = 127,
> +		.target_residency = 381,
>  		.enter = &intel_idle,
>  		.enter_s2idle = intel_idle_s2idle, },
>  	{
>  		.name = "C10",
>  		.desc = "MWAIT 0x60",
>  		.flags = MWAIT2flg(0x60) | CPUIDLE_FLAG_TLB_FLUSHED,
> -		.exit_latency = 370,
> -		.target_residency = 2500,
> +		.exit_latency = 1048,
> +		.target_residency = 3144,
>  		.enter = &intel_idle,
>  		.enter_s2idle = intel_idle_s2idle, },
>  	{

  parent reply	other threads:[~2026-08-11 10:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11  8:17 [PATCH] intel_idle: Fix C6S and C10 latency values for Pantherlake Kaushlendra Kumar
2026-08-11 10:05 ` Artem Bityutskiy
2026-08-11 10:06 ` Artem Bityutskiy [this message]
2026-08-11 10:36   ` Kumar, Kaushlendra
2026-08-11 17:25     ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f75245a24905368dade4d172727933c4e1a74af.camel@gmail.com \
    --to=dedekind1@gmail.com \
    --cc=kaushlendra.kumar@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox