* [PATCH -next] thermal/drivers/mediatek: Remove repeating warn msg after devm_thermal_add_hwmon_sysfs()
@ 2023-08-03 1:23 Chen Jiahao
2023-08-04 4:22 ` Chen-Yu Tsai
0 siblings, 1 reply; 2+ messages in thread
From: Chen Jiahao @ 2023-08-03 1:23 UTC (permalink / raw)
To: rafael, daniel.lezcano, amitk, rui.zhang, matthias.bgg,
angelogioacchino.delregno, aouledameur, void0red, robh, daniel,
linux-pm, linux-arm-kernel, linux-mediatek
Cc: chenjiahao16
Referring to commit 8416ecfb32923 ("thermal/hwmon: Add error
information printing for devm_thermal_add_hwmon_sysfs()"),
return value has already been checked if ret != 0 in
devm_thermal_add_hwmon_sysfs(). Error handling has also been
performed in this case, including print warning message for
debugging.
Removing dev_warn() following devm_thermal_add_hwmon_sysfs()
to clean up redundant warning message.
Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
---
drivers/thermal/mediatek/auxadc_thermal.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
index c537aed71017..7f8450c66646 100644
--- a/drivers/thermal/mediatek/auxadc_thermal.c
+++ b/drivers/thermal/mediatek/auxadc_thermal.c
@@ -1289,9 +1289,7 @@ static int mtk_thermal_probe(struct platform_device *pdev)
if (IS_ERR(tzdev))
return PTR_ERR(tzdev);
- ret = devm_thermal_add_hwmon_sysfs(&pdev->dev, tzdev);
- if (ret)
- dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
+ devm_thermal_add_hwmon_sysfs(&pdev->dev, tzdev);
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] thermal/drivers/mediatek: Remove repeating warn msg after devm_thermal_add_hwmon_sysfs()
2023-08-03 1:23 [PATCH -next] thermal/drivers/mediatek: Remove repeating warn msg after devm_thermal_add_hwmon_sysfs() Chen Jiahao
@ 2023-08-04 4:22 ` Chen-Yu Tsai
0 siblings, 0 replies; 2+ messages in thread
From: Chen-Yu Tsai @ 2023-08-04 4:22 UTC (permalink / raw)
To: Chen Jiahao, rafael, daniel.lezcano
Cc: amitk, rui.zhang, matthias.bgg, angelogioacchino.delregno,
aouledameur, void0red, robh, daniel, linux-pm, linux-arm-kernel,
linux-mediatek
On Thu, Aug 3, 2023 at 9:24 AM Chen Jiahao <chenjiahao16@huawei.com> wrote:
>
> Referring to commit 8416ecfb32923 ("thermal/hwmon: Add error
> information printing for devm_thermal_add_hwmon_sysfs()"),
> return value has already been checked if ret != 0 in
> devm_thermal_add_hwmon_sysfs(). Error handling has also been
> performed in this case, including print warning message for
> debugging.
>
> Removing dev_warn() following devm_thermal_add_hwmon_sysfs()
> to clean up redundant warning message.
>
> Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-04 4:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-03 1:23 [PATCH -next] thermal/drivers/mediatek: Remove repeating warn msg after devm_thermal_add_hwmon_sysfs() Chen Jiahao
2023-08-04 4:22 ` Chen-Yu Tsai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).