linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: liu.xiang6@zte.com.cn
Cc: linux-pm@vger.kernel.org, pali.rohar@gmail.com, sre@kernel.org,
	dbaryshkov@gmail.com, dwmw2@infradead.org
Subject: Re: [PATCH] power: bq27xxx_battery: Fix bq27541 AveragePower register address
Date: Wed, 6 Jan 2016 15:49:09 +0900	[thread overview]
Message-ID: <CAJKOXPdUrRzuUUc1AaV6cSX3WbVCqUaA+oGn2REG_pYnraVEZg@mail.gmail.com> (raw)
In-Reply-To: <OF8219B649.7DD7FCA2-ON48257F32.0023C1E9-48257F32.00245EFF@zte.com.cn>

2016-01-06 15:37 GMT+09:00 <liu.xiang6@zte.com.cn>:
>
> From 410671019563323b8947a25e4cf429c41e982683 Mon Sep 17 00:00:00 2001
> Message-Id:
> <410671019563323b8947a25e4cf429c41e982683.1452047614.git.liu.xiang6@zte.com.cn>
> From: Liu Xiang <liu.xiang6@zte.com.cn>
> Date: Wed, 6 Jan 2016 10:28:27 +0800
> Subject: [PATCH] power: bq27xxx_battery: Fix bq27541 AveragePower register
>  address
>
> Currently in bq27541 driver, the average power register address is
> incorrectly set to 0x76, which would result in an error:
> bq27xxx-battery 2-0055: error reading average power register  10: -11
> According to the bq27541 datasheet, fix this problem by setting
> the average power register address to 0x24.
>
> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>

Hi,

Thanks for sharing the patch!

You are sending this patch for 3rd time I think. Please version it -
both in subject and with a changelog describing changes put after
separator '---'.

I see that you removed the confidential disclaimer and reviewed-by tag
which was not given out in a public way - good!
However the patch still has some unusual stuff added - the headers.
Usually they are not needed. Just use git and:
$ git format-patch -1 -v3
$ scripts/get_maintainers.pl v3-0001*
$ git send-email --to/cc ... v3-0001*

Best regards,
Krzysztof

  reply	other threads:[~2016-01-06  6:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-06  6:37 [PATCH] power: bq27xxx_battery: Fix bq27541 AveragePower register address liu.xiang6
2016-01-06  6:49 ` Krzysztof Kozlowski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-01-05 10:13 liu.xiang6
2016-01-05  7:04 liu.xiang6

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJKOXPdUrRzuUUc1AaV6cSX3WbVCqUaA+oGn2REG_pYnraVEZg@mail.gmail.com \
    --to=k.kozlowski@samsung.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=liu.xiang6@zte.com.cn \
    --cc=pali.rohar@gmail.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).