[PATCH] power: bq27xxx_battery: Fix bq27541 AveragePower register address

[PATCH] power: bq27xxx_battery: Fix bq27541 AveragePower register address

[liu.xiang6]

From 7dfdad8597e0cbb5324455af0acd7cfa23d23376 Mon Sep 17 00:00:00 2001
From: Liu Xiang <liu.xiang6@zte.com.cn>
Date: Tue, 15 Dec 2015 10:00:03 +0800
Subject: [PATCH] power: bq27xxx_battery: Fix bq27541 AveragePower register 
address

The average power register address 0x76 in bq27541 results in an error:
        bq27xxx-battery 2-0055: error reading average power register  10: 
-11

According to the bq27541 datasheet, AveragePower register address is 0x24.

Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
Reviewed-by: Lu ZhongJun <lu.zhongjun@zte.com.cn>

---
 drivers/power/bq27xxx_battery.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/power/bq27xxx_battery.c 
b/drivers/power/bq27xxx_battery.c
index 880233c..633f96d 100644
--- a/drivers/power/bq27xxx_battery.c
+++ b/drivers/power/bq27xxx_battery.c
@@ -242,7 +242,7 @@ static u8 bq27541_regs[] = {
        INVALID_REG_ADDR,       /* AE - NA      */
        0x2c,   /* SOC(RSOC)    */
        0x3c,   /* DCAP         */
-       0x76,   /* AP           */
+       0x24,   /* AP           */
 };

 static u8 bq27545_regs[] = {
--
1.7.1
--------------------------------------------------------
ZTE Information Security Notice: The information contained in this mail (and any attachment transmitted herewith) is privileged and confidential and is intended for the exclusive use of the addressee(s).  If you are not an intended recipient, any disclosure, reproduction, distribution or other dissemination or use of the information contained is strictly prohibited.  If you have received this mail in error, please delete it and notify us immediately.

[PATCH] power: bq27xxx_battery: Fix bq27541 AveragePower register address

[liu.xiang6]

From 7dfdad8597e0cbb5324455af0acd7cfa23d23376 Mon Sep 17 00:00:00 2001
From: Liu Xiang <liu.xiang6@zte.com.cn>
Date: Tue, 15 Dec 2015 10:00:03 +0800
Subject: [PATCH] power: bq27xxx_battery: Fix bq27541 AveragePower register 
address

The average power register address 0x76 in bq27541 results in an error:
        bq27xxx-battery 2-0055: error reading average power register  10: 
-11

According to the bq27541 datasheet, AveragePower register address is 0x24.

Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
Reviewed-by: Lu ZhongJun <lu.zhongjun@zte.com.cn>

---
 drivers/power/bq27xxx_battery.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/power/bq27xxx_battery.c 
b/drivers/power/bq27xxx_battery.c
index 880233c..633f96d 100644
--- a/drivers/power/bq27xxx_battery.c
+++ b/drivers/power/bq27xxx_battery.c
@@ -242,7 +242,7 @@ static u8 bq27541_regs[] = {
        INVALID_REG_ADDR,       /* AE - NA      */
        0x2c,   /* SOC(RSOC)    */
        0x3c,   /* DCAP         */
-       0x76,   /* AP           */
+       0x24,   /* AP           */
 };

 static u8 bq27545_regs[] = {
--
1.7.1
--------------------------------------------------------
ZTE Information Security Notice: The information contained in this mail (and any attachment transmitted herewith) is privileged and confidential and is intended for the exclusive use of the addressee(s).  If you are not an intended recipient, any disclosure, reproduction, distribution or other dissemination or use of the information contained is strictly prohibited.  If you have received this mail in error, please delete it and notify us immediately.

[PATCH] power: bq27xxx_battery: Fix bq27541 AveragePower register address

[liu.xiang6]

From 410671019563323b8947a25e4cf429c41e982683 Mon Sep 17 00:00:00 2001
Message-Id: 
<410671019563323b8947a25e4cf429c41e982683.1452047614.git.liu.xiang6@zte.com.cn>
From: Liu Xiang <liu.xiang6@zte.com.cn>
Date: Wed, 6 Jan 2016 10:28:27 +0800
Subject: [PATCH] power: bq27xxx_battery: Fix bq27541 AveragePower register
 address

Currently in bq27541 driver, the average power register address is
incorrectly set to 0x76, which would result in an error:
bq27xxx-battery 2-0055: error reading average power register  10: -11
According to the bq27541 datasheet, fix this problem by setting
the average power register address to 0x24.

Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
---
 drivers/power/bq27xxx_battery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/bq27xxx_battery.c 
b/drivers/power/bq27xxx_battery.c
index 880233c..633f96d 100644
--- a/drivers/power/bq27xxx_battery.c
+++ b/drivers/power/bq27xxx_battery.c
@@ -242,7 +242,7 @@ static u8 bq27541_regs[] = {
        INVALID_REG_ADDR,       /* AE - NA      */
        0x2c,   /* SOC(RSOC)    */
        0x3c,   /* DCAP         */
-       0x76,   /* AP           */
+       0x24,   /* AP           */
 };

 static u8 bq27545_regs[] = {
--
1.8.4.2

Re: [PATCH] power: bq27xxx_battery: Fix bq27541 AveragePower register address

[Krzysztof Kozlowski]

2016-01-06 15:37 GMT+09:00 <liu.xiang6@zte.com.cn>:
>
> From 410671019563323b8947a25e4cf429c41e982683 Mon Sep 17 00:00:00 2001
> Message-Id:
> <410671019563323b8947a25e4cf429c41e982683.1452047614.git.liu.xiang6@zte.com.cn>
> From: Liu Xiang <liu.xiang6@zte.com.cn>
> Date: Wed, 6 Jan 2016 10:28:27 +0800
> Subject: [PATCH] power: bq27xxx_battery: Fix bq27541 AveragePower register
>  address
>
> Currently in bq27541 driver, the average power register address is
> incorrectly set to 0x76, which would result in an error:
> bq27xxx-battery 2-0055: error reading average power register  10: -11
> According to the bq27541 datasheet, fix this problem by setting
> the average power register address to 0x24.
>
> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>

Hi,

Thanks for sharing the patch!

You are sending this patch for 3rd time I think. Please version it -
both in subject and with a changelog describing changes put after
separator '---'.

I see that you removed the confidential disclaimer and reviewed-by tag
which was not given out in a public way - good!
However the patch still has some unusual stuff added - the headers.
Usually they are not needed. Just use git and:
$ git format-patch -1 -v3
$ scripts/get_maintainers.pl v3-0001*
$ git send-email --to/cc ... v3-0001*

Best regards,
Krzysztof