From: "Krzysztof Kozłowski" <k.kozlowski.k@gmail.com>
To: Anda-Maria Nicolae <anda-maria.nicolae@intel.com>
Cc: sre@kernel.org, dbaryshkov@gmail.com, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
dwmw2@infradead.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4] power_supply: Add support for Richtek rt9455 battery charger
Date: Fri, 8 May 2015 21:09:27 +0900 [thread overview]
Message-ID: <CAJKOXPdvOU3RtWaodXqJ3-6exZryyUiGZbdiKfpxd_JvDaih9g@mail.gmail.com> (raw)
In-Reply-To: <1431086300-5289-1-git-send-email-anda-maria.nicolae@intel.com>
2015-05-08 20:58 GMT+09:00 Anda-Maria Nicolae <anda-maria.nicolae@intel.com>:
> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> index 4091fb0..b2b230c 100644
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> @@ -439,6 +439,13 @@ config BATTERY_RT5033
> The fuelgauge calculates and determines the battery state of charge
> according to battery open circuit voltage.
>
> +config CHARGER_RT9455
> + tristate "Richtek RT9455 battery charger driver"
> + depends on I2C && GPIOLIB
> + depends on REGMAP_I2C
Like I said previously, I still think you need to select it, not
depend on it. This is not a user-selectable option, so depending on it
may hide your driver. If you are unsure in such case you can always:
$ git grep REGMAP_I2C
Rest looks fine to me, so with the change above (s/depends on/select/):
Reviewed-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
Best regards,
Krzysztof
prev parent reply other threads:[~2015-05-08 12:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 11:58 [PATCH v4] power_supply: Add support for Richtek rt9455 battery charger Anda-Maria Nicolae
2015-05-08 12:09 ` Krzysztof Kozłowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPdvOU3RtWaodXqJ3-6exZryyUiGZbdiKfpxd_JvDaih9g@mail.gmail.com \
--to=k.kozlowski.k@gmail.com \
--cc=anda-maria.nicolae@intel.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).