From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>,
Quentin Perret <quentin.perret@arm.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Chris Redpath <chris.redpath@arm.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Valentin Schneider <valentin.schneider@arm.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Thara Gopinath <thara.gopinath@linaro.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Todd Kjos <tkjos@google.com>,
Joel Fernandes <joel@joelfernandes.org>,
Steve Muckle <smuckle@google.com>,
adharmap@codeaurora.org, Saravana Kannan <skannan@codeaurora.org>,
Pavan Kondeti <pkon>
Subject: Re: [PATCH v9 08/15] sched/topology: Make Energy Aware Scheduling depend on schedutil
Date: Thu, 22 Nov 2018 16:49:04 +0100 [thread overview]
Message-ID: <CAJZ5v0g0cca+wuZocwwt5y+a7FS6Y8qDDf27KftRQ_1Dy6-7XQ@mail.gmail.com> (raw)
In-Reply-To: <20181122140432.GH2113@hirez.programming.kicks-ass.net>
On Thu, Nov 22, 2018 at 3:05 PM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Mon, Nov 19, 2018 at 02:18:50PM +0000, Quentin Perret wrote:
> > + if (rd->pd)
> > + pr_warn("rd %*pbl: Disabling EAS, schedutil is mandatory\n",
> > + cpumask_pr_args(cpu_map));
> > + goto free;
>
> I would have preferred just not allowing the governor to change at all,
> but if you want to allow that, this is, I suppose, the best you can do.
>
> Rafael, are you otherwise OK with the grubbing inside cpufreq?
Sort of. :-)
I would put the sched_cpufreq_governor_change() header (and the static
inline stub of it) into linux/cpufreq.h (instead of
linux/sched/cpufreq.h) so that cpufreq.c doesn't have to include
linux/sched/cpufreq.h which is kind of confusing.
Apart from that the changes are fine by me.
next prev parent reply other threads:[~2018-11-22 15:49 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 14:18 [PATCH v9 00/15] Energy Aware Scheduling Quentin Perret
2018-11-19 14:18 ` [PATCH v9 01/15] sched: Relocate arch_scale_cpu_capacity Quentin Perret
2018-11-19 14:18 ` [PATCH v9 02/15] sched/cpufreq: Prepare schedutil for Energy Aware Scheduling Quentin Perret
2018-11-20 4:46 ` Viresh Kumar
2018-11-20 15:25 ` Peter Zijlstra
2018-11-20 15:53 ` Quentin Perret
2018-11-19 14:18 ` [PATCH v9 03/15] PM: Introduce an Energy Model management framework Quentin Perret
2018-11-19 14:18 ` [PATCH v9 04/15] PM / EM: Expose the Energy Model in sysfs Quentin Perret
2018-11-19 14:18 ` [PATCH v9 05/15] sched/topology: Reference the Energy Model of CPUs when available Quentin Perret
2018-11-19 14:18 ` [PATCH v9 06/15] sched/topology: Lowest CPU asymmetry sched_domain level pointer Quentin Perret
2018-11-19 14:18 ` [PATCH v9 07/15] sched/topology: Disable EAS on inappropriate platforms Quentin Perret
2018-11-19 14:18 ` [PATCH v9 08/15] sched/topology: Make Energy Aware Scheduling depend on schedutil Quentin Perret
2018-11-22 14:04 ` Peter Zijlstra
2018-11-22 15:49 ` Rafael J. Wysocki [this message]
2018-11-22 15:56 ` Quentin Perret
2018-11-19 14:18 ` [PATCH v9 09/15] sched: Introduce sched_energy_present static key Quentin Perret
2018-11-21 13:08 ` Peter Zijlstra
2018-11-21 15:14 ` Quentin Perret
2018-11-22 9:17 ` Quentin Perret
2018-11-22 9:32 ` Quentin Perret
2018-11-22 10:25 ` Peter Zijlstra
2018-11-22 15:25 ` Quentin Perret
2018-11-22 15:51 ` Rafael J. Wysocki
2018-11-22 15:55 ` Quentin Perret
2018-11-19 14:18 ` [PATCH v9 10/15] sched: Introduce a sysctl for Energy Aware Scheduling Quentin Perret
2018-11-19 14:18 ` [PATCH v9 11/15] sched/fair: Clean-up update_sg_lb_stats parameters Quentin Perret
2018-11-19 14:18 ` [PATCH v9 12/15] sched: Add over-utilization/tipping point indicator Quentin Perret
2018-11-19 14:18 ` [PATCH v9 13/15] sched/fair: Introduce an energy estimation helper function Quentin Perret
2018-11-21 14:28 ` Peter Zijlstra
2018-11-21 16:05 ` Quentin Perret
2018-11-22 13:56 ` Peter Zijlstra
2018-11-19 14:18 ` [PATCH v9 14/15] sched/fair: Select an energy-efficient CPU on task wake-up Quentin Perret
2018-11-19 14:18 ` [PATCH v9 15/15] OPTIONAL: cpufreq: dt: Register an Energy Model Quentin Perret
2018-11-20 6:19 ` Viresh Kumar
2018-11-20 10:01 ` Quentin Perret
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0g0cca+wuZocwwt5y+a7FS6Y8qDDf27KftRQ_1Dy6-7XQ@mail.gmail.com \
--to=rafael@kernel.org \
--cc=adharmap@codeaurora.org \
--cc=chris.redpath@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=quentin.perret@arm.com \
--cc=rjw@rjwysocki.net \
--cc=skannan@codeaurora.org \
--cc=smuckle@google.com \
--cc=thara.gopinath@linaro.org \
--cc=tkjos@google.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).