From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Len Brown <lenb@kernel.org>
Cc: Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>, Thomas Renninger <trenn@suse.de>
Subject: Re: [PATCH] intel_idle: stop exposing platform acronyms in sysfs
Date: Wed, 1 Mar 2017 00:55:40 +0100 [thread overview]
Message-ID: <CAJZ5v0id82bcw-i2dVhu-XsvG2PkBTRw3VtYUJ0KwzMo=YrzhA@mail.gmail.com> (raw)
In-Reply-To: <c76f694bed60071096502e065313726e399df563.1488317499.git.len.brown@intel.com>
On Tue, Feb 28, 2017 at 10:32 PM, Len Brown <lenb@kernel.org> wrote:
> From: Len Brown <len.brown@intel.com>
>
> Cosmetic only -- no functional change in this patch.
>
> sysfs before:
>
> state4/desc:MWAIT 0x20
> state4/name:C6-HSW
>
> sysfs after:
>
> state4/desc:MWAIT 0x20
> state4/name:C6
>
> We remove the platform acronyms from the end of the state name
> (-HSW in this case) for three reasonse.
>
> 1. more consistency with acpi_idle, which prints C1, C2, C3 etc.
>
> 2. users know what platform they are on already
> an acronym for the processor code name here
> seems to cause more confusion than clarity.
>
> 3. less clutter in "cpupower monitor" output,
> which truncates the names to 4 columns.
>
> The precise definition of the state continues to be available in "desc".
>
> Cc: Thomas Renninger <trenn@suse.de>
> Reported-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Signed-off-by: Len Brown <len.brown@intel.com>
I think I can apply this one right away if you want me to do that.
Thanks,
Rafael
prev parent reply other threads:[~2017-02-28 23:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 21:32 [PATCH] intel_idle: stop exposing platform acronyms in sysfs Len Brown
2017-02-28 23:55 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0id82bcw-i2dVhu-XsvG2PkBTRw3VtYUJ0KwzMo=YrzhA@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).