From: Thomas Garnier <thgarnie@google.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
Kees Cook <keescook@chromium.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>
Subject: Re: [PATCH v1 1/2] x86/power/64: Support unaligned addresses for temporary mapping
Date: Wed, 3 Aug 2016 08:29:42 -0700 [thread overview]
Message-ID: <CAJcbSZGcL9G4edsa3LEr-f0srpZPtsDTOeOjCC_nJddn6SOskg@mail.gmail.com> (raw)
In-Reply-To: <CAE9FiQVtD+eBoHEeNWGUnNAtJkDCEsq2JLg0RC9grSG7Eje3tQ@mail.gmail.com>
On Tue, Aug 2, 2016 at 12:55 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> On Tue, Aug 2, 2016 at 10:48 AM, Thomas Garnier <thgarnie@google.com> wrote:
>> On Tue, Aug 2, 2016 at 10:36 AM, Yinghai Lu <yinghai@kernel.org> wrote:
>>>
>>> Looks like we need to change the loop from phys address to virtual
>>> address instead.
>>> to avoid the overflow.
>
> something like attached.
I tested it and it worked well. I just got this warning on build:
In file included from arch/x86/mm/init_64.c:60:0:
arch/x86/mm/ident_map.c: In function ‘ident_pmd_init’:
arch/x86/mm/ident_map.c:18:29: warning: suggest parentheses around
arithmetic in operand of ‘|’ [-Wparentheses]
set_pmd(pmd, __pmd(vaddr - off | info->pmd_flag));
Do you want to resend your version for integration?
next prev parent reply other threads:[~2016-08-03 15:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 17:07 [PATCH v1 0/2] x86/power/64: Make KASLR memory randomization compatible with hibernation Thomas Garnier
2016-08-01 17:07 ` [PATCH v1 1/2] x86/power/64: Support unaligned addresses for temporary mapping Thomas Garnier
2016-08-02 0:36 ` Rafael J. Wysocki
2016-08-02 18:01 ` Yinghai Lu
2016-08-02 17:36 ` Yinghai Lu
2016-08-02 17:48 ` Thomas Garnier
2016-08-02 19:55 ` Yinghai Lu
2016-08-03 15:29 ` Thomas Garnier [this message]
2016-08-03 18:23 ` [PATCH v2] " Yinghai Lu
2016-08-03 21:28 ` Rafael J. Wysocki
2016-08-07 1:03 ` Rafael J. Wysocki
2016-08-07 4:53 ` Yinghai Lu
2016-08-07 23:23 ` Rafael J. Wysocki
2016-08-08 7:06 ` Yinghai Lu
2016-08-08 7:23 ` Yinghai Lu
2016-08-08 13:16 ` Rafael J. Wysocki
2016-08-01 17:08 ` [PATCH v1 2/2] x86/power/64: Fix __PAGE_OFFSET usage on restore Thomas Garnier
2016-08-02 0:38 ` Rafael J. Wysocki
2016-08-02 14:34 ` Thomas Garnier
2016-08-02 20:47 ` Rafael J. Wysocki
2016-08-02 20:59 ` Thomas Garnier
2016-08-02 21:08 ` Rafael J. Wysocki
2016-08-02 23:19 ` [PATCH] x86/power/64: Do not refer to __PAGE_OFFSET from assembly code Rafael J. Wysocki
2016-08-05 10:37 ` Pavel Machek
2016-08-05 14:44 ` Rafael J. Wysocki
2016-08-05 15:21 ` Thomas Garnier
2016-08-05 23:12 ` Rafael J. Wysocki
2016-08-06 19:41 ` Pavel Machek
2016-08-01 23:48 ` [PATCH v1 0/2] x86/power/64: Make KASLR memory randomization compatible with hibernation Rafael J. Wysocki
2016-08-02 0:47 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJcbSZGcL9G4edsa3LEr-f0srpZPtsDTOeOjCC_nJddn6SOskg@mail.gmail.com \
--to=thgarnie@google.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).