From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Garnier Subject: Re: [PATCH v1 1/2] x86/power/64: Support unaligned addresses for temporary mapping Date: Wed, 3 Aug 2016 08:29:42 -0700 Message-ID: References: <1470071280-78706-1-git-send-email-thgarnie@google.com> <1470071280-78706-2-git-send-email-thgarnie@google.com> Reply-To: kernel-hardening@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: List-Post: List-Help: List-Unsubscribe: List-Subscribe: In-Reply-To: To: Yinghai Lu Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Kees Cook , "Rafael J . Wysocki" , Pavel Machek , the arch/x86 maintainers , Linux Kernel Mailing List , Linux PM list , "kernel-hardening@lists.openwall.com" List-Id: linux-pm@vger.kernel.org On Tue, Aug 2, 2016 at 12:55 PM, Yinghai Lu wrote: > On Tue, Aug 2, 2016 at 10:48 AM, Thomas Garnier wro= te: >> On Tue, Aug 2, 2016 at 10:36 AM, Yinghai Lu wrote: >>> >>> Looks like we need to change the loop from phys address to virtual >>> address instead. >>> to avoid the overflow. > > something like attached. I tested it and it worked well. I just got this warning on build: In file included from arch/x86/mm/init_64.c:60:0: arch/x86/mm/ident_map.c: In function =E2=80=98ident_pmd_init=E2=80=99: arch/x86/mm/ident_map.c:18:29: warning: suggest parentheses around arithmetic in operand of =E2=80=98|=E2=80=99 [-Wparentheses] set_pmd(pmd, __pmd(vaddr - off | info->pmd_flag)); Do you want to resend your version for integration?