[PATCH 1/1] cpufreq: exynos: Fix line over 80 characters warning

[PATCH 1/1] cpufreq: exynos: Fix line over 80 characters warning

[Sachin Kamat]

Silences the checkpatch warning introduced by
commit 94aa44090eda ("cpufreq: exynos: Add missing static").

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Jonghwan Choi <jhbird.choi@samsung.com>
---
 drivers/cpufreq/exynos5250-cpufreq.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/cpufreq/exynos5250-cpufreq.c b/drivers/cpufreq/exynos5250-cpufreq.c
index 8feda86fe42c..ebbcbb7e1926 100644
--- a/drivers/cpufreq/exynos5250-cpufreq.c
+++ b/drivers/cpufreq/exynos5250-cpufreq.c
@@ -144,7 +144,8 @@ static void set_apll(unsigned int new_index,
 
 }
 
-static bool exynos5250_pms_change(unsigned int old_index, unsigned int new_index)
+static bool exynos5250_pms_change(unsigned int old_index,
+				  unsigned int new_index)
 {
 	unsigned int old_pm = apll_freq_5250[old_index].mps >> 8;
 	unsigned int new_pm = apll_freq_5250[new_index].mps >> 8;
-- 
1.7.9.5

Re: [PATCH 1/1] cpufreq: exynos: Fix line over 80 characters warning

[Viresh Kumar]

On 19 November 2013 10:37, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Silences the checkpatch warning introduced by
> commit 94aa44090eda ("cpufreq: exynos: Add missing static").
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Jonghwan Choi <jhbird.choi@samsung.com>
> ---
>  drivers/cpufreq/exynos5250-cpufreq.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Re: [PATCH 1/1] cpufreq: exynos: Fix line over 80 characters warning

[Rafael J. Wysocki]

On Tuesday, November 19, 2013 10:37:19 AM Sachin Kamat wrote:
> Silences the checkpatch warning introduced by
> commit 94aa44090eda ("cpufreq: exynos: Add missing static").
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Jonghwan Choi <jhbird.choi@samsung.com>

I'm not going to apply this and seriously if you care, please modify
checkpatch.pl to stop emitting that warning.  It is silly and useless in
my opinion, so I won't take any patches "fixing" it.

Thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [PATCH 1/1] cpufreq: exynos: Fix line over 80 characters warning

[Sachin Kamat]

On 21 November 2013 06:24, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Tuesday, November 19, 2013 10:37:19 AM Sachin Kamat wrote:
>> Silences the checkpatch warning introduced by
>> commit 94aa44090eda ("cpufreq: exynos: Add missing static").
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Cc: Jonghwan Choi <jhbird.choi@samsung.com>
>
> I'm not going to apply this and seriously if you care, please modify
> checkpatch.pl to stop emitting that warning.  It is silly and useless in
> my opinion, so I won't take any patches "fixing" it.

Agreed. However, the cpufreq drivers are pretty clean already and
this one just stands out. That was the only reason for doing this.

-- 
With warm regards,
Sachin