Re: [PATCH v7 1/5] PM / Domains: prepare for multiple states

[Axel Haslam <ahaslam@baylibre.com>]

Hi Lina,

On Tue, May 12, 2015 at 5:37 PM, Lina Iyer <lina.iyer@linaro.org> wrote:
> On Thu, Apr 30 2015 at 04:57 -0600, ahaslam@baylibre.com wrote:
>>
>> From: Axel Haslam <ahaslam+renesas@baylibre.com>
>>
>> prepare generic power domain init function parameters
>> to accept a pointer to the states structure that describes
>> the possible states that a power domain can enter.
>>
>> There is no functional change, as support for multiple
>> domains will be added in subsequent patches.
>>
>> Signed-off-by: Axel Haslam <ahaslam+renesas@baylibre.com>
>
>
> [...]
>
>> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
>> index 681ccb0..6b4802e 100644
>> --- a/include/linux/pm_domain.h
>> +++ b/include/linux/pm_domain.h
>> @@ -46,6 +46,12 @@ struct gpd_cpuidle_data {
>>         struct cpuidle_state *idle_state;
>> };
>>
>> +struct genpd_power_state {
>> +       char *name;
>> +       s64 power_off_latency_ns;
>> +       s64 power_on_latency_ns;
>> +};
>> +
>
>
> I know you carried this over from the existing code, but any reason why
> this should be signed?
>

correct, i just carried this values over as they were originally.
i suppose they can be changed to u64.

maybe a separate cleanup patch,  as it would make sense to change
some other s64's in domain.c, like "s64 elapsed_ns;"




> -- Lina