From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: next-20130206 cpufreq - WARN in sysfs_add_one Date: Fri, 8 Feb 2013 08:15:17 +0530 Message-ID: References: <9180.1360172675@turing-police.cc.vt.edu> <17233164.aBDzy1OViI@vostro.rjw.lan> <3542.1360264736@turing-police.cc.vt.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-ob0-f177.google.com ([209.85.214.177]:57135 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759097Ab3BHCpS (ORCPT ); Thu, 7 Feb 2013 21:45:18 -0500 Received: by mail-ob0-f177.google.com with SMTP id wc18so3398662obb.8 for ; Thu, 07 Feb 2013 18:45:17 -0800 (PST) In-Reply-To: <3542.1360264736@turing-police.cc.vt.edu> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Valdis.Kletnieks@vt.edu Cc: "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org On 8 February 2013 00:48, wrote: > On Thu, 07 Feb 2013 13:11:52 +0530, Viresh Kumar said: > >> First of all i want to confirm something about your system. I am sure it is a >> multi-policy system (or multi cluster system). i.e. there are more than one >> clock line for different cpus ? And so multiple struct policy exist >> simultaneously. > > Hmm.. it's a bog-standard Dell Latitude E6500 laptop, with a single > Core2 Duo P8700 CPU (one die, 2 cores, no HT). It's apparently able > to clock both cores at different speeds (one core running busy at 2540mhz > and the other idling at 800mhz), if that's what you mean by multiple > clock lines. Perfect!! So, when the cpus can manage different freqs, we have multiple struct policies for them per cpu. > In any case, next-20130206 complained, and with this patch added I see > nothing in dmesg and cpufreq is acting properly on both cores, so: > > Tested-By: Valdis Kletnieks Thanks. > (btw - I had to hand-apply your patch, as it showed up white-space > damaged. Three lines wrapped, and tabs converted to spaces). I know that and feeling bad for you :( I gave you this because of my mails issue :) http://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=shortlog;h=refs/heads/for-valdis