From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Linux PM list <linux-pm@vger.kernel.org>,
cpufreq@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>
Subject: Re: [Update][PATCH] cpufreq: Do not hold driver module references for additional policy CPUs
Date: Fri, 2 Aug 2013 15:06:41 +0530 [thread overview]
Message-ID: <CAKohpomGi0FzL-3FwsP=zzmbNMNUc6CN0S9Lyba+vx8m7MS4uQ@mail.gmail.com> (raw)
In-Reply-To: <51FB568B.1040902@linux.vnet.ibm.com>
On 2 August 2013 12:19, Srivatsa S. Bhat
<srivatsa.bhat@linux.vnet.ibm.com> wrote:
> On 08/02/2013 10:07 AM, Viresh Kumar wrote:
>> So, we can't rmmod the module as soon as it is inserted and so the
>> problem stays as is. :(
>>
>
> No, we get one step closer to the solution, since we fix the inconsistency
> between refcounts. Next step would be to get rid of refcounts and use
> locking like you suggested. Then we can rmmod it easily. I'm assuming
> Rafael has the same plan.
Not really. We are putting the reference at the end of add_dev() and
so refcount would be zero when we aren't running any critical sections.
And so, we can rmmod the module now and that problem is gone.
@Rafael: I will try to do generic cleanups in cpufreq in coming time
and will take care to remove .owner field completely in that. Until that
point your patches look fine:
For both of your patches:
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
next prev parent reply other threads:[~2013-08-02 9:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 0:08 [RFC][PATCH] cpufreq: Do not hold driver module references for additional policy CPUs Rafael J. Wysocki
2013-08-01 8:11 ` Srivatsa S. Bhat
2013-08-01 14:44 ` Viresh Kumar
2013-08-01 15:24 ` Srivatsa S. Bhat
2013-08-01 17:24 ` Viresh Kumar
2013-08-01 18:09 ` Rafael J. Wysocki
2013-08-01 18:04 ` Rafael J. Wysocki
2013-08-01 18:06 ` Srivatsa S. Bhat
2013-08-01 19:01 ` Rafael J. Wysocki
2013-08-01 19:01 ` Srivatsa S. Bhat
2013-08-01 19:21 ` Rafael J. Wysocki
2013-08-01 19:21 ` Srivatsa S. Bhat
2013-08-01 20:04 ` Rafael J. Wysocki
2013-08-01 20:26 ` Srivatsa S. Bhat
2013-08-01 20:47 ` Rafael J. Wysocki
2013-08-01 20:53 ` [Update][PATCH] " Rafael J. Wysocki
2013-08-02 4:37 ` Viresh Kumar
2013-08-02 6:49 ` Srivatsa S. Bhat
2013-08-02 6:59 ` Viresh Kumar
2013-08-02 7:09 ` Srivatsa S. Bhat
2013-08-02 7:16 ` Viresh Kumar
2013-08-02 9:36 ` Viresh Kumar [this message]
2013-08-02 10:12 ` Srivatsa S. Bhat
2013-08-02 10:55 ` Viresh Kumar
2013-08-02 13:31 ` Rafael J. Wysocki
2013-08-02 14:38 ` Viresh Kumar
2013-08-02 14:46 ` Srivatsa S. Bhat
2013-08-02 10:30 ` Viresh Kumar
2013-08-02 11:35 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKohpomGi0FzL-3FwsP=zzmbNMNUc6CN0S9Lyba+vx8m7MS4uQ@mail.gmail.com' \
--to=viresh.kumar@linaro.org \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).