From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH v3 1/5] powernv: cpufreq driver for powernv platform Date: Sat, 22 Mar 2014 09:13:21 +0530 Message-ID: References: <1395317460-14811-1-git-send-email-ego@linux.vnet.ibm.com> <1395317460-14811-2-git-send-email-ego@linux.vnet.ibm.com> <20140321104317.GA2493@in.ibm.com> <20140321144818.GA30371@dirshya.in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-ob0-f169.google.com ([209.85.214.169]:65187 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbaCVDnV (ORCPT ); Fri, 21 Mar 2014 23:43:21 -0400 Received: by mail-ob0-f169.google.com with SMTP id va2so3469699obc.28 for ; Fri, 21 Mar 2014 20:43:21 -0700 (PDT) In-Reply-To: <20140321144818.GA30371@dirshya.in.ibm.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Vaidyanathan Srinivasan Cc: Gautham R Shenoy , "linuxppc-dev@ozlabs.org" , Linux PM list , Benjamin Herrenschmidt , "Srivatsa S. Bhat" , Anton Blanchard On 21 March 2014 20:18, Vaidyanathan Srinivasan wrote: > Yeah, I had the driver written using driver_data to store pstates. > Gautham found the bug that we are missing one PState when we match the > ID with CPUFREQ_BOOST_FREQ! I see.. > We did not know that you have taken care of those issues. Ideally > I did expect that driver_data should not be touched by the framework. > Thanks for fixing that and allowing the back-end driver to use > driver_data. No, I haven't fixed anything yet. And this piece of code still exists. I will see if I can get this fixed, by that time you can continue the way your code is there in this version.