From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org,
robin.randhawa@arm.com, Steve.Bannister@arm.com,
Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com
Subject: Re: [PATCH V3 4/4] cpufreq: Add Kconfig option to enable/disable have_multiple_policies
Date: Wed, 20 Mar 2013 09:53:54 +0530 [thread overview]
Message-ID: <CAKohponm_NpYJVcMVcXfMrn+cOFH6OZ2AnWSsVVeSzpmzLM4DQ@mail.gmail.com> (raw)
In-Reply-To: <1409962.M4gLo8y6eX@vostro.rjw.lan>
On 20 March 2013 05:50, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Thursday, March 14, 2013 08:39:55 AM Viresh Kumar wrote:
>> On 14 March 2013 03:11, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>> > On Tuesday, March 12, 2013 08:55:12 AM Viresh Kumar wrote:
>> >> On 12 March 2013 07:38, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>> >> > One more question before I apply it.
>> >> >
>> >> > Is there any architecture/platform that will set
>> >> > CONFIG_CPU_FREQ_HAVE_MULTIPLE_POLICIES and keep have_multiple_policies unset
>> >> > at the same time?
>> >>
>> >> No, they are redundant. That's why i have been forcing to drop this patch.
>> >
>> > I see.
>> >
>> > What about having the Kconfig option alone, however?
>>
>> Even that is not enough. We build multiplatform kernels and so need a
>> variable to be set by platform.
>
> Which means the Kconfig option and the field are not redundant in fact.
Yes. Redundant was the wrong word. Actually Kconfig option is just not required
as we can work efficiently without it.
> But do we need the field to reside in the policy structure? It looks like
> it may just be a global bool variable
Yes. It is not per policy but per cpufreq driver. And this can be done
by sharing
a function from cpufreq core to driver. But when do you want me to
call this function
(which will set this global variable). If we do it from init, then we
will end up calling it
again and again. Then it has to be called before calling
cpufreq_register_driver(),
as init() gets called internally.
> (in which case the Kconfig option could be dropped IMO).
We are aligned now :)
> Is there any particular reason to put that thing into
> struct cpufreq_policy?
Just the problem i mentioned to you.
next prev parent reply other threads:[~2013-03-20 4:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 7:37 [PATCH V3 0/4] CPUFreq: Implement per policy instances of governors Viresh Kumar
2013-03-04 7:37 ` [PATCH V3 1/4] cpufreq: Add per policy governor-init/exit infrastructure Viresh Kumar
2013-03-04 7:37 ` [PATCH V3 2/4] cpufreq: governor: Implement per policy instances of governors Viresh Kumar
2013-03-20 5:29 ` Viresh Kumar
2013-03-21 23:44 ` Rafael J. Wysocki
2013-03-22 2:20 ` Viresh Kumar
2013-03-22 11:55 ` Rafael J. Wysocki
2013-03-22 11:51 ` Viresh Kumar
2013-03-22 12:11 ` Rafael J. Wysocki
2013-03-22 12:05 ` Viresh Kumar
2013-03-26 15:20 ` Jacob Shin
2013-03-26 19:32 ` Viresh Kumar
2013-03-26 19:48 ` Jacob Shin
2013-03-27 4:29 ` Viresh Kumar
2013-03-27 10:04 ` Viresh Kumar
2013-03-27 11:35 ` Viresh Kumar
2013-03-27 14:37 ` Viresh Kumar
2013-03-04 7:37 ` [PATCH V3 3/4] cpufreq: Get rid of "struct global_attr" Viresh Kumar
2013-03-04 7:37 ` [PATCH V3 4/4] cpufreq: Add Kconfig option to enable/disable have_multiple_policies Viresh Kumar
2013-03-11 23:38 ` Rafael J. Wysocki
2013-03-12 0:55 ` Viresh Kumar
2013-03-13 21:41 ` Rafael J. Wysocki
2013-03-14 3:09 ` Viresh Kumar
2013-03-20 0:20 ` Rafael J. Wysocki
2013-03-20 4:23 ` Viresh Kumar [this message]
2013-03-20 5:16 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKohponm_NpYJVcMVcXfMrn+cOFH6OZ2AnWSsVVeSzpmzLM4DQ@mail.gmail.com \
--to=viresh.kumar@linaro.org \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=robin.randhawa@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).