Re: [RFC PATCH 10/11] omap4: thermal: add basic CPU thermal zone

["Shilimkar, Santosh" <santosh.shilimkar@ti.com>]

On Fri, May 25, 2012 at 1:56 PM, Eduardo Valentin
<eduardo.valentin@ti.com> wrote:
> This patch exposes OMAP4 thermal sensor as a thermal zone
> named "cpu". Only thermal creation is done here.
>
> TODO:
>
>  - Add cooling bindings
>  - Add extrapolation rules
>
> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
> ---
>  drivers/thermal/Kconfig         |   12 ++++++
>  drivers/thermal/Makefile        |    1 +
>  drivers/thermal/omap-bandgap.c  |    1 +
>  drivers/thermal/omap-bandgap.h  |   12 ++++++
>  drivers/thermal/omap4-thermal.c |   72 +++++++++++++++++++++++++++++++++++++++
>  5 files changed, 98 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/thermal/omap4-thermal.c
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index ffdd240..2e82797 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -39,3 +39,15 @@ config OMAP_BANDGAP
>          This includes alert interrupts generation and also the TSHUT
>          support.
>
> +config OMAP4_THERMAL
> +       bool "Texas Instruments OMAP4 thermal support"
> +       depends on OMAP_BANDGAP
> +       depends on ARCH_OMAP4
> +       help
> +         If you say yes here you get thermal support for the Texas Instruments
> +         OMAP4 SoC family. The current chip supported are:
> +          - OMAP4460
> +
It's more of IP feature than OMAP specific, so something like

config  HAVE_BANDGAP_THERMAL_SUPPORT

and then let processor's which support enable it. That OMAP varients
in AMXX etc if needed can make use of it.

If you agree, then rest of the driver also can be cleaned to avoid
omap_* in file names and variables.

Apart from this minor comment, rest of the patch looks fine to me.

Regards
Santosh