From: Colin Cross <ccross@android.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Kevin Hilman <khilman@ti.com>, Len Brown <len.brown@intel.com>,
Russell King <linux@arm.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kay Sievers <kay.sievers@vrfy.org>,
linux-kernel@vger.kernel.org,
Amit Kucheria <amit.kucheria@linaro.org>,
linux-pm@lists.linux-foundation.org,
Arjan van de Ven <arjan@linux.intel.com>,
Arnd Bergmann <arnd.bergmann@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv3 5/5] cpuidle: coupled: add trace events
Date: Thu, 3 May 2012 14:13:27 -0700 [thread overview]
Message-ID: <CAMbhsRQWwp6TLVbHefV5c0fsb0W5=B_EVEdWtHcwc799dWEHGg@mail.gmail.com> (raw)
In-Reply-To: <1336078827.14207.109.camel@gandalf.stny.rr.com>
On Thu, May 3, 2012 at 2:00 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 2012-04-30 at 13:09 -0700, Colin Cross wrote:
>
>> diff --git a/include/trace/events/cpuidle.h b/include/trace/events/cpuidle.h
>> new file mode 100644
>> index 0000000..9b2cbbb
>> --- /dev/null
>> +++ b/include/trace/events/cpuidle.h
>> @@ -0,0 +1,243 @@
>> +#undef TRACE_SYSTEM
>> +#define TRACE_SYSTEM cpuidle
>> +
>> +#if !defined(_TRACE_CPUIDLE_H) || defined(TRACE_HEADER_MULTI_READ)
>> +#define _TRACE_CPUIDLE_H
>> +
>> +#include <linux/atomic.h>
>> +#include <linux/tracepoint.h>
>> +
>> +extern atomic_t cpuidle_trace_seq;
>> +
>> +TRACE_EVENT(coupled_enter,
>> +
>> + TP_PROTO(unsigned int cpu),
>> +
>> + TP_ARGS(cpu),
>> +
>> + TP_STRUCT__entry(
>> + __field(unsigned int, cpu)
>> + __field(unsigned int, seq)
>> + ),
>> +
>> + TP_fast_assign(
>> + __entry->cpu = cpu;
>> + __entry->seq = atomic_inc_return(&cpuidle_trace_seq);
>> + ),
>> +
>> + TP_printk("%u %u", __entry->seq, __entry->cpu)
>> +);
>> +
>> +TRACE_EVENT(coupled_exit,
>> +
>> + TP_PROTO(unsigned int cpu),
>> +
>> + TP_ARGS(cpu),
>> +
>> + TP_STRUCT__entry(
>> + __field(unsigned int, cpu)
>> + __field(unsigned int, seq)
>> + ),
>> +
>> + TP_fast_assign(
>> + __entry->cpu = cpu;
>> + __entry->seq = atomic_inc_return(&cpuidle_trace_seq);
>> + ),
>> +
>> + TP_printk("%u %u", __entry->seq, __entry->cpu)
>> +);
>> +
>> +TRACE_EVENT(coupled_spin,
>> +
>> + TP_PROTO(unsigned int cpu),
>> +
>> + TP_ARGS(cpu),
>> +
>> + TP_STRUCT__entry(
>> + __field(unsigned int, cpu)
>> + __field(unsigned int, seq)
>> + ),
>> +
>> + TP_fast_assign(
>> + __entry->cpu = cpu;
>> + __entry->seq = atomic_inc_return(&cpuidle_trace_seq);
>> + ),
>> +
>> + TP_printk("%u %u", __entry->seq, __entry->cpu)
>> +);
>> +
>> +TRACE_EVENT(coupled_unspin,
>> +
>> + TP_PROTO(unsigned int cpu),
>> +
>> + TP_ARGS(cpu),
>> +
>> + TP_STRUCT__entry(
>> + __field(unsigned int, cpu)
>> + __field(unsigned int, seq)
>> + ),
>> +
>> + TP_fast_assign(
>> + __entry->cpu = cpu;
>> + __entry->seq = atomic_inc_return(&cpuidle_trace_seq);
>> + ),
>> +
>> + TP_printk("%u %u", __entry->seq, __entry->cpu)
>> +);
>> +
>> +TRACE_EVENT(coupled_safe_enter,
>> +
>> + TP_PROTO(unsigned int cpu),
>> +
>> + TP_ARGS(cpu),
>> +
>> + TP_STRUCT__entry(
>> + __field(unsigned int, cpu)
>> + __field(unsigned int, seq)
>> + ),
>> +
>> + TP_fast_assign(
>> + __entry->cpu = cpu;
>> + __entry->seq = atomic_inc_return(&cpuidle_trace_seq);
>> + ),
>> +
>> + TP_printk("%u %u", __entry->seq, __entry->cpu)
>> +);
>> +
>> +TRACE_EVENT(coupled_safe_exit,
>> +
>> + TP_PROTO(unsigned int cpu),
>> +
>> + TP_ARGS(cpu),
>> +
>> + TP_STRUCT__entry(
>> + __field(unsigned int, cpu)
>> + __field(unsigned int, seq)
>> + ),
>> +
>> + TP_fast_assign(
>> + __entry->cpu = cpu;
>> + __entry->seq = atomic_inc_return(&cpuidle_trace_seq);
>> + ),
>> +
>> + TP_printk("%u %u", __entry->seq, __entry->cpu)
>> +);
>> +
>> +TRACE_EVENT(coupled_idle_enter,
>> +
>> + TP_PROTO(unsigned int cpu),
>> +
>> + TP_ARGS(cpu),
>> +
>> + TP_STRUCT__entry(
>> + __field(unsigned int, cpu)
>> + __field(unsigned int, seq)
>> + ),
>> +
>> + TP_fast_assign(
>> + __entry->cpu = cpu;
>> + __entry->seq = atomic_inc_return(&cpuidle_trace_seq);
>> + ),
>> +
>> + TP_printk("%u %u", __entry->seq, __entry->cpu)
>> +);
>> +
>> +TRACE_EVENT(coupled_idle_exit,
>> +
>> + TP_PROTO(unsigned int cpu),
>> +
>> + TP_ARGS(cpu),
>> +
>> + TP_STRUCT__entry(
>> + __field(unsigned int, cpu)
>> + __field(unsigned int, seq)
>> + ),
>> +
>> + TP_fast_assign(
>> + __entry->cpu = cpu;
>> + __entry->seq = atomic_inc_return(&cpuidle_trace_seq);
>> + ),
>> +
>> + TP_printk("%u %u", __entry->seq, __entry->cpu)
>> +);
>> +
>> +TRACE_EVENT(coupled_abort,
>> +
>> + TP_PROTO(unsigned int cpu),
>> +
>> + TP_ARGS(cpu),
>> +
>> + TP_STRUCT__entry(
>> + __field(unsigned int, cpu)
>> + __field(unsigned int, seq)
>> + ),
>> +
>> + TP_fast_assign(
>> + __entry->cpu = cpu;
>> + __entry->seq = atomic_inc_return(&cpuidle_trace_seq);
>> + ),
>> +
>> + TP_printk("%u %u", __entry->seq, __entry->cpu)
>> +);
>> +
>> +TRACE_EVENT(coupled_detected_abort,
>> +
>> + TP_PROTO(unsigned int cpu),
>> +
>> + TP_ARGS(cpu),
>> +
>> + TP_STRUCT__entry(
>> + __field(unsigned int, cpu)
>> + __field(unsigned int, seq)
>> + ),
>> +
>> + TP_fast_assign(
>> + __entry->cpu = cpu;
>> + __entry->seq = atomic_inc_return(&cpuidle_trace_seq);
>> + ),
>> +
>> + TP_printk("%u %u", __entry->seq, __entry->cpu)
>> +);
>> +
>> +TRACE_EVENT(coupled_poke,
>> +
>> + TP_PROTO(unsigned int cpu),
>> +
>> + TP_ARGS(cpu),
>> +
>> + TP_STRUCT__entry(
>> + __field(unsigned int, cpu)
>> + __field(unsigned int, seq)
>> + ),
>> +
>> + TP_fast_assign(
>> + __entry->cpu = cpu;
>> + __entry->seq = atomic_inc_return(&cpuidle_trace_seq);
>> + ),
>> +
>> + TP_printk("%u %u", __entry->seq, __entry->cpu)
>> +);
>> +
>> +TRACE_EVENT(coupled_poked,
>> +
>> + TP_PROTO(unsigned int cpu),
>> +
>> + TP_ARGS(cpu),
>> +
>> + TP_STRUCT__entry(
>> + __field(unsigned int, cpu)
>> + __field(unsigned int, seq)
>> + ),
>> +
>> + TP_fast_assign(
>> + __entry->cpu = cpu;
>> + __entry->seq = atomic_inc_return(&cpuidle_trace_seq);
>> + ),
>> +
>> + TP_printk("%u %u", __entry->seq, __entry->cpu)
>> +);
>
> Egad! Please use DECLARE_EVENT_CLASS() and DEFINE_EVENT() when adding
> events that are basically the same. Every TRACE_EVENT() can bloat the
> kernel by 5k, using the DEFINE_EVENT()s keeps each event around just a
> few hundred bytes.
>
> See include/trace/events/ext4.h for examples.
Thanks, I'll take a look. There is no mention in Documentation/ or
samples/ of DECLARE_EVENT_CLASS() or DEFINE_EVENT(), nor any mention
of the cost of TRACE_EVENT().
Looking at the new power tracing code, I will also rework these events
to be more similar to the existing ones.
I suggest skipping this patch for 3.5, and I'll post an updated one for 3.6.
next prev parent reply other threads:[~2012-05-03 21:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 20:09 [PATCHv3 0/5] coupled cpuidle state support Colin Cross
2012-04-30 20:09 ` [PATCHv3 1/5] cpuidle: refactor out cpuidle_enter_state Colin Cross
2012-05-03 20:50 ` Rafael J. Wysocki
2012-04-30 20:09 ` [PATCHv3 2/5] cpuidle: fix error handling in __cpuidle_register_device Colin Cross
2012-05-03 20:50 ` Rafael J. Wysocki
2012-04-30 20:09 ` [PATCHv3 3/5] cpuidle: add support for states that affect multiple cpus Colin Cross
2012-05-03 22:14 ` Rafael J. Wysocki
2012-05-03 23:09 ` Colin Cross
2012-05-04 11:51 ` Rafael J. Wysocki
2012-05-04 18:56 ` Colin Cross
2012-05-04 22:27 ` Rafael J. Wysocki
2012-04-30 20:09 ` [PATCHv3 4/5] cpuidle: coupled: add parallel barrier function Colin Cross
2012-04-30 20:09 ` [PATCHv3 5/5] cpuidle: coupled: add trace events Colin Cross
2012-05-03 21:00 ` Steven Rostedt
2012-05-03 21:13 ` Colin Cross [this message]
2012-04-30 21:18 ` [PATCHv3 0/5] coupled cpuidle state support Colin Cross
2012-04-30 21:25 ` Rafael J. Wysocki
2012-04-30 21:37 ` Colin Cross
2012-04-30 21:54 ` Rafael J. Wysocki
2012-04-30 22:01 ` Colin Cross
2012-05-03 20:00 ` Rafael J. Wysocki
2012-05-03 20:18 ` Colin Cross
2012-05-03 20:43 ` Rafael J. Wysocki
2012-05-04 10:04 ` Lorenzo Pieralisi
2012-05-01 10:43 ` Lorenzo Pieralisi
2012-05-02 0:11 ` Colin Cross
2012-05-02 7:22 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMbhsRQWwp6TLVbHefV5c0fsb0W5=B_EVEdWtHcwc799dWEHGg@mail.gmail.com' \
--to=ccross@android.com \
--cc=amit.kucheria@linaro.org \
--cc=arjan@linux.intel.com \
--cc=arnd.bergmann@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kay.sievers@vrfy.org \
--cc=khilman@ti.com \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux@arm.linux.org.uk \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).