From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Amit Kucheria" <amitk@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 20/31] thermal: rcar_gen3: Convert to platform remove callback returning void
Date: Thu, 28 Sep 2023 10:21:54 +0200 [thread overview]
Message-ID: <CAMuHMdVKCSBT7V_p+NCLUbRjAzh6Cf_sEA22U_X=bf8efgTeLA@mail.gmail.com> (raw)
In-Reply-To: <20230927193736.2236447-21-u.kleine-koenig@pengutronix.de>
On Wed, Sep 27, 2023 at 9:49 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2023-09-28 8:22 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 19:37 [PATCH 00/31] thermal: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 01/31] thermal: amlogic: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 02/31] thermal: armada: " Uwe Kleine-König
2023-10-01 16:09 ` Miquel Raynal
2023-09-27 19:37 ` [PATCH 03/31] thermal: bcm2835: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 04/31] thermal: ns: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 05/31] thermal: da9062: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 06/31] thermal: dove: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 07/31] thermal: hisi: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 08/31] thermal: imx8mm: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 09/31] thermal: imx: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 10/31] thermal: int3400: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 11/31] thermal: int3401: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 12/31] thermal: int3402: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 13/31] thermal: int3403: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 14/31] thermal: int3406: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 15/31] thermal: k3_bandgap: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 16/31] thermal: k3_j72xx_bandgap: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 17/31] thermal: kirkwood: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 18/31] thermal: lvts: " Uwe Kleine-König
2023-09-28 11:13 ` AngeloGioacchino Del Regno
2023-09-27 19:37 ` [PATCH 19/31] thermal: tsens: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 20/31] thermal: rcar_gen3: " Uwe Kleine-König
2023-09-27 19:40 ` Wolfram Sang
2023-09-28 8:21 ` Geert Uytterhoeven [this message]
2023-09-28 15:26 ` Niklas Söderlund
2023-09-27 19:37 ` [PATCH 21/31] thermal: rcar: " Uwe Kleine-König
2023-09-27 19:40 ` Wolfram Sang
2023-09-28 8:22 ` Geert Uytterhoeven
2023-09-28 15:26 ` Niklas Söderlund
2023-09-27 19:37 ` [PATCH 22/31] thermal: rockchip: " Uwe Kleine-König
2023-10-01 22:53 ` Heiko Stuebner
2023-09-27 19:37 ` [PATCH 23/31] thermal: rzg2l: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 24/31] thermal: exynos_tmu: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 25/31] thermal: spear: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 26/31] thermal: sprd: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 27/31] thermal: stm: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 28/31] thermal: soctherm: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 29/31] thermal: tegra-bpmp: " Uwe Kleine-König
2023-09-27 19:37 ` [PATCH 30/31] thermal: ti-bandgap: " Uwe Kleine-König
2023-09-28 16:09 ` Dhruva Gole
2023-09-27 19:37 ` [PATCH 31/31] thermal: uniphier: " Uwe Kleine-König
2023-09-27 19:45 ` [PATCH 00/31] thermal: " Rafael J. Wysocki
2023-09-28 7:05 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVKCSBT7V_p+NCLUbRjAzh6Cf_sEA22U_X=bf8efgTeLA@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).