From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH v6 05/11] soc: renesas: rcar-sysc: Enable Clock Domain for I/O devices Date: Fri, 22 Apr 2016 09:59:58 +0200 Message-ID: References: <1461153766-750-1-git-send-email-geert+renesas@glider.be> <1461153766-750-6-git-send-email-geert+renesas@glider.be> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org To: Ulf Hansson Cc: Geert Uytterhoeven , Simon Horman , Magnus Damm , "Rafael J. Wysocki" , Kevin Hilman , Laurent Pinchart , linux-renesas-soc@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , "linux-pm@vger.kernel.org" List-Id: linux-pm@vger.kernel.org Hi Ulf, On Fri, Apr 22, 2016 at 9:28 AM, Ulf Hansson wrote: >> @@ -217,6 +218,8 @@ static int rcar_sysc_pd_power_on(struct generic_pm_domain *genpd) >> return rcar_sysc_power_up(&pd->ch); >> } >> >> +static bool has_cpg_mstp; >> + > > That's seems lazy. :-) > > Sure you can provide this as an input parameter to > rcar_sysc_pd_setup() instead, no? This variable is intended to go away, once all R-Car SoCs have been converted to use the CPG/MSSR driver, and has_cpg_mstp will always be false. Then we can just remove those lines, instead of reworking the parameter passing. (I have to admit I just didn't think about using a parameter, but the explanation above is still valid) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds