From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 4/4] PM / Domains: Let the ->attach_dev() callback return an error code Date: Wed, 29 Oct 2014 11:28:50 +0100 Message-ID: References: <1414507090-516-1-git-send-email-ulf.hansson@linaro.org> <1414507090-516-5-git-send-email-ulf.hansson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-la0-f46.google.com ([209.85.215.46]:55222 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932072AbaJ2K2w (ORCPT ); Wed, 29 Oct 2014 06:28:52 -0400 In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Ulf Hansson Cc: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Linux PM list , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , Geert Uytterhoeven , Kevin Hilman , Alan Stern , Greg Kroah-Hartman , Tomasz Figa , Simon Horman , Magnus Damm , Ben Dooks , Kukjin Kim , Philipp Zabel , Mark Brown , Wolfram Sang , Russell King , Dmitry Torokhov , Jack Dai Hi Ulf, On Wed, Oct 29, 2014 at 11:14 AM, Ulf Hansson wrote: >>>> Given that several patch series using ->attach_dev() are already floating >>>> around and will be in -next soon, what is the plan of getting this in? >>>> Doing it ASAP (in v3.18-rc3)? >>>> Delaying this to v3.19-rc2, which will require an atomic fixing of its users? >>>> Any other option? >>> >>> I would prefer if we consider 3.18-rc[x|. That's applies also to the >>> below patchset, which actually fixes an issue. It would simplify the >>> process of handling other SOC specific patches which adds PM domain >>> support. >>> >>> [PATCH v3 0/9] PM / Domains: Fix race conditions during boot >> >> v3.18-rc[x] sounds fine. >> >>> Obviously the patches needs to be reviewed, I guess we are still in >>> the process of doing that. >> >> Indeed. >> >> Perhaps we can get just the prototype change of ->attach_dev() in first? >> That leaves some time for reviewing the code changes to actually handle >> the return value, and unblocks platform patches using ->attach_dev() soon, >> which are planned to enter in v3.19-rc. > > That's an option. > > On the other hand, that would mean that the errors that the > attach_dev() callback would return from you SOC specific code, would > just be ignored until v3.19-rc. That's not so good, hiding errors. :-) The code to handle the return value could still get in in v3.18-rc. So the errors would only be unhandled for a short while in -next. > Let's see what Rafael thinks. Right. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds