From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux PM list <linux-pm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Kevin Hilman <khilman@linaro.org>,
Alan Stern <stern@rowland.harvard.edu>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Philipp Zabel <philipp.zabel@gmail.com>,
Mark Brown <broonie@kernel.>
Subject: Re: [PATCH v5 01/11] PM / Domains: Add a detach callback to the struct dev_pm_domain
Date: Mon, 22 Sep 2014 13:15:21 +0200 [thread overview]
Message-ID: <CAMuHMdX7twqW5A1LS-RqoZHRmqZdLVCaACr45GrtyA843iVA_Q@mail.gmail.com> (raw)
In-Reply-To: <1411151264-16245-2-git-send-email-ulf.hansson@linaro.org>
On Fri, Sep 19, 2014 at 8:27 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -619,6 +619,7 @@ extern int dev_pm_put_subsys_data(struct device *dev);
> */
> struct dev_pm_domain {
> struct dev_pm_ops ops;
> + void (*detach)(struct device *, bool);
I think it would help to add the parameter names, especially for
the "bool" parameter:
void (*detach)(struct device *dev, bool power_off);
> };
>
> /*
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2014-09-22 11:15 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 18:27 [PATCH v5 00/11] PM / Domains: Generic OF-based support Ulf Hansson
2014-09-19 18:27 ` [PATCH v5 01/11] PM / Domains: Add a detach callback to the struct dev_pm_domain Ulf Hansson
2014-09-22 11:15 ` Geert Uytterhoeven [this message]
2014-09-19 18:27 ` [PATCH v5 02/11] ACPI / PM: Assign the ->detach() callback when attaching the PM domain Ulf Hansson
2014-09-19 18:27 ` [PATCH v5 03/11] PM / Domains: Add generic OF-based PM domain look-up Ulf Hansson
2014-09-19 18:27 ` [PATCH v5 04/11] PM / Domains: Add APIs to attach/detach a PM domain for a device Ulf Hansson
2014-09-22 11:12 ` Geert Uytterhoeven
2014-09-19 18:27 ` [PATCH v5 05/11] drivercore / platform: Convert to dev_pm_domain_attach|detach() Ulf Hansson
[not found] ` <1411151264-16245-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-09-19 18:27 ` [PATCH v5 06/11] i2c: core: " Ulf Hansson
[not found] ` <1411151264-16245-7-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-09-20 12:23 ` Wolfram Sang
2014-09-20 23:48 ` Rafael J. Wysocki
2014-09-22 9:52 ` Mika Westerberg
2014-09-22 10:00 ` Wolfram Sang
2014-09-19 18:27 ` [PATCH v5 07/11] mmc: sdio: " Ulf Hansson
2014-10-02 0:27 ` Dmitry Torokhov
2014-10-13 2:48 ` Aaron Lu
2014-10-13 11:44 ` Ulf Hansson
2014-09-19 18:27 ` [PATCH v5 10/11] ARM: exynos: Move to generic PM domain DT bindings Ulf Hansson
2014-09-19 18:27 ` [PATCH v5 08/11] spi: core: Convert to dev_pm_domain_attach|detach() Ulf Hansson
2014-09-19 18:27 ` [PATCH v5 09/11] amba: Add support for attach/detach of PM domains Ulf Hansson
2014-09-19 18:27 ` [PATCH v5 11/11] ACPI / PM: Convert acpi_dev_pm_detach() into a static function Ulf Hansson
2014-09-19 18:48 ` [PATCH v5 00/11] PM / Domains: Generic OF-based support Dmitry Torokhov
2014-09-22 14:19 ` Rafael J. Wysocki
2014-09-22 19:04 ` Ulf Hansson
2014-09-23 1:42 ` Mark Brown
2014-09-24 12:44 ` Grygorii Strashko
2014-09-24 13:51 ` Rafael J. Wysocki
2014-09-24 13:59 ` Grygorii Strashko
2014-09-25 11:21 ` Thierry Reding
2014-09-25 15:29 ` Ulf Hansson
2014-09-25 16:56 ` Thierry Reding
2014-09-26 0:27 ` Stephen Boyd
2014-09-26 5:08 ` Kevin Hilman
2014-09-26 7:44 ` Thierry Reding
2014-09-25 22:45 ` Kevin Hilman
2014-09-26 7:31 ` Thierry Reding
2014-09-26 8:06 ` Geert Uytterhoeven
2014-09-26 9:56 ` Thierry Reding
2014-09-26 10:01 ` Geert Uytterhoeven
2014-09-26 10:04 ` Thierry Reding
2014-09-26 14:50 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdX7twqW5A1LS-RqoZHRmqZdLVCaACr45GrtyA843iVA_Q@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=ben-linux@fluff.org \
--cc=broonie@kernel. \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=kgene.kim@samsung.com \
--cc=khilman@linaro.org \
--cc=len.brown@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=pavel@ucw.cz \
--cc=philipp.zabel@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=stern@rowland.harvard.edu \
--cc=tomasz.figa@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).