From: Amit Kucheria <amit.kucheria@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Eduardo Valentin <edubezval@gmail.com>,
Andy Gross <agross@kernel.org>, Taniya Das <tdas@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
Lina Iyer <ilina@codeaurora.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Amit Kucheria <amit.kucheria@verdurent.com>,
Zhang Rui <rui.zhang@intel.com>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v3 3/6] cpufreq: Initialise the governors in core_initcall
Date: Fri, 18 Oct 2019 01:12:06 +0530 [thread overview]
Message-ID: <CAP245DULxAXyFH8gZAdij5me6prxGyHZDiR_VC85y+PMco5WqA@mail.gmail.com> (raw)
In-Reply-To: <CAJZ5v0gAyaXHrWe5x6ctz_zawFvudgpTVFCuwieBM5s=FMXysQ@mail.gmail.com>
On Fri, Oct 18, 2019 at 12:41 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Thu, Oct 17, 2019 at 2:28 PM Amit Kucheria <amit.kucheria@linaro.org> wrote:
> >
> > Initialise the cpufreq governors earlier to allow for earlier
> > performance control during the boot process.
> >
> > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> You also want to do that for the schedutil governor I think.
Indeed. Thanks for the review. I'll respin.
>
> > ---
> > drivers/cpufreq/cpufreq_conservative.c | 2 +-
> > drivers/cpufreq/cpufreq_ondemand.c | 2 +-
> > drivers/cpufreq/cpufreq_performance.c | 2 +-
> > drivers/cpufreq/cpufreq_powersave.c | 2 +-
> > drivers/cpufreq/cpufreq_userspace.c | 2 +-
> > 5 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c
> > index b66e81c06a57..737ff3b9c2c0 100644
> > --- a/drivers/cpufreq/cpufreq_conservative.c
> > +++ b/drivers/cpufreq/cpufreq_conservative.c
> > @@ -346,7 +346,7 @@ struct cpufreq_governor *cpufreq_default_governor(void)
> > return CPU_FREQ_GOV_CONSERVATIVE;
> > }
> >
> > -fs_initcall(cpufreq_gov_dbs_init);
> > +core_initcall(cpufreq_gov_dbs_init);
> > #else
> > module_init(cpufreq_gov_dbs_init);
> > #endif
> > diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
> > index dced033875bf..82a4d37ddecb 100644
> > --- a/drivers/cpufreq/cpufreq_ondemand.c
> > +++ b/drivers/cpufreq/cpufreq_ondemand.c
> > @@ -483,7 +483,7 @@ struct cpufreq_governor *cpufreq_default_governor(void)
> > return CPU_FREQ_GOV_ONDEMAND;
> > }
> >
> > -fs_initcall(cpufreq_gov_dbs_init);
> > +core_initcall(cpufreq_gov_dbs_init);
> > #else
> > module_init(cpufreq_gov_dbs_init);
> > #endif
> > diff --git a/drivers/cpufreq/cpufreq_performance.c b/drivers/cpufreq/cpufreq_performance.c
> > index aaa04dfcacd9..def9afe0f5b8 100644
> > --- a/drivers/cpufreq/cpufreq_performance.c
> > +++ b/drivers/cpufreq/cpufreq_performance.c
> > @@ -50,5 +50,5 @@ MODULE_AUTHOR("Dominik Brodowski <linux@brodo.de>");
> > MODULE_DESCRIPTION("CPUfreq policy governor 'performance'");
> > MODULE_LICENSE("GPL");
> >
> > -fs_initcall(cpufreq_gov_performance_init);
> > +core_initcall(cpufreq_gov_performance_init);
> > module_exit(cpufreq_gov_performance_exit);
> > diff --git a/drivers/cpufreq/cpufreq_powersave.c b/drivers/cpufreq/cpufreq_powersave.c
> > index c143dc237d87..1ae66019eb83 100644
> > --- a/drivers/cpufreq/cpufreq_powersave.c
> > +++ b/drivers/cpufreq/cpufreq_powersave.c
> > @@ -43,7 +43,7 @@ struct cpufreq_governor *cpufreq_default_governor(void)
> > return &cpufreq_gov_powersave;
> > }
> >
> > -fs_initcall(cpufreq_gov_powersave_init);
> > +core_initcall(cpufreq_gov_powersave_init);
> > #else
> > module_init(cpufreq_gov_powersave_init);
> > #endif
> > diff --git a/drivers/cpufreq/cpufreq_userspace.c b/drivers/cpufreq/cpufreq_userspace.c
> > index cbd81c58cb8f..b43e7cd502c5 100644
> > --- a/drivers/cpufreq/cpufreq_userspace.c
> > +++ b/drivers/cpufreq/cpufreq_userspace.c
> > @@ -147,7 +147,7 @@ struct cpufreq_governor *cpufreq_default_governor(void)
> > return &cpufreq_gov_userspace;
> > }
> >
> > -fs_initcall(cpufreq_gov_userspace_init);
> > +core_initcall(cpufreq_gov_userspace_init);
> > #else
> > module_init(cpufreq_gov_userspace_init);
> > #endif
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2019-10-17 19:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 12:27 [PATCH v3 0/6] Initialise thermal framework and cpufreq earlier during boot Amit Kucheria
2019-10-17 12:27 ` [PATCH v3 1/6] thermal: Remove netlink support Amit Kucheria
2019-10-18 6:05 ` Viresh Kumar
2019-10-17 12:27 ` [PATCH v3 2/6] thermal: Initialize thermal subsystem earlier Amit Kucheria
2019-10-18 6:06 ` Viresh Kumar
2019-10-17 12:27 ` [PATCH v3 3/6] cpufreq: Initialise the governors in core_initcall Amit Kucheria
2019-10-17 19:11 ` Rafael J. Wysocki
2019-10-17 19:42 ` Amit Kucheria [this message]
2019-10-17 12:27 ` [PATCH v3 4/6] cpufreq: Initialize cpufreq-dt driver earlier Amit Kucheria
2019-10-17 12:27 ` [PATCH v3 6/6] cpufreq: qcom-hw: Move driver initialisation earlier Amit Kucheria
2019-10-17 18:19 ` Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP245DULxAXyFH8gZAdij5me6prxGyHZDiR_VC85y+PMco5WqA@mail.gmail.com \
--to=amit.kucheria@linaro.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@verdurent.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=sudeep.holla@arm.com \
--cc=swboyd@chromium.org \
--cc=tdas@codeaurora.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).