From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B12B9ECE58D for ; Thu, 17 Oct 2019 19:42:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 824CE2067B for ; Thu, 17 Oct 2019 19:42:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="auy/Umx4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727796AbfJQTmU (ORCPT ); Thu, 17 Oct 2019 15:42:20 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:38132 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726733AbfJQTmT (ORCPT ); Thu, 17 Oct 2019 15:42:19 -0400 Received: by mail-qt1-f196.google.com with SMTP id j31so5368547qta.5 for ; Thu, 17 Oct 2019 12:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n0cRSBeI5QiEyBOk4yyCnBrOWirqw7hqnVbP7QBmeig=; b=auy/Umx49q7PLPDN0XFugnCa+/qbWVIPanKLjT4dmZHNNUk0RuNRmyuDtmbKsVS5G9 Tfv3SJbewZEJvt+APi+7p9SqmKFg22P3pH0sKhxFsJxCF+ck6gl7OhNNkE3SS1kKFUQZ ZM4gvehmyNfn+xM+sDC4a4o4YQlchMj/1dmHgdpujaIsyKKGdoy++v+FeGPO0vmwXKwR mB4GwbNxn/f99jtc5IIs3WrtrxZZmQACBSmQ8h06Xg11P0jQIitWRpiTr1UhXjTfuOEz UjZ63PR4pTUOHr/hLLJhsFWkB6rCsdr7XKNOdwninmr5S6j4c3Qwb8jCxYttIMM5AXAc Ggfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n0cRSBeI5QiEyBOk4yyCnBrOWirqw7hqnVbP7QBmeig=; b=cPHyYbceUrOEpIfhBsLv9Ms+/ITTqnLuMMzz7TDaZPOHtOZUOusGUXNZZ9aIOffxjl y2w8N53zIYd5YhZuTlFS5IUYsIMfvbMTIk6HzjcJ9FyAiDvq4AwHOUK0LZQgMtfuXUMB FtLQo6EiJrUCLky5WseIYpAJyXkt2uhpc9B7lHOhkWny4edKmN0OfOekSHyz1V2CHDeV sspQJ4md3Bwpz8sLyjMoAZvO3P8SP4V0HKttJNS8Deel4Dll5shb2yMf313jz8nA9JDH lWVKyWZvyThOre0LOyCEO7pRcRk3nwo54ACEooajORoa6OQ3a0aSaztSRc/49hlqwywR xqcA== X-Gm-Message-State: APjAAAX8qob9BfEsvRgyKuXO4tJtmaqIE3BQk9YbJ0+mUf81oy9dD+gw 1dvazk7j2UQqYwRho5Dq0azX4cIQ0bvwxaYf/cMVjg== X-Google-Smtp-Source: APXvYqzflMcI4I980dwsJblkSENtr+BcULK0/FnGCeDdiaa72OT/ajTWNOHYH720MMux8SQ6xxuTa0vtrLKUycuRHGc= X-Received: by 2002:ac8:237b:: with SMTP id b56mr5994000qtb.264.1571341337992; Thu, 17 Oct 2019 12:42:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Amit Kucheria Date: Fri, 18 Oct 2019 01:12:06 +0530 Message-ID: Subject: Re: [PATCH v3 3/6] cpufreq: Initialise the governors in core_initcall To: "Rafael J. Wysocki" Cc: Linux Kernel Mailing List , linux-arm-msm , Daniel Lezcano , Viresh Kumar , Sudeep Holla , Bjorn Andersson , Eduardo Valentin , Andy Gross , Taniya Das , Stephen Boyd , Lina Iyer , "Rafael J. Wysocki" , Amit Kucheria , Zhang Rui , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, Oct 18, 2019 at 12:41 AM Rafael J. Wysocki wrote: > > On Thu, Oct 17, 2019 at 2:28 PM Amit Kucheria wrote: > > > > Initialise the cpufreq governors earlier to allow for earlier > > performance control during the boot process. > > > > Signed-off-by: Amit Kucheria > > Acked-by: Viresh Kumar > > You also want to do that for the schedutil governor I think. Indeed. Thanks for the review. I'll respin. > > > --- > > drivers/cpufreq/cpufreq_conservative.c | 2 +- > > drivers/cpufreq/cpufreq_ondemand.c | 2 +- > > drivers/cpufreq/cpufreq_performance.c | 2 +- > > drivers/cpufreq/cpufreq_powersave.c | 2 +- > > drivers/cpufreq/cpufreq_userspace.c | 2 +- > > 5 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c > > index b66e81c06a57..737ff3b9c2c0 100644 > > --- a/drivers/cpufreq/cpufreq_conservative.c > > +++ b/drivers/cpufreq/cpufreq_conservative.c > > @@ -346,7 +346,7 @@ struct cpufreq_governor *cpufreq_default_governor(void) > > return CPU_FREQ_GOV_CONSERVATIVE; > > } > > > > -fs_initcall(cpufreq_gov_dbs_init); > > +core_initcall(cpufreq_gov_dbs_init); > > #else > > module_init(cpufreq_gov_dbs_init); > > #endif > > diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c > > index dced033875bf..82a4d37ddecb 100644 > > --- a/drivers/cpufreq/cpufreq_ondemand.c > > +++ b/drivers/cpufreq/cpufreq_ondemand.c > > @@ -483,7 +483,7 @@ struct cpufreq_governor *cpufreq_default_governor(void) > > return CPU_FREQ_GOV_ONDEMAND; > > } > > > > -fs_initcall(cpufreq_gov_dbs_init); > > +core_initcall(cpufreq_gov_dbs_init); > > #else > > module_init(cpufreq_gov_dbs_init); > > #endif > > diff --git a/drivers/cpufreq/cpufreq_performance.c b/drivers/cpufreq/cpufreq_performance.c > > index aaa04dfcacd9..def9afe0f5b8 100644 > > --- a/drivers/cpufreq/cpufreq_performance.c > > +++ b/drivers/cpufreq/cpufreq_performance.c > > @@ -50,5 +50,5 @@ MODULE_AUTHOR("Dominik Brodowski "); > > MODULE_DESCRIPTION("CPUfreq policy governor 'performance'"); > > MODULE_LICENSE("GPL"); > > > > -fs_initcall(cpufreq_gov_performance_init); > > +core_initcall(cpufreq_gov_performance_init); > > module_exit(cpufreq_gov_performance_exit); > > diff --git a/drivers/cpufreq/cpufreq_powersave.c b/drivers/cpufreq/cpufreq_powersave.c > > index c143dc237d87..1ae66019eb83 100644 > > --- a/drivers/cpufreq/cpufreq_powersave.c > > +++ b/drivers/cpufreq/cpufreq_powersave.c > > @@ -43,7 +43,7 @@ struct cpufreq_governor *cpufreq_default_governor(void) > > return &cpufreq_gov_powersave; > > } > > > > -fs_initcall(cpufreq_gov_powersave_init); > > +core_initcall(cpufreq_gov_powersave_init); > > #else > > module_init(cpufreq_gov_powersave_init); > > #endif > > diff --git a/drivers/cpufreq/cpufreq_userspace.c b/drivers/cpufreq/cpufreq_userspace.c > > index cbd81c58cb8f..b43e7cd502c5 100644 > > --- a/drivers/cpufreq/cpufreq_userspace.c > > +++ b/drivers/cpufreq/cpufreq_userspace.c > > @@ -147,7 +147,7 @@ struct cpufreq_governor *cpufreq_default_governor(void) > > return &cpufreq_gov_userspace; > > } > > > > -fs_initcall(cpufreq_gov_userspace_init); > > +core_initcall(cpufreq_gov_userspace_init); > > #else > > module_init(cpufreq_gov_userspace_init); > > #endif > > -- > > 2.17.1 > >