From: Ulf Hansson <ulf.hansson@linaro.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Lina Iyer <lina.iyer@linaro.org>,
Kevin Hilman <khilman@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Len Brown <len.brown@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] PM / Domains: Fix a warning message
Date: Thu, 10 Nov 2016 20:25:36 +0100 [thread overview]
Message-ID: <CAPDyKFouTue7DbDg0n136L_XO4UGX4_DiRh8Hr6zXy4a8_c5EA@mail.gmail.com> (raw)
In-Reply-To: <20161110125215.GA18664@mwanda>
On 10 November 2016 at 13:52, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The first argument of WARN() is the condition, followed by the message.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 661737c..7b4d41f 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1297,7 +1297,7 @@ static int genpd_add_subdomain(struct generic_pm_domain *genpd,
> * powered on/off in that context.
> */
> if (!genpd_is_irq_safe(genpd) && genpd_is_irq_safe(subdomain)) {
> - WARN("Parent %s of subdomain %s must be IRQ safe\n",
> + WARN(1, "Parent %s of subdomain %s must be IRQ safe\n",
> genpd->name, subdomain->name);
> return -EINVAL;
> }
next prev parent reply other threads:[~2016-11-10 19:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 12:52 [patch] PM / Domains: Fix a warning message Dan Carpenter
2016-11-10 16:33 ` Pavel Machek
2016-11-10 19:25 ` Ulf Hansson [this message]
2016-11-14 0:40 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFouTue7DbDg0n136L_XO4UGX4_DiRh8Hr6zXy4a8_c5EA@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=lina.iyer@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).