From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [patch] PM / Domains: Fix a warning message Date: Thu, 10 Nov 2016 20:25:36 +0100 Message-ID: References: <20161110125215.GA18664@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-wm0-f52.google.com ([74.125.82.52]:33971 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934945AbcKJTZj (ORCPT ); Thu, 10 Nov 2016 14:25:39 -0500 Received: by mail-wm0-f52.google.com with SMTP id u144so55079273wmu.1 for ; Thu, 10 Nov 2016 11:25:38 -0800 (PST) In-Reply-To: <20161110125215.GA18664@mwanda> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Dan Carpenter Cc: "Rafael J. Wysocki" , Lina Iyer , Kevin Hilman , Pavel Machek , Len Brown , Greg Kroah-Hartman , "linux-pm@vger.kernel.org" , kernel-janitors@vger.kernel.org On 10 November 2016 at 13:52, Dan Carpenter wrote: > The first argument of WARN() is the condition, followed by the message. > > Signed-off-by: Dan Carpenter Acked-by: Ulf Hansson Kind regards Uffe > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 661737c..7b4d41f 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -1297,7 +1297,7 @@ static int genpd_add_subdomain(struct generic_pm_domain *genpd, > * powered on/off in that context. > */ > if (!genpd_is_irq_safe(genpd) && genpd_is_irq_safe(subdomain)) { > - WARN("Parent %s of subdomain %s must be IRQ safe\n", > + WARN(1, "Parent %s of subdomain %s must be IRQ safe\n", > genpd->name, subdomain->name); > return -EINVAL; > }