Re: [PATCH] PM / Domains: Restore lock-less behaviour for the genpd syscore APIs

[Ulf Hansson <ulf.hansson@linaro.org>]

Hi Lina,

--
>> drivers/base/power/domain.c | 48
>> +++++++++++++++++++++++++--------------------
>> 1 file changed, 27 insertions(+), 21 deletions(-)
>>
>> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
>> index 271e208..3a75fb1 100644
>> --- a/drivers/base/power/domain.c
>> +++ b/drivers/base/power/domain.c
>> @@ -729,16 +729,17 @@ static bool genpd_dev_active_wakeup(struct
>> generic_pm_domain *genpd,
>> /**
>>  * genpd_sync_power_off - Synchronously power off a PM domain and its
>> masters.
>>  * @genpd: PM domain to power off, if possible.
>> + * @use_lock: use the lock.
>
>
> I am not too fond of this. It would rather be much cleaner if you could
> overload the genpd_lock/unlock() calls to make this genpd lockless. A
> flag for the genpd, perhaps that could turn the lock functions into a
> NOP?

That's not going to work, because this isn't about a lock-less genpd.

The problem occurs only during system suspend for a syscore device (in
this case the sh_cmt_clock_event device), calling pm_genpd_syscore*
APIs.

Kind regards
Uffe