From: Ulf Hansson <ulf.hansson@linaro.org>
To: Lina Iyer <lina.iyer@linaro.org>
Cc: Kevin Hilman <khilman@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Andy Gross <andy.gross@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
Brendan Jackman <brendan.jackman@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Juri Lelli <Juri.Lelli@arm.com>,
Marc Titinger <mtitinger+renesas@baylibre.com>
Subject: Re: [PATCH v2 3/8] PM / Domains: Allow domain power states to be read from DT
Date: Mon, 10 Oct 2016 23:24:55 +0200 [thread overview]
Message-ID: <CAPDyKFru7fjqnxWbMdjsYu5ZMQd1j_vduAFXusWkwspVjzCMcw@mail.gmail.com> (raw)
In-Reply-To: <20161010150301.GA44885@linaro.org>
[...]
>>> +int of_genpd_parse_idle_states(struct device_node *dn,
>>> + struct genpd_power_state **states, int *n)
>>
>>
>> Instead of taking **states as a parameter, let's instead return it as
>> a pointer for the allocated struct. In case of failures, let's return
>> ERR_PTR().
>>
> Hmm.. I thought about it. There are 2 return values from this function.
> If we return a pointer to the allocated memory, we still have to return
> the size of it as an argument. I wasn't happy splitting the return
> values in 2 different places.
Ahh, right. So let's keep it as is!
[...]
Kind regards
Uffe
next prev parent reply other threads:[~2016-10-10 21:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 22:36 [PATCH v2 0/8] PM / Domains: DT support for domain idle states & atomic PM domains Lina Iyer
2016-10-07 22:36 ` [PATCH v2 1/8] PM / Domains: Make genpd state allocation dynamic Lina Iyer
2016-10-10 8:40 ` Ulf Hansson
2016-10-10 15:05 ` Lina Iyer
2016-10-07 22:36 ` [PATCH v2 2/8] PM / Domain: Add residency property to genpd states Lina Iyer
2016-10-07 22:36 ` [PATCH v2 3/8] PM / Domains: Allow domain power states to be read from DT Lina Iyer
2016-10-10 10:01 ` Ulf Hansson
2016-10-10 15:03 ` Lina Iyer
2016-10-10 21:24 ` Ulf Hansson [this message]
2016-10-07 22:36 ` [PATCH v2 4/8] PM / Domains: Save the fwnode in genpd_power_state Lina Iyer
2016-10-10 10:03 ` Ulf Hansson
2016-10-07 22:36 ` [PATCH v2 5/8] dt/bindings: Update binding for PM domain idle states Lina Iyer
2016-10-10 15:45 ` Sudeep Holla
2016-10-10 16:43 ` Lina Iyer
[not found] ` <20161010164342.GC44885-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-10 17:13 ` Sudeep Holla
2016-10-10 22:13 ` Lina Iyer
2016-10-11 11:29 ` Sudeep Holla
2016-10-10 17:19 ` Sudeep Holla
2016-10-07 22:36 ` [PATCH v2 6/8] PM / Domains: Abstract genpd locking Lina Iyer
2016-10-07 22:37 ` [PATCH v2 7/8] PM / Domains: Support IRQ safe PM domains Lina Iyer
2016-10-10 11:04 ` Ulf Hansson
2016-10-07 22:37 ` [PATCH v2 8/8] PM / doc: Update device documentation for devices in " Lina Iyer
2016-10-10 11:06 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFru7fjqnxWbMdjsYu5ZMQd1j_vduAFXusWkwspVjzCMcw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=Juri.Lelli@arm.com \
--cc=andy.gross@linaro.org \
--cc=brendan.jackman@arm.com \
--cc=khilman@kernel.org \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mtitinger+renesas@baylibre.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).