From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23C31C25B0E for ; Tue, 16 Aug 2022 13:30:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235744AbiHPNao (ORCPT ); Tue, 16 Aug 2022 09:30:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235827AbiHPNad (ORCPT ); Tue, 16 Aug 2022 09:30:33 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08C71B8F0D for ; Tue, 16 Aug 2022 06:30:32 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id ay39-20020a05600c1e2700b003a5503a80cfso5383185wmb.2 for ; Tue, 16 Aug 2022 06:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc; bh=hc7qC7bI2uO2D4Qa+zC5gvmq4/4IvbZWBk2kTcS1e4g=; b=p1uIS7iPRm5FqeZyBT0Rono6HWbv5ulB/bs5oZgYh6d9a1ptIjWxTqIf5fdui0UI7P UiKMVSr+4RtXLv4oOr9y9VG9zkJ7wYmACViu7FoZAAHh0fx2AK3IeW287cwTA94pjy7W 58dOOYI3IkZoR37TVr4OI4CDMlz7EA6HMoFO3Ex0IHnawCAeW+LTa/T3QasiPuhhYTYG mUk4SHi+5Q/GbXbDglXaTas5nW1FpgGGNDDHSmOKsKRkDWE1GvW1FLM0ls2tIh887+7e gGI8c1mDEYenpo65eLgr7mEvWZmy3MQSEE91lN0cZg0rhMVt+ckyO47lwF8zoDEr71bJ 5C6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc; bh=hc7qC7bI2uO2D4Qa+zC5gvmq4/4IvbZWBk2kTcS1e4g=; b=5MYWuYAb1p5CFc7ijgJenDszkbLt9mIUwDPQSLpDS7/fDz83gYSh2QSsu7i424XADw d4fyw/VSprnUKllr7i9tDQ/3n1oibZe9lY/E5hpSNqbw1DdXu8+Vpey8dJ9YsRrrEYeP XJIY5iFPKrp/BStJA27Awd4xNbpZzZwS2KqC5ggWlJPf2yZ7Xhn4WPwQwIzN85S2uV3O +GSrrniiPH7p3AP72lt4KHnb3uto3hTKasoP+p8dzIlI9CENzqLCJkcXO5J0BIhRx9af y9CgO77OI7bT3lvuQ+3VRYtmSWLgiTUVSnE7WZZZaj48MSwU+PRNKVthnPVSmBN+R+K8 FoQQ== X-Gm-Message-State: ACgBeo3l8fLfvU9hk04nftu2PjDocyWlA8ncm+uKUETVpkx9itM3GJ0j uQBV48bAG8wYzEniDX67lZJ6IA== X-Google-Smtp-Source: AA6agR5brmQT0VGVlB3KYey11S8HsfHLRIqrWymjHMuDRQM1mXOpHIasTetNNd2nw2J4QFqsRY8/MA== X-Received: by 2002:a1c:f217:0:b0:3a4:bfd4:21b4 with SMTP id s23-20020a1cf217000000b003a4bfd421b4mr12934932wmc.96.1660656630403; Tue, 16 Aug 2022 06:30:30 -0700 (PDT) Received: from localhost (2a02-8388-6582-fe80-0000-0000-0000-0002.cable.dynamic.v6.surfer.at. [2a02:8388:6582:fe80::2]) by smtp.gmail.com with ESMTPSA id n6-20020a05600c3b8600b003a608d69a64sm1870148wms.21.2022.08.16.06.30.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 06:30:29 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 16 Aug 2022 15:30:26 +0200 Message-Id: Subject: Re: [PATCH v1 0/3] Bring back driver_deferred_probe_check_state() for now From: "Luca Weiss" To: "Saravana Kannan" Cc: "Tony Lindgren" , "Greg Kroah-Hartman" , "Rafael J. Wysocki" , "Kevin Hilman" , "Ulf Hansson" , "Pavel Machek" , "Len Brown" , "Andrew Lunn" , "Heiner Kallweit" , "Russell King" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , , , , , X-Mailer: aerc 0.11.0 References: <20220727185012.3255200-1-saravanak@google.com> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Saravana, On Tue Aug 16, 2022 at 1:36 AM CEST, Saravana Kannan wrote: > On Mon, Aug 15, 2022 at 9:57 AM Luca Weiss wro= te: > > > > On Mon Aug 15, 2022 at 1:01 PM CEST, Tony Lindgren wrote: > > > * Saravana Kannan [700101 02:00]: > > > > More fixes/changes are needed before driver_deferred_probe_check_st= ate() > > > > can be deleted. So, bring it back for now. > > > > > > > > Greg, > > > > > > > > Can we get this into 5.19? If not, it might not be worth picking up= this > > > > series. I could just do the other/more fixes in time for 5.20. > > > > > > Yes please pick this as fixes for v6.0-rc series, it fixes booting fo= r > > > me. I've replied with fixes tags for the two patches that were causin= g > > > regressions for me. > > > > > > > Hi, > > > > for me Patch 1+3 fix display probe on Qualcomm SM6350 (although display > > for this SoC isn't upstream yet, there are lots of other SoCs with very > > similar setup). > > > > Probe for DPU silently fails, with CONFIG_DEBUG_DRIVER=3Dy we get this: > > > > msm-mdss ae00000.mdss: __genpd_dev_pm_attach() failed to find PM domain= : -2 > > > > While I'm not familiar with the specifics of fw_devlink, the dtsi has > > power-domains =3D <&dispcc MDSS_GDSC> for this node but it doesn't pick > > that up for some reason. > > > > We can also see that a bit later dispcc finally probes. > > Luca, > > Can you test with this series instead and see if it fixes this issue? > https://lore.kernel.org/lkml/20220810060040.321697-1-saravanak@google.com= / > Unfortunately it doesn't seem to work with the 9 patches, and the attached diff also doesn't seem to make a difference. I do see this in dmesg which I haven't seen in the past: [ 0.056554] platform 1d87000.phy: Fixed dependency cycle(s) with /soc@0/= ufs@1d84000 [ 0.060070] platform ae00000.mdss: Fixed dependency cycle(s) with /soc@0= /clock-controller@af00000 [ 0.060150] platform ae00000.mdss: Failed to create device link with ae0= 0000.mdss [ 0.060188] platform ae00000.mdss: Failed to create device link with ae0= 0000.mdss [ 0.061135] platform c440000.spmi: Failed to create device link with c44= 0000.spmi [ 0.061157] platform c440000.spmi: Failed to create device link with c44= 0000.spmi [ 0.061180] platform c440000.spmi: Failed to create device link with c44= 0000.spmi [ 0.061198] platform c440000.spmi: Failed to create device link with c44= 0000.spmi [ 0.061215] platform c440000.spmi: Failed to create device link with c44= 0000.spmi [ 0.061231] platform c440000.spmi: Failed to create device link with c44= 0000.spmi [ 0.061252] platform c440000.spmi: Failed to create device link with c44= 0000.spmi Also I'm going to be on holiday from today for about 2 weeks so I won't be able to test anything in that time. And in case it's interesting, here's the full dmesg to initramfs: https://pastebin.com/raw/Fc8W4MVi Regards Luca > You might also need to add this delta on top of the series if the > series itself isn't sufficient. > diff --git a/drivers/base/core.c b/drivers/base/core.c > index 2f012e826986..866755d8ad95 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -2068,7 +2068,11 @@ static int fw_devlink_create_devlink(struct device= *con, > device_links_write_unlock(); > } > > - sup_dev =3D get_dev_from_fwnode(sup_handle); > + if (sup_handle->flags & FWNODE_FLAG_NOT_DEVICE) > + sup_dev =3D fwnode_get_next_parent_dev(sup_handle); > + else > + sup_dev =3D get_dev_from_fwnode(sup_handle); > + > if (sup_dev) { > /* > * If it's one of those drivers that don't actually bind = to > > -Saravana