From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 626BBC4332F for ; Wed, 23 Nov 2022 07:32:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235962AbiKWHch (ORCPT ); Wed, 23 Nov 2022 02:32:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235343AbiKWHcf (ORCPT ); Wed, 23 Nov 2022 02:32:35 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7203E2673 for ; Tue, 22 Nov 2022 23:32:28 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id ud5so40809313ejc.4 for ; Tue, 22 Nov 2022 23:32:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=d4qo3fGXZQy+8oZhU7cu78EOId5JBj3qLdZ14a/QvWs=; b=A+BOWQfr+GHxiyky3FGgeGI42YGjsE2iWDptOAvatoeyB9b+yQTLOul0n5laPGqlbe A8piGSB5NYg/4Mx8w+5UKEgUuUDPNeVCoiivRVSTZ+v7IQJABI+rxTTv9og6rk9YteNK 46KvaNjHzhJc+JNV46ND6MLRLfneU7Bq3if2AEqmq4uvB1qBgpwg4/LiW9UpX2cF/WJG zRrKF8HL05kapczSgtl+WiYryLavK86jPzLVFl7Pt6cIk5zN7kyYrvTXie5dEcjDEerw B0xxdzXGaCXRdKnoJ2HGdD4lI8QQ02xOFPnp/IoUPQ0/13E6ecEHNzIP8y8jALv0Fp76 p3+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=d4qo3fGXZQy+8oZhU7cu78EOId5JBj3qLdZ14a/QvWs=; b=ZE2lD8DvizyyZnS2mrqVpEpDZRU4FMB6PXYqEIbXIWIlANThvt0K5zHDftKc37n0np J0l9X1UjsQHqL/aojkfdQ1tUBkU73g7kSwZhaORwq8FOe095+delsVmQqBu1hoVV4yUT V5v62oxf6oFRpffHQfMQpuMwOjNheB0WLHddtefpG5bgBsJslmDkMhuNVgmqXZtkLdVT nPbnydM/ytppT213dNbvImoJokYbmFyKmh9cmlBDA63WCkfuTXnOaqVFTmP1FeK+MmSz Tu2C78XkirKgI5rH2EvqtZ9xmP67KP5ETtVhO+jk56LwqoFh4eg83IN0hUVlTk1yYSNl DwyA== X-Gm-Message-State: ANoB5pkNf5xE2bKjOBdR1O35CP4FlidtZsdGxkHw2snPmws43uoLeeba F7TG49Db+nB6nEqVANwBynivFw== X-Google-Smtp-Source: AA0mqf7YzWyH2VU2YnkG3jnX1ifCWu9zwuLgz/9nZTRc2x7pdPbOoX1z9PpmE2lNj2LlqmhLHx0DGA== X-Received: by 2002:a17:906:2302:b0:7b9:de77:f0ef with SMTP id l2-20020a170906230200b007b9de77f0efmr1476436eja.5.1669188747005; Tue, 22 Nov 2022 23:32:27 -0800 (PST) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id g16-20020a170906539000b007b935641971sm938539ejo.5.2022.11.22.23.32.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Nov 2022 23:32:26 -0800 (PST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 23 Nov 2022 08:32:26 +0100 Message-Id: From: "Luca Weiss" To: "Christophe JAILLET" , "Andy Gross" , "Bjorn Andersson" , "Konrad Dybcio" , "Georgi Djakov" Cc: , , , Subject: Re: [PATCH] interconnect: qcom: icc-rpmh: Fix an error handling path in qcom_icc_rpmh_probe() X-Mailer: aerc 0.13.0 References: <253d4aac-62af-15af-90e7-a3cd4bacba92@wanadoo.fr> In-Reply-To: <253d4aac-62af-15af-90e7-a3cd4bacba92@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Christophe, On Tue Nov 22, 2022 at 10:45 PM CET, Christophe JAILLET wrote: > > I believe the same needs to be applied to icc-rpm.c. > > Their are other issues in the error handling path of this file. > > 1) if (desc->has_bus_pd) { > ret =3D dev_pm_domain_attach(dev, true); > is unbalanced, both in the error handling path and in the remove function= . > > > 2) clk_bulk_prepare_enable() > is not balanced in all error handling paths. > > > 3) the same issue about error handling if of_platform_populate() fails. > > > These issues have been introduced in different commits. > > > Would you prefer several patches, each related to a given Fixes: tag, or= =20 > one bigger "fix all error handling paths"? I don't really have an opinion on this, I guess if the issues were introduced in different commits, make separate fixes? If it's the wrong way somebody will tell you anyways ;) Regards Luca > > > Anyway, fixing the points above would require moving some code around.=20 > Usually I try to avoid it, because it is not always easy to see=20 > associated side effects. > > CJ