From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE3F0CA0FF8 for ; Tue, 5 Sep 2023 16:17:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239241AbjIEQHf (ORCPT ); Tue, 5 Sep 2023 12:07:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353885AbjIEIaw (ORCPT ); Tue, 5 Sep 2023 04:30:52 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A35BACCB for ; Tue, 5 Sep 2023 01:30:47 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4fe27849e6aso3469586e87.1 for ; Tue, 05 Sep 2023 01:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1693902646; x=1694507446; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LWq30L/k6esO2m+8xJQ6plHCzdQIEU3cixCgpzG9F48=; b=PXUS5OrCIr0hfIiE/RYFGI+eTfixlts42tgW5wCnRf0opXHzFIjtsXr6JyebIdn9tg FBhI3Rqqee/Gl3C0da6tAxI6dCCXEQsjsVtuSr2n/p5xZGLu0vi5//ZskgqBM4Z53AdP UBTfWJ35XhHIySddhkdM0qcNF8soWEqoGeFPw5Iak5/0zLUjsAMolwGVNsRdWCB6lpQY p9RMVuACmnr0R14z8k1RuV8DV64dwrMxOQJtwxVyMP7nPkwp7feR04nkhRtKqX8gStDl GALyse9Jh2L6M/GNvl34rZ5PAUGvFj0cIQx4fhKE/1joHr20rZDln+eGo2ZC8Slye1rm 1/iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693902646; x=1694507446; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LWq30L/k6esO2m+8xJQ6plHCzdQIEU3cixCgpzG9F48=; b=Fg/PQwBKpZQ6c62tJq7HleYYCNx6QqKwdFodgVZQ8D4d6TzA5eUvWrBKMlG9t9JtfA Y/X9z5Sv+WS5Tu64Mw0q9+lbMTGQl3YyavLXmbwmXao55a1zQGZ6DXbuoj7hw7NxNT9d oa7a9Z8Dpa/gm0n948wbMh1QVzBh2QmLsPm1XZVwcUCI/eT+InR7Nun/RokYs1bdxBNy 0GeZBUi9/BKyps8TikHb+ux4X7MHptFg9oLRC2etUUIhMjnChlTLGBPpB+CeLhihZTlS jtewaPve2nqj6U9/rGvV1LeAEYqi44hFwG+0D05MHtuT7YHhvAsyc7izuHC47MUUB/Hy iLPQ== X-Gm-Message-State: AOJu0YwI+IipwpA0/Z+JTxeWro8lDgStMh1gXmBwZXG+1nGwaHpwpvGm p90iEr4TmvPY3PA4po4rF282HQ== X-Google-Smtp-Source: AGHT+IHnW0XedN1vSaHx1JHDD4mFf80P5Zlb6gBn9z9f8KVQh7bwaME+VxnDiJKWubHNVVg3SjkedQ== X-Received: by 2002:a05:6512:ea6:b0:4fe:e50:422d with SMTP id bi38-20020a0565120ea600b004fe0e50422dmr9421046lfb.25.1693902645843; Tue, 05 Sep 2023 01:30:45 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id fj22-20020a0564022b9600b005256aaa6e7asm667460edb.78.2023.09.05.01.30.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 01:30:45 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 05 Sep 2023 10:30:44 +0200 Message-Id: To: "Dmitry Baryshkov" , "Krzysztof Kozlowski" Cc: , "Andy Gross" , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Srinivas Kandagatla" , "Linus Walleij" , "Rafael J. Wysocki" , "Viresh Kumar" , <~postmarketos/upstreaming@lists.sr.ht>, , , , , , Subject: Re: [PATCH 04/11] arm64: dts: qcom: pm7250b: make SID configurable From: "Luca Weiss" X-Mailer: aerc 0.15.2 References: <20230830-fp5-initial-v1-0-5a954519bbad@fairphone.com> <20230830-fp5-initial-v1-4-5a954519bbad@fairphone.com> <728003b9-db27-fdc0-e761-197a02a38c24@linaro.org> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu Aug 31, 2023 at 2:27 PM CEST, Dmitry Baryshkov wrote: > On Thu, 31 Aug 2023 at 14:54, Krzysztof Kozlowski > wrote: > > > > On 31/08/2023 13:33, Dmitry Baryshkov wrote: > > > On Thu, 31 Aug 2023 at 13:13, Luca Weiss w= rote: > > >> > > >> On Wed Aug 30, 2023 at 12:06 PM CEST, Krzysztof Kozlowski wrote: > > >>> On 30/08/2023 11:58, Luca Weiss wrote: > > >>>> Like other Qualcomm PMICs the PM7250B can be used on different add= resses > > >>>> on the SPMI bus. Use similar defines like the PMK8350 to make this > > >>>> possible. > > >>>> > > >>>> Signed-off-by: Luca Weiss > > >>>> --- > > >>>> arch/arm64/boot/dts/qcom/pm7250b.dtsi | 23 ++++++++++++++++------= - > > >>>> 1 file changed, 16 insertions(+), 7 deletions(-) > > >>>> > > >>>> diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/bo= ot/dts/qcom/pm7250b.dtsi > > >>>> index e8540c36bd99..3514de536baa 100644 > > >>>> --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi > > >>>> +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi > > >>>> @@ -7,6 +7,15 @@ > > >>>> #include > > >>>> #include > > >>>> > > >>>> +/* This PMIC can be configured to be at different SIDs */ > > >>>> +#ifndef PM7250B_SID > > >>>> + #define PM7250B_SID 2 > > >>>> +#endif > > >>> > > >>> Why do you send the same patch as v1, without any reference to prev= ious > > >>> discussions? > > >>> > > >>> You got here feedback already. > > >>> > > >>> https://lore.kernel.org/linux-arm-msm/f52524da-719b-790f-ad2c-0c3f3= 13d9fe9@linaro.org/ > > >> > > >> Hi Krzysztof, > > >> > > >> I did mention that original patch in the cover letter of this series= . > > >> I'm definitely aware of the discussion earlier this year there but a= lso > > >> tried to get an update lately if there's any update with no response= . > > > > > > I think the overall consensus was that my proposal is too complicated > > > for the DT files. > > > > I proposed to duplicate the entries. Do you keep QUP nodes in DTSI and > > customize per address? No. > > At the same time, we do keep SoC files separate from the board files. > Yes, I'm slightly exaggerating here. > > I think that for PMIC files it makes sense to extract common parts if > that eases reuse of the common parts. Hi all, what can I do for v2 now? 1. Keep this patch as-is, and keep pm7250b in device dts. 2. Drop pm7250b patch and drop from device dts, until _someone_ figures out a solution talking to the PMIC on different SID. 3. Something else like copy-pasting pm7250b.dtsi to pm7250-8.dtsi and changing the SID there, and using that in device dts. Please let me know what to do. Regards Luca > > > > > I definitely do not agree to these ifndef->define. Maybe using just > > define would work (so drop ifndef->define), because this makes it > > obvious and fail-safe if included in wrong place... except that it is > > still not the define we expect. This is not the coding style present in > > other DTSes. > > > > The true problem how these SPMI bindings were created. Requiring SID > > address in every child is clearly redundant and I think we do not follo= w > > such approach anywhere else. > > > > Best regards, > > Krzysztof > >