Re: [PATCH 11/11] arm64: dts: qcom: qcm6490: Add device-tree for Fairphone 5

Krzysztof Kozlowski
2023-08-30T18:36:00Z

On 30/08/2023 11:58, Luca Weiss wrote:
> Add device tree for the Fairphone 5 smartphone which is based on
> the QCM6490 SoC.
>

...

> +
> +#include <dt-bindings/arm/qcom,ids.h>
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> +#include "sc7280.dtsi"
> +#include "pm7250b.dtsi"
> +#include "pm7325.dtsi"
> +#include "pm8350c.dtsi" /* PM7350C */
> +#include "pmk8350.dtsi" /* PMK7325 */
> +
> +/ {
> + model = "Fairphone 5";
> + compatible = "fairphone,fp5", "qcom,qcm6490";
> + chassis-type = "handset";
> +
> + /* required for bootloader to select correct board */
> + qcom,msm-id = <QCOM_ID_QCM6490 0x10000>;
> + qcom,board-id = <34 0>;

Sorry, not allowed. This is not an old, legacy platform.

> +
> + aliases {
> + serial0 = &uart5;
> + serial1 = &uart7;
> + };
> +
> + chosen {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + framebuffer0: framebuffer@a000000 {
> + compatible = "simple-framebuffer";
> + reg = <0 0xe1000000 0 (2700 * 1224 * 4)>;
> + width = <1224>;
> + height = <2700>;
> + stride = <(1224 * 4)>;
> + format = "a8r8g8b8";
> + panel = <&panel>;
> + clocks = <&gcc GCC_DISP_HF_AXI_CLK>;
> + };
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> +
> + pinctrl-0 = <&volume_down_default>, <&hall_sensor_default>;
> + pinctrl-names = "default";
> +
> + key-volume-up {
> + label = "Volume up";
> + gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_VOLUMEUP>;
> + };
> +
> + /* Hall sensor uses vreg_l8c as VDD, it's being enabled using

Use Linux style comments:
/*
* foo
* bar...

> + * always-on on the regulator
> + */
> + event-hall-sensor {
> + label = "Hall Effect Sensor";
> + gpios = <&tlmm 155 GPIO_ACTIVE_LOW>;
> + linux,input-type = <EV_SW>;
> + linux,code = <SW_LID>;
> + linux,can-disable;
> + wakeup-source;
> + };
> + };
> +
> + panel: panel {
> + compatible = "boe,rm692e5";

Undocumented. You cannot add nodes with undocumented compatibles. Drop.

> +
> + width-mm = <68>;
> + height-mm = <150>;
> + };

Best regards,
Krzysztof