From: "Benno Lossin" <lossin@kernel.org>
To: "Viresh Kumar" <viresh.kumar@linaro.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Breno Leitao" <leitao@debian.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Yury Norov" <yury.norov@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Russ Weight" <russ.weight@linux.dev>,
"Nishanth Menon" <nm@ti.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>
Cc: "Vincent Guittot" <vincent.guittot@linaro.org>,
<linux-block@vger.kernel.org>, <rust-for-linux@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] rust: Use consistent "# Examples" heading style in rustdoc
Date: Tue, 10 Jun 2025 10:51:52 +0200 [thread overview]
Message-ID: <DAIQ4GUF8JGO.2EL4XVGRV06R0@kernel.org> (raw)
In-Reply-To: <70994d1b172b998aa83c9a87b81858806ddfa1bb.1749530212.git.viresh.kumar@linaro.org>
On Tue Jun 10, 2025 at 6:37 AM CEST, Viresh Kumar wrote:
> Use a consistent `# Examples` heading in rustdoc across the codebase.
>
> Some modules previously used `## Examples` or `# Example`, which deviates
> from the preferred `# Examples` style.
>
> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> rust/kernel/block/mq.rs | 2 +-
> rust/kernel/clk.rs | 6 +++---
> rust/kernel/configfs.rs | 2 +-
> rust/kernel/cpufreq.rs | 8 ++++----
> rust/kernel/cpumask.rs | 4 ++--
> rust/kernel/devres.rs | 4 ++--
> rust/kernel/firmware.rs | 4 ++--
> rust/kernel/opp.rs | 16 ++++++++--------
> rust/kernel/pci.rs | 4 ++--
> rust/kernel/platform.rs | 2 +-
> rust/kernel/sync.rs | 2 +-
> rust/kernel/workqueue.rs | 2 +-
> rust/pin-init/src/lib.rs | 2 +-
> 13 files changed, 29 insertions(+), 29 deletions(-)
> diff --git a/rust/pin-init/src/lib.rs b/rust/pin-init/src/lib.rs
> index 9ab34036e6bc..c5f395b44ec8 100644
> --- a/rust/pin-init/src/lib.rs
> +++ b/rust/pin-init/src/lib.rs
> @@ -953,7 +953,7 @@ macro_rules! try_init {
> /// Asserts that a field on a struct using `#[pin_data]` is marked with `#[pin]` ie. that it is
> /// structurally pinned.
> ///
> -/// # Example
> +/// # Examples
> ///
> /// This will succeed:
> /// ```
@Miguel, if you take this, then:
Acked-by: Benno Lossin <lossin@kernel.org>
For such a small change I don't mind upstreaming it myself, but if
Viresh wants to have a merged GitHub PR in pin-init, then we can take it
that route.
---
Cheers,
Benno
next prev parent reply other threads:[~2025-06-10 8:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 4:37 [PATCH] rust: Use consistent "# Examples" heading style in rustdoc Viresh Kumar
2025-06-10 8:34 ` Miguel Ojeda
2025-06-10 8:48 ` Viresh Kumar
2025-06-10 8:51 ` Benno Lossin [this message]
2025-06-10 9:05 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DAIQ4GUF8JGO.2EL4XVGRV06R0@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=kwilczynski@kernel.org \
--cc=leitao@debian.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mturquette@baylibre.com \
--cc=nm@ti.com \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=russ.weight@linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tmgross@umich.edu \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox