From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C2501A23A4 for ; Mon, 7 Jul 2025 13:49:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751896200; cv=none; b=Sq7AyJiRfkm2JSMlXc414VRkPaMw8JyZxOyXY4FIRBcApWUm+9jCjYcwWOd4vHE7t5YrsvxUd8Far5k6Nb76QmN3Whx8ZCg8bDSbu6mnIiRnhQJghyn32+CJxsxluQ2q4P8rQ/tB66u6bjX8SdQ3r81/3EZKFC4Kk16ztFnERJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751896200; c=relaxed/simple; bh=4luD94zEk/hzW29upK2TZa2T7UiavJ6bCdqdzulQjJM=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=hbjPhO1TXVCThX48Ak0aN0G/uva+VlUpBJnDapslDgrZZ0R4Z2xhIyA5d+G0mHkvE5jud7Q8mtgHKglo6nGZ39CFACJ8ctOYQyMuX9vnXvzqu7UuzFVpZSL/x+aLMVYISTPqSz927DrKQzlwPuORuOjQLwvp8cohiiSARs3OAo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=EFGTtkZP; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="EFGTtkZP" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-ae3b336e936so590883266b.3 for ; Mon, 07 Jul 2025 06:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1751896196; x=1752500996; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0zyQsmDxtSSwWfwFyswcoFXsE5e1vPtKLX9bKtkWsis=; b=EFGTtkZPoDGNBenLlDebPipNIHoJAV4LY59Kj4OGN+LN005+ffaPDhF6TlqwP+mq6E hXSdDcVu5BM2rSDtMuhwh/oKAbMtKWkLE/Yf851nhAgVyieNo6BkP8v83arMW6jyUgdu Rf/ROko7f5++Zsz8z/9eVJo1fNugTrt7BHf9991Fvzb+JuAcTsjREFGys784yMxeZp+t Bsp7u4I4Ewt4VpE+ACiU5YENRZ3zmRQgNccmkaYxokyMBoLRAG3o4AoBMJoof/JwQH74 d67cXli1+q6DXRUcs4ilC5hlhQKpQrrCBclSlxHQytAJbYP9FfcoRrj13orZ1RMZJpZp 1cWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751896196; x=1752500996; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0zyQsmDxtSSwWfwFyswcoFXsE5e1vPtKLX9bKtkWsis=; b=F74ET/JHGnKKPYpe707QvU8VEGQZqFCWxJbXwHWP5gwN5Pr8XQepasWejtwJpMmeF8 MTe9l5Zy/VgNyWanaGnqydHwrhxfT8PP6Ue2/jd3WYZsRP2l6Bn3Y4qHDM0mSkLg2qne U+Ho9yeYkdhVwMbyTKfBAbsfCAb2KEszqlicqvszLARlNUOIjJr/rBYuwzeniYoe8cmt HG9AvFrrGMOg8WlvcuNnOrbYMJ1nHLtzwyTA13IrwIjUUwMomzVd63oZCYeLyIqFpVJ6 OVQyRDCpeaEwD1fDZI9aWtbUovPckECKegzp5l/N1l+2qbEs1l+9g3mppqczBaNoo5NO JPDg== X-Forwarded-Encrypted: i=1; AJvYcCXxqyr6ZVf6IhWNNbnHRp7cIJ8XA+UwfWNeOFA6U8ysQ3gj9ukUhOYeF+6GBf3wq0mJr5AsbT3UBw==@vger.kernel.org X-Gm-Message-State: AOJu0YyfF2ZO8R4aRc5r9iwvcBpK8muID69dtyHA/FOGPQ1felIYn9cD rW4HaYLoBN2GU6l533SgmvfEpj9EUKgbZtxbJVGGfyqtYzlxnXSQRD20/A/R9rAyw5w= X-Gm-Gg: ASbGncsLRRMG5vRBpqy2Cz4R9V6D83rN/OWXCbyQWervrWyFaBpf8T5f3S0YPYOg6OD AshFL1YRRm5gk5WEW/u3WyeOBXRPXY/4J2DWa8V2eH0Zu8GrFQbS/Am0PK2r9Zerhk77O/G4kSG uHYYnQiN6MefHdqgU2wU2WhHtrGPmZD2ZuWTtLikryCNaSGySM92lLtksDvp16W06fVZWAGUfXh lMH7YlohTaii7SnY/VXEoL2O48TFQfuj5h/C/MEj2VygNA0Bf5xRmU7ePluxKI+rbZ3AjBmuYRv kDKPdKfCpJlulUW+hxB2h39FYWHmmj6JtZPneJ+v/piBavKpKP/5ccd9EsC4Hq/590ZAohbrlcm WZZqGK+Op1CbG3FSi34hM3f62ZhWSMEs= X-Google-Smtp-Source: AGHT+IGS6AceJdvZjybPrOvkELUyoLgdZjzLvFcMOFta4Q1dd6p+klkTcLpeNvXPfTL15dUroYXivA== X-Received: by 2002:a17:906:6a05:b0:ae0:e065:de05 with SMTP id a640c23a62f3a-ae3fe5966c4mr1393350066b.3.1751896195957; Mon, 07 Jul 2025 06:49:55 -0700 (PDT) Received: from localhost (144-178-202-139.static.ef-service.nl. [144.178.202.139]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60ff11c3e83sm4012090a12.66.2025.07.07.06.49.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Jul 2025 06:49:55 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 07 Jul 2025 15:49:55 +0200 Message-Id: Subject: Re: [PATCH v2 2/2] pmdomain: qcom: rpmhpd: Add Milos power domains From: "Luca Weiss" To: "Casey Connolly" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Bjorn Andersson" , "Ulf Hansson" Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , , X-Mailer: aerc 0.20.1-0-g2ecb8770224a-dirty References: <20250707-sm7635-rpmhpd-v2-0-b4aa37acb065@fairphone.com> <20250707-sm7635-rpmhpd-v2-2-b4aa37acb065@fairphone.com> <06760125-4800-4068-8936-dddf27c28d17@linaro.org> In-Reply-To: <06760125-4800-4068-8936-dddf27c28d17@linaro.org> Hi Casey, On Mon Jul 7, 2025 at 3:23 PM CEST, Casey Connolly wrote: > > > On 7/7/25 12:18, Luca Weiss wrote: >> Add the power domains exposed by RPMH in the Qualcomm Milos platform. > > \o/ codenames! > >>=20 >> Signed-off-by: Luca Weiss >> --- >> drivers/pmdomain/qcom/rpmhpd.c | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >>=20 >> diff --git a/drivers/pmdomain/qcom/rpmhpd.c b/drivers/pmdomain/qcom/rpmh= pd.c >> index 078323b85b5648e33dd89e08cf31bdc5ab76d553..e09552a469264f28952fc46c= 3ab8c125e87310da 100644 >> --- a/drivers/pmdomain/qcom/rpmhpd.c >> +++ b/drivers/pmdomain/qcom/rpmhpd.c >> @@ -217,6 +217,24 @@ static struct rpmhpd gmxc =3D { >> .res_name =3D "gmxc.lvl", >> }; >> =20 >> +/* Milos RPMH powerdomains */ > > I can't find any public docs telling us which SoC is Milos (the only=20 > relevant result is Bjorn's email asking you to use that name instead of= =20 > SM7635). So for the sake of future generations could you reference both= =20 > names in a comment somewhere? Or even the commit message would be enough= =20 > tbh. I don't know the full list of model numbers for Milos. I assume it's SM7635, SM6650, SM6650P, QCM6690 and QCS6690 based on the info I could fine, but such info is hard to get. So this is not a definite list that all those are actually Milos, or that this is the full list of Milos chipsets. > Off-topic here, but maybe it would be a good idea to add some Qualcomm=20 > platform docs to the kernel with a table of all the publicly known names= =20 > for each SoC? This would also be really helpful even ignoring codenames= =20 > just to know that SM8550 is Snapdragon 8 Gen 2 for example. So far my source for this has been the postmarketOS wiki, and this Google Doc, but the latter hasn't been updated for new chips since a year or so, and is also probably not very complete: https://docs.google.com/spreadsheets/d/1WrKHLj_oSoiykhSc6xqXAkT3nlD2hq-fzUP= SGiq3Kbc/edit?gid=3D1270863184#gid=3D1270863184 And I've got some notes locally for a couple that I regularly need. But I'd love a more central place that isn't specific to postmarketOS for example. Not sure where though? Regards Luca > > Kind regards, > Casey (she/they) > >> +static struct rpmhpd *milos_rpmhpds[] =3D { >> + [RPMHPD_CX] =3D &cx, >> + [RPMHPD_CX_AO] =3D &cx_ao, >> + [RPMHPD_EBI] =3D &ebi, >> + [RPMHPD_GFX] =3D &gfx, >> + [RPMHPD_LCX] =3D &lcx, >> + [RPMHPD_LMX] =3D &lmx, >> + [RPMHPD_MSS] =3D &mss, >> + [RPMHPD_MX] =3D &mx, >> + [RPMHPD_MX_AO] =3D &mx_ao, >> +}; >> + >> +static const struct rpmhpd_desc milos_desc =3D { >> + .rpmhpds =3D milos_rpmhpds, >> + .num_pds =3D ARRAY_SIZE(milos_rpmhpds), >> +}; >> + >> /* SA8540P RPMH powerdomains */ >> static struct rpmhpd *sa8540p_rpmhpds[] =3D { >> [SC8280XP_CX] =3D &cx, >> @@ -723,6 +741,7 @@ static const struct rpmhpd_desc qcs615_desc =3D { >> }; >> =20 >> static const struct of_device_id rpmhpd_match_table[] =3D { >> + { .compatible =3D "qcom,milos-rpmhpd", .data =3D &milos_desc }, >> { .compatible =3D "qcom,qcs615-rpmhpd", .data =3D &qcs615_desc }, >> { .compatible =3D "qcom,qcs8300-rpmhpd", .data =3D &qcs8300_desc }, >> { .compatible =3D "qcom,qdu1000-rpmhpd", .data =3D &qdu1000_desc }, >>=20