From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from LO3P265CU004.outbound.protection.outlook.com (mail-uksouthazon11020141.outbound.protection.outlook.com [52.101.196.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F146F37F8A6; Mon, 19 Jan 2026 14:33:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.196.141 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768833223; cv=fail; b=ixKN6pBNGJ6aLP9UnucLjtkNS8XdunLw1k4tbAilt/7++7hzdxyLJkGai29Fvu7IPqm3EVZpQDmAB3TsG3p+eZQTHMWZiHaOI5nQXxRZtGG7LwvTT13LR7VqPVO1cz0fFbaWp5KSEI/t4WZ4fLlz0/qSbh4SUPTAL/8GvuimWMA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768833223; c=relaxed/simple; bh=w9Vr8d9PsthiWnuvOi2khDINxlrbmR0uv1BIVgVJ1Tk=; h=Content-Type:Date:Message-Id:Subject:From:To:Cc:References: In-Reply-To:MIME-Version; b=k6AWaa8jkQWdbyaTP9ArRdcbV3gA47zSc0eWsgjMdxE6IOjN91vkz2OambPtGWOad/otCb5lGlAMXSwZJEgZv93rseZifpNmNsRAoxS+gvUmroaKdh+zKtSJ/W/vLuCSC+kv/6Euu/7X/ZNsSs2ONEVaeWCOnWIdRTSYh970AuE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=garyguo.net; spf=pass smtp.mailfrom=garyguo.net; dkim=pass (1024-bit key) header.d=garyguo.net header.i=@garyguo.net header.b=W36J7M6/; arc=fail smtp.client-ip=52.101.196.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=garyguo.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=garyguo.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=garyguo.net header.i=@garyguo.net header.b="W36J7M6/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nAJQYUfO+yo1UZnID3gF0zmQo2xhzVc255MEBb66aXUx5KtDRRhUP/fSzPiBs0eqCQyO/Iq+50Cli9otL6sm+x4wvM/EflFWsaHrxcy9dGlWQ5y8W7DsFOAnOttLRDOV/Xp2UkJNXildt9hgqnonUT8ZhR7pDTmjaMpvg1ZGK3VdT1Cd3UngrDN9StO8tR1dQjzU7sHvu6ucmcAMQn0bfFgblHY8PPCeJbMdDK1dAMfoDovAV46zxdE6szNyx2ybl/6c9ZhUQY9hIfT6HUGOdgu/t0l1BlgyRQBJP8i4PbxmmEWUN1/FTOrdfDGwvjabplcav75A24WCm+GD1Q2svg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WTnE/OMQCcf5TZmK2xsispFblgHqg4Meo+lA6ue4gxk=; b=PnDckmNjYvZLhdNBNa2bBpxUI45Lrl5vv2/tc1VLv1znNaTc2kZ6Ku2PmplHqTvKyLdD9S4REWBVzFM4ieacwYiHWQD2cS9Y/l8L7RwPC86qKTj9R2JDOVSDsBRFLSOGcttpyS6iBoxB9LDnH1OoyEEPfyRFdiTY9W4b6GyQMc5brfAc83jY+O8EestJ+Qo0O/cItyQcRm+KJIoQEr9niEawcbz24ttC3Mlx2p9heZyTu1aSGJfokt3i4PmzFzCKrGa4X3Dm/IQ29twTKGdKgVtNnlgTAnyBZHjmhV73io11KbqY3NriFhFULtdOcR7pcCMI4M1We40D8xRKndHZ6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=garyguo.net; dmarc=pass action=none header.from=garyguo.net; dkim=pass header.d=garyguo.net; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=garyguo.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WTnE/OMQCcf5TZmK2xsispFblgHqg4Meo+lA6ue4gxk=; b=W36J7M6/be+6I2bUHeiUqruK2jh32zneNSkSZZwUGbRRCmtP39taIKi7DJw6N43sfVQfYML1bSUgw/IbX/731oomX1NvmxVopMy+zWBLwrmhIDyf3Gq/CzoErsfHvAyeS4jV34CfPfK5VFUBtvBB7QX+WyzXOKsR0qiv3hHaZKQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=garyguo.net; Received: from LOVP265MB8871.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:488::16) by LO7P265MB8702.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:4a9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.12; Mon, 19 Jan 2026 14:33:38 +0000 Received: from LOVP265MB8871.GBRP265.PROD.OUTLOOK.COM ([fe80::1c3:ceba:21b4:9986]) by LOVP265MB8871.GBRP265.PROD.OUTLOOK.COM ([fe80::1c3:ceba:21b4:9986%5]) with mapi id 15.20.9520.011; Mon, 19 Jan 2026 14:33:38 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 19 Jan 2026 14:33:37 +0000 Message-Id: Subject: Re: [PATCH v3 2/3] rust: clk: add devres-managed clks From: "Gary Guo" To: "Daniel Almeida" , "Rafael J. Wysocki" , "Viresh Kumar" , "Danilo Krummrich" , "Alice Ryhl" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Drew Fustini" , "Guo Ren" , "Fu Wei" , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , "Michael Turquette" , "Stephen Boyd" , "Miguel Ojeda" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Trevor Gross" Cc: , , , , , , X-Mailer: aerc 0.21.0 References: <20260107-clk-type-state-v3-0-77d3e3ee59c2@collabora.com> <20260107-clk-type-state-v3-2-77d3e3ee59c2@collabora.com> In-Reply-To: <20260107-clk-type-state-v3-2-77d3e3ee59c2@collabora.com> X-ClientProxiedBy: LO4P302CA0024.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c1::10) To LOVP265MB8871.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:488::16) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LOVP265MB8871:EE_|LO7P265MB8702:EE_ X-MS-Office365-Filtering-Correlation-Id: dd1920ab-cbef-4fc0-88c4-08de5767bc24 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|10070799003|366016|921020|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UmtSUnkzcS9zYkt4TUtERFBkYmVtaUNuM1FWemRZK1B3SFkzcjJYdVpjVndS?= =?utf-8?B?blFXMjZQMzRTb3ZPb3NKd1lNM0Z6ZElQTC9tT01TaEN0S3BZeXVHSmJZSndo?= =?utf-8?B?eWNRV1JlWDlkUUtPVWRWMFVNTGVjVjRLZUtURWk3eElrWWtvNVRhTmQwN0t3?= =?utf-8?B?TTJ6UXBIVllhay9rOS9RY2kxSWVBMUdCZkRGVzFhZEpWWUg2VGZOSVNJWEVl?= =?utf-8?B?ZDVVZFRBUnVmMXRZNUhFbTJXL2Ewc0o4dTlvV0JxNVZSZ1p1TFRPZ043YnFQ?= =?utf-8?B?NEJIM1ZVZVE4MkR1WWNFUmRCMlNZNzlhR2g2cVdDcDM1UWZmQ1RudVZwZW95?= =?utf-8?B?M0UrUDBZcnBGbkROV2pablAxbEVVckRyaktsVDFkQmhaQ2V2VnN4aWRBZWRC?= =?utf-8?B?K01nUENLbjd0TGNLVDZmUW45NnlHaFpLVjFHdExxTWFST290cjB6Yk9JMGov?= =?utf-8?B?czh3ekpKZXoyQzMvbVZEZlpQNUUxTnBzZC9HMmxQbjdvSkNVMyttUjkxK3BB?= =?utf-8?B?bjA4SmJDMGRGQWJrYzZpUEMzTTIvSmJYN1FsbDA2NVBaaWtrQzRDWHRxK0tu?= =?utf-8?B?eXhIOGlBLzdXa3RaQzBSTFdRNFNQZmxPTXZVeWdmakxoaC8xbEl5cDZZL2Nj?= =?utf-8?B?Mndyb2lWV0N1SWJoWnRjODRybFBZanRnNFBFRkNMZ1VVdEtxMEZPSmY5bUZh?= =?utf-8?B?V3YrdzRYbkNpdU9KK21aemZZVDdQZFlCeFphaHBzNXJDN0lZOUV6UGNxMlk2?= =?utf-8?B?d0NPaCtPaE4vQkxsdndyYnJQUHBsMUg4UjhKYU9nZXNDcktoS29NYTU0dGRT?= =?utf-8?B?NDAvQWRlRkp2dGVnKzBvVE9pd3BOM1B1Q3JnNTg3YlEvcGZPV1E3N3dFZWM3?= =?utf-8?B?NVM2M2t6eWE5OVBONUtVYk1ybktkOGRzY2Mxem1GNGdINFp1bmZTQkc3c2RU?= =?utf-8?B?ZlRCUFQxZlRTTGlrWm5NRlJCUEZoTVBiQ0RkNy80ZkhZTkdoMnJVWTRTWENN?= =?utf-8?B?eUhlZURkU0tHdndlbkFBY0M0bWhVQzZ3OS8vaElPcnhMdC90NlE1a3dMaXRT?= =?utf-8?B?bjgvdncraWhKQU1jOHBsS1BtanFWRlRGbHcvZGtjSTQ3WUtJL1RveFNGejJY?= =?utf-8?B?QU9oMnBsYTBxTVF3ZzJKUkpTWEhiSSthdlNTczNlVHFabUZpelY1VE5nV3ZF?= =?utf-8?B?ZERLQjBFRXVEMDhnc3pwL2Q0MUtvenphbU45dTdGaXBydTRQeFMvaG1FUGhF?= =?utf-8?B?cS9FbGgxaFFlNXU4eng0dFBSd09GV0hyUk13NmNUcE5LbWJ4QjVhRWVTS0R5?= =?utf-8?B?cDl2MjhVVUJqV0RZMjk0aU9oU042Z3grTEc4MXBZdVV4Z01OQkRxKzN5eGNG?= =?utf-8?B?VXNDRWJDeGVFM1JaYkRadzk2aWNjRVEwVG5FclpUZExGV3dkYWtCczBwRlNP?= =?utf-8?B?eGFoOXh4MHJoMk1aZWtnd2kyMUtJYXMvNTErMUlsMEZENkplbzdxMmdkV2RQ?= =?utf-8?B?dkdMU21oWmtrZFZ6UkF5ekpxSW5Ya2VEVHFpRS9pbUdMbFRMREZ5REpHUFB5?= =?utf-8?B?dW5oQ1U3c2xCNmxSWUVXVWNoS1NqemR3MDJIRUYxYmszUEVIZ2JuMWRPOHk0?= =?utf-8?B?UkdjZTFRQW1ncEhyTExjQ092TTBjY3d6NU9CcEhZeUNUNFE3bEZjN2t3R1RW?= =?utf-8?B?ejAvZ04yV1l2OUxFc3pSVUlmUytlalhhRTdPamc4S1hiSkxLeThlc1ByN2ky?= =?utf-8?B?R3N4bTF5ME5KWXRjSDVHQWRzRmxvVGljL05JOURobUtxc1BDMFN4NUdWaXVu?= =?utf-8?B?aWtFdTZEek5nY2hNZUlvZjRSUENiK0dsdmxReVAzSlFpME9iS09BLzM5a25M?= =?utf-8?B?dFY4UWlrRUloT0NvTHg1eWY1SXIwR0Z6MEJpdlJTZjJ1ZWl2K3BGNG1YbDNi?= =?utf-8?B?T1BadVhqeFFheDdzRUVQT3FObDR5L2QzUmlwKzJ3USs1L016OVBTYVZsWlJN?= =?utf-8?B?cERrZUlCajRIc1lXTnIrbWJQMmtmKzFEYVlQSGs4cnQ4emw4TTNVYUgwaFFJ?= =?utf-8?B?eFRrR2gwUUxUVGNPWE5leHdUbkNFTUZIdmhBTGQ4U1I1Y2hweDQ5b21ETkxm?= =?utf-8?B?aU1WRWhFc3FxSUQ5cHFUamUzU1pUNElRa0ZnUU1aV0pXRE0wN0syclEvcmhV?= =?utf-8?B?UXc9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LOVP265MB8871.GBRP265.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(10070799003)(366016)(921020)(7053199007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEVNUUJNelVnNnlJbnR1OWJyUjJBMnZ6YTc2ckVNZVkwK09vYnZMZUJFNldj?= =?utf-8?B?K29ZWUxaM2tKejlCV05VcEk0L0FsRHhsTTFpcDVQTUdPUUY2Tm8raHhEcU54?= =?utf-8?B?bDlGUWZUTjk3c1pTYmoyS1ZpS0JWbEFmTmlES2pTNCtRU1dEVmtWbWR2b3dn?= =?utf-8?B?SkVDbFdhQlZ6eW9xTG9VelhkMHcvUDJlUitqdnJraEUxSWpoUkRXUXpYSWxC?= =?utf-8?B?eWM5RDl6NDkvNHRDbmhPajFXWDVieDFaajhHUEIxZ2RoemtHOTcxWktzVzJm?= =?utf-8?B?ZmJhTWxQalMrSVlvajBYQzRNbzJFcUVnYi9nWVZkWGtKYzNUT2UvbmJHTVZC?= =?utf-8?B?bVFUS0RjOGJ1RUNGa1I4N1ZSTWNzazByNk1qQTVrY1I4UVFCWDNYb1JIblVL?= =?utf-8?B?TEN4eUtWTXF4YW5kVmVGTWl0QzlNbE51SFViOWV5MFhDNko3UFZ4MTJZU29u?= =?utf-8?B?bHhZUHZEQ3I1N2lGYUNzMHNLRk1rdjFJMFBaTFZZdTNvYnRhWWtWYlBPdWtq?= =?utf-8?B?a0l1YmtISEczMjlLaGhjbFJmVStTMUNnN1l3c2hsdWVtNVhYWlVkMTRPU3Nz?= =?utf-8?B?RkdYVjFmSExqRUpnVWxxNXVobFRmNUJyajFmVmZFSnRDeUN4SEkxZ3FHbUNv?= =?utf-8?B?aTNTMFlBY2ZlQ0dRUXcramF4bDEwZll2MDFzSGJnR2oxb05RL0xYYzFzWno1?= =?utf-8?B?Uk9tT2NkU2pBRDRRNVNTVXU5bVgvYVZWN3AzaWE2L3J4eERHbGF5dlFaWnds?= =?utf-8?B?djNMbFI3WHhMSGNTb21GRVMzc2UvcTU4OWdOLzdhNkt4Qk9ObkVvN0FJOFpo?= =?utf-8?B?WjhWUU9TQjFrWjdicEVmZVZhd1ZFVDd1ZGJLMm95T0IvR2ZsY1JYMDN2dTM0?= =?utf-8?B?WFR4d1BMcDh5SElmL3BZU3dOUmQvU2oyZlhkd2JUOVd4OHpMcE9maFN5SVNr?= =?utf-8?B?MjM3UjNNNElvTndjU1FMN0FpUUx0aGxxSnRxNENRYThZRHgzREpaMitIa2R2?= =?utf-8?B?NUtYWmRKRStXN0owakhKZnhpSkJDRHlsSHRycFp2dHBBQzEyUHd6WEoyTWo5?= =?utf-8?B?VWpkRnE4QkpEdEpuTkkwZGpCQkt2U3NNU3R3cWE3b2F1dXVVNkV6NkNZVEIy?= =?utf-8?B?Q2ZHbVFmdU9MTjI2a2prbEtxc0FxNWZ6azVTL0RhNkNnY1U5TzRWME1RZ1lk?= =?utf-8?B?U1NwaXd4VEhFYzdDaEUranpCS3NMWmhnb2FsTENiMXpkWTRtb0JzSEtEamdG?= =?utf-8?B?RE5jUE94UWVHckFXTFIxWlUyWGlCYzQ4Qi9sR0h6d2dUZkRKV1ZKV2Rmb1pG?= =?utf-8?B?VWJnQUJDZUFmeWZwTFNtcCtFdFVtR3NxSFhOdFhkTVFBRGRDU2lvdWYrWTNv?= =?utf-8?B?Zm9GaUhPbVROWUhkY0Zaa3Z4L0FiQkpRSG9xUjdkUkY0TTZXOFo2TmpkaDQx?= =?utf-8?B?UnFndmFJU3JtMU5HYnNOSnBiTTFJTE5vWnBaVlBBSE9nS3liNUJ4TlVXMDBS?= =?utf-8?B?VVdLSlllUTVyeTJqMHRTZVRnVkFpMnNRR3RVLyt4b1FXTmNHZWtIL2pmLyta?= =?utf-8?B?dk5IVVREZ2YwbU1XWXQwQTFnK01hczZaYUsveVBNRW9jRnk5SFZvZmh5bEhQ?= =?utf-8?B?cFdCcWo1b2pMZWNDSlFHYjJyOGRDdlNBQWVYTHk0dlVmN0cybEVyWFB0SEVz?= =?utf-8?B?aitLY3prWFBsMHQvM0JQY1c1OVNSZGdQMm5QYTN3SzdBQnYxR3gzcWlnUnNp?= =?utf-8?B?bHhqaXJaZnBlcm5hekVDQ1V0cW1tV1daUEhlL2pzQ3dRVGF2RU5MOWRMMTBT?= =?utf-8?B?VXd3SWtFcmh5MVFNaGRMMGhvM0wveFBDL1FuTGhzbjJ5ZnErY0N6QlBBVVVw?= =?utf-8?B?c3NHOVFub0JQZFNCUEtURVg2TnFGUFpLNU43WkFQaHArT2lwcC9hcHd3R0N3?= =?utf-8?B?RmRsbXFlQVBxa25USU92bkI5TWd6WlUxdk5jVVkrL0I5Rk5EM21yR2JvU05X?= =?utf-8?B?TUErVDFBbVVvbUx6MTZKSTNvMy9HY3ZGdHQvZEtDSWRLZHJ6Ukg1aVlwWWtH?= =?utf-8?B?eXFERUU2UjNNcVQ4TVUxcXFZS29aQTNZTEJQZUhnQUIrbmN6TUhZTlI3UTB1?= =?utf-8?B?NGhSemZkSHBwWGtRc2dMblZEc1JlRURUQUpuUEhXZlEzRE84WDZXN2pFeUl4?= =?utf-8?B?R3dFY2hZOU9WWjBvaWJlMHhYNHFsUkNHV3MxR1dPN0o3RW9EdXhVOHhlTUFM?= =?utf-8?B?OVJ5WnpFS2d1VFV5ak9iMitDNXhqcFBad3g1cUs3aUJNditXK3c1bE42eDhi?= =?utf-8?B?L1VjeGpwS2xWV2huOHU0bXg5QmE4eWxkbHpzQXRGdUFpN0ZTeDdpUT09?= X-OriginatorOrg: garyguo.net X-MS-Exchange-CrossTenant-Network-Message-Id: dd1920ab-cbef-4fc0-88c4-08de5767bc24 X-MS-Exchange-CrossTenant-AuthSource: LOVP265MB8871.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2026 14:33:38.3692 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eRuxPCtRLzmYArR322SSSvd8GS8gdTi481jXHeE4w/umyUT3R4UYxBJzvbToIwOxDT5Z7ObqOmMJ117adBWLgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO7P265MB8702 On Wed Jan 7, 2026 at 3:09 PM GMT, Daniel Almeida wrote: > The clk API allows fine-grained control, but some drivers might be > more interested in a "set and forget" API. > > Expand the current API to support this. The clock will automatically be > disabled, unprepared and freed when the device is unbound from the bus > without further intervention by the driver. > > Signed-off-by: Daniel Almeida > --- > rust/kernel/clk.rs | 43 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/rust/kernel/clk.rs b/rust/kernel/clk.rs > index 6323b40dc7ba..e840e7c20af7 100644 > --- a/rust/kernel/clk.rs > +++ b/rust/kernel/clk.rs > @@ -95,6 +95,49 @@ impl Sealed for super::Prepared {} > impl Sealed for super::Enabled {} > } > =20 > + /// Obtains and enables a [`devres`]-managed [`Clk`] for a bound dev= ice. > + /// > + /// [`devres`]: crate::devres::Devres > + pub fn devm_enable(dev: &Device, name: Option<&CStr>) -> Resu= lt { > + let name =3D name.map_or(ptr::null(), |n| n.as_char_ptr()); > + > + // SAFETY: It is safe to call [`devm_clk_get_enabled`] with a va= lid > + // device pointer. > + from_err_ptr(unsafe { bindings::devm_clk_get_enabled(dev.as_raw(= ), name) })?; > + Ok(()) > + } Would it make sense to have them as assoc functions instead of standalone? Regardless, the code looks correct to me. Reviewed-by: Gary Guo Best, Gary > + > + /// Obtains and enables a [`devres`]-managed [`Clk`] for a bound dev= ice. > + /// > + /// This does not print any error messages if the clock is not found= . > + /// > + /// [`devres`]: crate::devres::Devres > + pub fn devm_enable_optional(dev: &Device, name: Option<&CStr>= ) -> Result { > + let name =3D name.map_or(ptr::null(), |n| n.as_char_ptr()); > + > + // SAFETY: It is safe to call [`devm_clk_get_optional_enabled`] = with a > + // valid device pointer. > + from_err_ptr(unsafe { bindings::devm_clk_get_optional_enabled(de= v.as_raw(), name) })?; > + Ok(()) > + } > + > + /// Same as [`devm_enable_optional`], but also sets the rate. > + pub fn devm_enable_optional_with_rate( > + dev: &Device, > + name: Option<&CStr>, > + rate: Hertz, > + ) -> Result { > + let name =3D name.map_or(ptr::null(), |n| n.as_char_ptr()); > + > + // SAFETY: It is safe to call > + // [`devm_clk_get_optional_enabled_with_rate`] with a valid devi= ce > + // pointer. > + from_err_ptr(unsafe { > + bindings::devm_clk_get_optional_enabled_with_rate(dev.as_raw= (), name, rate.as_hz()) > + })?; > + Ok(()) > + } > + > /// A trait representing the different states that a [`Clk`] can be = in. > pub trait ClkState: private::Sealed { > /// Whether the clock should be disabled when dropped.