[PATCH] pmdomain: rockchip: quiet regulator error on -EPROBE_DEFER

[PATCH] pmdomain: rockchip: quiet regulator error on -EPROBE_DEFER

[Chris Morgan]

From: Chris Morgan <macromorgan@hotmail.com>

Change the dev_err() to dev_err_probe() under rockchip_pd_power_on()
to prevent errors early in the boot process when the requested
regulator is not yet available. This converts errors like the following
to debug messages:

rockchip-pm-domain fd8d8000.power-management:power-controller: Failed to enable supply: -517

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 drivers/pmdomain/rockchip/pm-domains.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c
index 1955c6d453e4..3c84a65de1a5 100644
--- a/drivers/pmdomain/rockchip/pm-domains.c
+++ b/drivers/pmdomain/rockchip/pm-domains.c
@@ -688,7 +688,8 @@ static int rockchip_pd_power_on(struct generic_pm_domain *domain)
 
 	ret = rockchip_pd_regulator_enable(pd);
 	if (ret) {
-		dev_err(pd->pmu->dev, "Failed to enable supply: %d\n", ret);
+		dev_err_probe(pd->pmu->dev, ret,
+			      "Failed to enable supply: %d\n", ret);
 		return ret;
 	}
 
-- 
2.43.0

Re: [PATCH] pmdomain: rockchip: quiet regulator error on -EPROBE_DEFER

[Shawn Lin]

在 2025/11/20 星期四 0:12, Chris Morgan 写道:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Change the dev_err() to dev_err_probe() under rockchip_pd_power_on()
> to prevent errors early in the boot process when the requested
> regulator is not yet available. This converts errors like the following
> to debug messages:
> 
> rockchip-pm-domain fd8d8000.power-management:power-controller: Failed to enable supply: -517
> 
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>   drivers/pmdomain/rockchip/pm-domains.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c
> index 1955c6d453e4..3c84a65de1a5 100644
> --- a/drivers/pmdomain/rockchip/pm-domains.c
> +++ b/drivers/pmdomain/rockchip/pm-domains.c
> @@ -688,7 +688,8 @@ static int rockchip_pd_power_on(struct generic_pm_domain *domain)
>   
>   	ret = rockchip_pd_regulator_enable(pd);
>   	if (ret) {
> -		dev_err(pd->pmu->dev, "Failed to enable supply: %d\n", ret);
> +		dev_err_probe(pd->pmu->dev, ret,
> +			      "Failed to enable supply: %d\n", ret);
>   		return ret;

return dev_err_probe(pd->pmu->dev, ret, "Failed to enable supply: %d\n", 
ret); ?

>   	}
>   

Re: [PATCH] pmdomain: rockchip: quiet regulator error on -EPROBE_DEFER

[Diederik de Haas]

On Wed Nov 19, 2025 at 5:12 PM CET, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Change the dev_err() to dev_err_probe() under rockchip_pd_power_on()
> to prevent errors early in the boot process when the requested
> regulator is not yet available. This converts errors like the following
> to debug messages:
>
> rockchip-pm-domain fd8d8000.power-management:power-controller: Failed to enable supply: -517

I noticed I had a LOT (33 to be exact) of these errors on my Rock 5B.
After building a kernel with just this patch added, those were all gone.
So feel free to add:

Tested-by: Diederik de Haas <diederik@cknow-tech.com>  # Rock 5B

I don't know if it's a logical consequence or just luck, but I'm no
longer getting the following error either:

  rockchip-pm-domain fd8d8000.power-management:power-controller: 
    Failed to create device link (0x180) with supplier spi2.0 for
    /power-management@fd8d8000/power-controller/power-domain@12

I'm still getting the following error though:

  rockchip-pm-domain fd8d8000.power-management:power-controller:
    Failed to create device link (0x180) with supplier 1-0042 for
    /power-management@fd8d8000/power-controller/power-domain@8

Those error msgs are broken up for readability, but they are on one line
in dmesg.

Thanks!
  Diederik

> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  drivers/pmdomain/rockchip/pm-domains.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c
> index 1955c6d453e4..3c84a65de1a5 100644
> --- a/drivers/pmdomain/rockchip/pm-domains.c
> +++ b/drivers/pmdomain/rockchip/pm-domains.c
> @@ -688,7 +688,8 @@ static int rockchip_pd_power_on(struct generic_pm_domain *domain)
>  
>  	ret = rockchip_pd_regulator_enable(pd);
>  	if (ret) {
> -		dev_err(pd->pmu->dev, "Failed to enable supply: %d\n", ret);
> +		dev_err_probe(pd->pmu->dev, ret,
> +			      "Failed to enable supply: %d\n", ret);
>  		return ret;
>  	}
>