From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [121.127.44.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DE372253EB for ; Thu, 30 Apr 2026 19:54:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=121.127.44.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777578895; cv=none; b=uYuKoIKXOH95mwwuqv5vMFWj6epEBRL0a4FG/xYp9opXSVDo9i64nLBUWHOKmT6gSsbAolj2M54rS1/A5OKRZMmTrU2qpFkDLS+JwS0cZiCWtoK6nakt0cAOg12ILx+N0H/Ba2XARvN3kIjTzDET1/h2sY7iVCyv1XZUB5oN1e0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777578895; c=relaxed/simple; bh=mTShDs3qFh8Xph4TeQW7wpoAVzLqWhiZ9mAFw583TTI=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=p/Sv7H3pHwwWFP5bA+hn1MoPysaOxahG8HA2PYbo6DOp+bgcVLhtcgV5pg+vGM2hIONczgGp98jHCwqZHPVpVvP6VpXam2/75f/dgC8gfeBE7V2+Nx9zUpEGOywPNRgqQ9yCAmxFJz0O9i4MReWe8mAXV5c1wC1RUvUMOHkV4KY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ubuntu.com; spf=pass smtp.mailfrom=fe-bounces.ubuntu.com; dkim=pass (2048-bit key) header.d=ubuntu.com header.i=@ubuntu.com header.b=ClwAgaiR; arc=none smtp.client-ip=121.127.44.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ubuntu.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.ubuntu.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ubuntu.com header.i=@ubuntu.com header.b="ClwAgaiR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ubuntu.com; h=In-Reply-To: References: Cc: To: From: Subject: Message-Id: Date: Content-Type: Content-Transfer-Encoding: Mime-Version; q=dns/txt; s=fe-953a8a3ca9; t=1777578885; bh=EbR5+jcTj2Ecv9c7ESRhGNAPx8DtjjuvHNmmdJxNTMU=; b=ClwAgaiRgFlQjbJTcWkNzoxWejpKVu9UYHC9pEGJQIQhOuvNmEjVe14JvtO+5jIsWpcUZ4Yi7 dKdoDiQJbLtTv4MHB1jCsZRbZZsfHpndoVyIGWhmEnmYOdwarMB+ZpT3lEVfniVNTCD62ifFXZk IjiGVsKeSr5dLtxaUFpVowSlmQVqOVqqPkWr2tG9+z/MUp19Dql0J8oUnb9IsQw14XlgjVzSUKE ZH1v1cqjbTGInsoeMAS+A35TigW/R/sLjuNp12/zNs4Ny1GhFVe6MRI4FS3ozxpgUmI6t0TD0bA IhNHDxkADiG+WNYfLqfVO5aGk9UUw9fK/ugHCI3qkPBA== X-Forward-Email-ID: 69f3b382d1381ba2713053ad X-Forward-Email-Sender: rfc822; jpeisach@ubuntu.com, smtp.forwardemail.net, 121.127.44.66 X-Forward-Email-Version: 2.7.7 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed Date: Thu, 30 Apr 2026 15:54:39 -0400 Message-Id: Subject: Re: [PATCH 2/2] cpufreq: apple-soc: Use FIELD_MODIFY() From: "Joshua Peisach" To: "Hans Zhang" <18255117159@163.com>, , , , , , Cc: , , , , , X-Mailer: aerc 0.21.0 References: <20260430163213.44695-1-18255117159@163.com> <20260430163213.44695-3-18255117159@163.com> In-Reply-To: <20260430163213.44695-3-18255117159@163.com> On Thu Apr 30, 2026 at 12:32 PM EDT, Hans Zhang wrote: > Use FIELD_MODIFY() to remove open-coded bit manipulation. > No functional change intended. > > Signed-off-by: Hans Zhang <18255117159@163.com> > --- > drivers/cpufreq/apple-soc-cpufreq.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/cpufreq/apple-soc-cpufreq.c b/drivers/cpufreq/apple-= soc-cpufreq.c > index 9396034167e5..638e5bf72185 100644 > --- a/drivers/cpufreq/apple-soc-cpufreq.c > +++ b/drivers/cpufreq/apple-soc-cpufreq.c > @@ -187,10 +187,8 @@ static int apple_soc_cpufreq_set_target(struct cpufr= eq_policy *policy, > =20 > reg &=3D ~priv->info->ps1_mask; > reg |=3D pstate << priv->info->ps1_shift; > - if (priv->info->has_ps2) { > - reg &=3D ~APPLE_DVFS_CMD_PS2; > - reg |=3D FIELD_PREP(APPLE_DVFS_CMD_PS2, pstate); > - } > + if (priv->info->has_ps2) > + FIELD_MODIFY(APPLE_DVFS_CMD_PS2, ®, pstate); > reg |=3D APPLE_DVFS_CMD_SET; > =20 > writeq_relaxed(reg, priv->reg_base + APPLE_DVFS_CMD); Looks okay. Reviewed-by: Joshua Peisach