Linux Power Management development
 help / color / mirror / Atom feed
From: "Gary Guo" <gary@garyguo.net>
To: "Danilo Krummrich" <dakr@kernel.org>,
	"Eliot Courtney" <ecourtney@nvidia.com>
Cc: <gregkh@linuxfoundation.org>, <rafael@kernel.org>,
	<acourbot@nvidia.com>, <aliceryhl@google.com>,
	<david.m.ertman@intel.com>, <ira.weiny@intel.com>,
	<leon@kernel.org>, <viresh.kumar@linaro.org>,
	<m.wilczynski@samsung.com>, <ukleinek@kernel.org>,
	<bhelgaas@google.com>, <kwilczynski@kernel.org>,
	<abdiel.janulgue@gmail.com>, <robin.murphy@arm.com>,
	<markus.probst@posteo.de>, <ojeda@kernel.org>, <boqun@kernel.org>,
	<gary@garyguo.net>, <bjorn3_gh@protonmail.com>,
	<lossin@kernel.org>, <a.hindborg@kernel.org>, <tmgross@umich.edu>,
	<igor.korotin@linux.dev>, <daniel.almeida@collabora.com>,
	<pcolberg@redhat.com>, <driver-core@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>, <nova-gpu@lists.linux.dev>,
	<dri-devel@lists.freedesktop.org>, <linux-pm@vger.kernel.org>,
	<linux-pwm@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v3 17/27] rust: auxiliary: generalize Registration over ForLt
Date: Tue, 19 May 2026 12:20:15 +0100	[thread overview]
Message-ID: <DIMM2XJHLR16.1K52AYHT02CM@garyguo.net> (raw)
In-Reply-To: <DIML7JNOV84D.1CK4G9MBZQJ3T@kernel.org>

On Tue May 19, 2026 at 11:39 AM BST, Danilo Krummrich wrote:
> On Tue May 19, 2026 at 9:56 AM CEST, Eliot Courtney wrote:
>> For example, in the next patch on the sample aux driver you can do:
>>
>> ```
>> let data = adev.registration_data::<ForLt!(for<'a> Data<'static>)>()?;
>> let pdev: &'static pci::Device<Bound> = data.parent;
>> ```
>>
>> and mint a 'static reference to a bound device, which seems unsound to
>> me.
>
> Good catch, I applied the fix.
>
> Additionally, we could probably reject unused lifetime binders in the ForLt!()
> macro, which doesn't help when used with a type alias, but may be a good
> defensive measure anyway.

That won't work, `ForLt!(T)` is basically not using the lifetime binder, and you
do need that to work.

Best,
Gary

>
>> What about requiring all device ids declared to be supported by an aux
>> bus driver to have the same rust registration data type?
>
> Please see [1] and [2].
>
> Thanks,
> Danilo
>
> [1] https://lore.kernel.org/driver-core/DIFBME3GXDC0.14UHJTPD6TTAE@kernel.org/
> [2] https://lore.kernel.org/driver-core/DIFXM2N21Q5J.2RIYLU11C5FR6@kernel.org/


  reply	other threads:[~2026-05-19 11:20 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-17  0:00 [PATCH v3 00/27] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-05-17  0:00 ` [PATCH v3 01/27] rust: alloc: remove `'static` bound on `ForeignOwnable` Danilo Krummrich
2026-05-18 14:42   ` Alexandre Courbot
2026-05-17  0:00 ` [PATCH v3 02/27] rust: driver: move 'static bounds to constructor Danilo Krummrich
2026-05-18 14:42   ` Alexandre Courbot
2026-05-17  0:00 ` [PATCH v3 03/27] rust: driver: decouple driver private data from driver type Danilo Krummrich
2026-05-17 14:32   ` Danilo Krummrich
2026-05-18 14:43   ` Alexandre Courbot
2026-05-17  0:00 ` [PATCH v3 04/27] rust: driver core: drop drvdata before devres release Danilo Krummrich
2026-05-18 14:45   ` Alexandre Courbot
2026-05-17  0:00 ` [PATCH v3 05/27] rust: pci: implement Sync for Device<Bound> Danilo Krummrich
2026-05-18 14:46   ` Alexandre Courbot
2026-05-17  0:00 ` [PATCH v3 06/27] rust: platform: " Danilo Krummrich
2026-05-18 14:46   ` Alexandre Courbot
2026-05-17  0:00 ` [PATCH v3 07/27] rust: auxiliary: " Danilo Krummrich
2026-05-18 14:47   ` Alexandre Courbot
2026-05-17  0:00 ` [PATCH v3 08/27] rust: usb: " Danilo Krummrich
2026-05-18 14:47   ` Alexandre Courbot
2026-05-17  0:00 ` [PATCH v3 09/27] rust: device: " Danilo Krummrich
2026-05-18 14:48   ` Alexandre Courbot
2026-05-17  0:00 ` [PATCH v3 10/27] rust: pci: make Driver trait lifetime-parameterized Danilo Krummrich
2026-05-18 14:53   ` Alexandre Courbot
2026-05-18 15:36   ` Gary Guo
2026-05-18 16:10     ` Danilo Krummrich
2026-05-19  4:52   ` Eliot Courtney
2026-05-19 10:39     ` Danilo Krummrich
2026-05-19 11:48       ` Gary Guo
2026-05-17  0:00 ` [PATCH v3 11/27] rust: platform: " Danilo Krummrich
2026-05-18 14:55   ` Alexandre Courbot
2026-05-17  0:01 ` [PATCH v3 12/27] rust: auxiliary: " Danilo Krummrich
2026-05-18 15:39   ` Alexandre Courbot
2026-05-17  0:01 ` [PATCH v3 13/27] rust: usb: " Danilo Krummrich
2026-05-18 15:40   ` Alexandre Courbot
2026-05-17  0:01 ` [PATCH v3 14/27] rust: i2c: " Danilo Krummrich
2026-05-18 15:41   ` Alexandre Courbot
2026-05-17  0:01 ` [PATCH v3 15/27] rust: driver: update module documentation for GAT-based Data type Danilo Krummrich
2026-05-18 15:46   ` Alexandre Courbot
2026-05-17  0:01 ` [PATCH v3 16/27] rust: types: add `ForLt` trait for higher-ranked lifetime support Danilo Krummrich
2026-05-19  6:02   ` Eliot Courtney
2026-05-19 11:23     ` Gary Guo
2026-05-19 11:07   ` Alexandre Courbot
2026-05-19 11:39     ` Gary Guo
2026-05-17  0:01 ` [PATCH v3 17/27] rust: auxiliary: generalize Registration over ForLt Danilo Krummrich
2026-05-19  7:56   ` Eliot Courtney
2026-05-19 10:39     ` Danilo Krummrich
2026-05-19 11:20       ` Gary Guo [this message]
2026-05-17  0:01 ` [PATCH v3 18/27] samples: rust: rust_driver_auxiliary: showcase lifetime-bound registration data Danilo Krummrich
2026-05-19  6:52   ` Eliot Courtney
2026-05-17  0:01 ` [PATCH v3 19/27] rust: pci: make Bar lifetime-parameterized Danilo Krummrich
2026-05-19  6:36   ` Eliot Courtney
2026-05-17  0:01 ` [PATCH v3 20/27] rust: io: make IoMem and ExclusiveIoMem lifetime-parameterized Danilo Krummrich
2026-05-19  6:39   ` Eliot Courtney
2026-05-17  0:01 ` [PATCH v3 21/27] samples: rust: rust_driver_pci: use HRT lifetime for Bar Danilo Krummrich
2026-05-19  6:41   ` Eliot Courtney
2026-05-17  0:01 ` [PATCH v3 22/27] rust: driver-core: rename 'a lifetime to 'bound Danilo Krummrich
2026-05-19  6:42   ` Eliot Courtney
2026-05-17  0:01 ` [PATCH REF v3 23/27] gpu: nova-core: " Danilo Krummrich
2026-05-17  0:01 ` [PATCH REF v3 24/27] gpu: nova-core: use lifetime for Bar Danilo Krummrich
2026-05-17  0:01 ` [PATCH REF v3 25/27] gpu: nova-core: unregister sysmem flush page from Drop Danilo Krummrich
2026-05-17  0:01 ` [PATCH REF v3 26/27] gpu: nova-core: replace ARef<Device> with &'bound Device in SysmemFlush Danilo Krummrich
2026-05-17  0:01 ` [PATCH REF v3 27/27] gpu: drm: tyr: use lifetime for IoMem Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DIMM2XJHLR16.1K52AYHT02CM@garyguo.net \
    --to=gary@garyguo.net \
    --cc=a.hindborg@kernel.org \
    --cc=abdiel.janulgue@gmail.com \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=david.m.ertman@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=driver-core@lists.linux.dev \
    --cc=ecourtney@nvidia.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=igor.korotin@linux.dev \
    --cc=ira.weiny@intel.com \
    --cc=kwilczynski@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=m.wilczynski@samsung.com \
    --cc=markus.probst@posteo.de \
    --cc=nova-gpu@lists.linux.dev \
    --cc=ojeda@kernel.org \
    --cc=pcolberg@redhat.com \
    --cc=rafael@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=ukleinek@kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox