Re: [PATCH v2 02/17] regmap-irq: Add get_irq_reg to support unusual register layouts

Mark Brown
2022-06-08T16:17:13Z

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

On Tue, Jun 07, 2022 at 04:53:09PM +0100, Aidan MacDonald wrote:

> - if (!chip->sub_reg_offsets || !chip->not_fixed_stride) {
> + if (chip->get_irq_reg) {
> + reg = chip->get_irq_reg(base_reg, i);
> + } else if (!chip->sub_reg_offsets || !chip->not_fixed_stride) {

It seems like it would be cleaner and clearer to refactor things so that
we always have a get_irq_reg() with standard chips getting given a
default implementation which implements the current behaviour.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]