From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAF4CCCA480 for ; Wed, 6 Jul 2022 10:24:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232545AbiGFKYf (ORCPT ); Wed, 6 Jul 2022 06:24:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232386AbiGFKYf (ORCPT ); Wed, 6 Jul 2022 06:24:35 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A4E023BFC; Wed, 6 Jul 2022 03:24:34 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id z12so11778001wrq.7; Wed, 06 Jul 2022 03:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:from:to:cc:subject:date:in-reply-to:message-id :mime-version; bh=gAAFLxTVBbke7idk+TJqhtAe46jVc+eusFaZ2+NGDNc=; b=T01qQGVCFpQvsrYLXbIulhJcGg0HUmQARvvOBgipM53C+Kp8/JIW6EVZQb5v0UNLwb ml0P7sxKFGboDz7Kyc82mBHUJNEO0yRFzMpFmbK4JRLCoyqkfBGu/dlbT2ajCZH8/rag fEVKcZ2ywOjzx+JWnLYUwVSpbUU4PWhsNQzBTji78zfstk9Yu3qAhwlP6Kf0vvPvkd2b PP2nxprfreGNNm0gX45OMoKjagQ6gYAa1hM2XRfJomg8WJjQmTsdOWUbhDH+1SGW2013 GeHT4vlC7fliPHYqfW+hPr4R0eArQu9KrGpNAZm9xnx+v/SIAhMOH/Wjyabf+lLJm7iW gzkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=gAAFLxTVBbke7idk+TJqhtAe46jVc+eusFaZ2+NGDNc=; b=kk9CrQ79OGzuPlAzaQ37UxR0TJLH4d+7ndJqi7cuBEEFOpGi57TVrGV2KSP8UeGT5k mXzntGrptd7iz+IVGwdglKH9ZXmoBRD8Q/ytqaELjRMtdnKLjw8ZKKMhgc3lX/DyRq0K q/rJMgfec5NrUowTy3TfBZQo+19OHZs50KbtHJshivTmNd+yXvug3VAKQ7n58GzfoKlf Ph14ZjTM/P2/ZNGWO0BjI9mJdG9aSB+5Rni9r+1YY0Ws66bgECfv27QXNWjNQjJHI/6i Qxu+HfYYoyVy0rIYlwNNSuPaS7N9BjpX5U6JG6GcLUWnwUBWlDRO7i8XZk3EQOED9Kya WKtA== X-Gm-Message-State: AJIora9m8dwFSvgPlgsEk+USgQ6Z198joG6WXwVFwqBKiaDYBSP+o6+0 S+WC1izObcHnMBmG/6E/myc= X-Google-Smtp-Source: AGRyM1vU3MJHoH322VL/VZ3kLVOdxQZ29efLU3+xNpoRRoRaYcb0Iv3nb/x5LHrg9UdFMQ7tbtgPbw== X-Received: by 2002:adf:d1ea:0:b0:21b:a6cb:fcf6 with SMTP id g10-20020adfd1ea000000b0021ba6cbfcf6mr36825810wrd.477.1657103072945; Wed, 06 Jul 2022 03:24:32 -0700 (PDT) Received: from localhost (92.40.202.163.threembb.co.uk. [92.40.202.163]) by smtp.gmail.com with ESMTPSA id bq25-20020a5d5a19000000b0021d6d74a0ecsm6931272wrb.96.2022.07.06.03.24.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 03:24:32 -0700 (PDT) References: <20220629143046.213584-1-aidanmacdonald.0x0@gmail.com> <20220629143046.213584-7-aidanmacdonald.0x0@gmail.com> From: Aidan MacDonald To: Lee Jones Cc: linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, wens@csie.org, jic23@kernel.org, sre@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, lars@metafoo.de, quic_gurus@quicinc.com, sebastian.reichel@collabora.com, andy.shevchenko@gmail.com, michael@walle.cc, rdunlap@infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v4 06/15] mfd: axp20x: Add support for AXP192 Date: Tue, 05 Jul 2022 20:42:43 +0100 In-reply-to: Message-ID: MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Lee Jones writes: > On Tue, 05 Jul 2022, Aidan MacDonald wrote: > >> >> Lee Jones writes: >> >> > On Wed, 29 Jun 2022, Aidan MacDonald wrote: >> > >> >> The AXP192 PMIC is similar to the AXP202/AXP209, but with different >> >> regulators, additional GPIOs, and a different IRQ register layout. >> >> >> >> Acked-for-MFD-by: Lee Jones >> >> Signed-off-by: Aidan MacDonald >> >> --- >> >> drivers/mfd/axp20x-i2c.c | 2 + >> >> drivers/mfd/axp20x.c | 152 +++++++++++++++++++++++++++++++++++++ >> >> include/linux/mfd/axp20x.h | 84 ++++++++++++++++++++ >> >> 3 files changed, 238 insertions(+) >> >> [...] >> >> +static const struct regmap_irq_chip axp192_regmap_irq_chip = { >> >> + .name = "axp192_irq_chip", >> >> + .status_base = AXP192_IRQ1_STATE, >> >> + .ack_base = AXP192_IRQ1_STATE, >> >> + .unmask_base = AXP192_IRQ1_EN, >> >> + .init_ack_masked = true, >> >> + .irqs = axp192_regmap_irqs, >> >> + .num_irqs = ARRAY_SIZE(axp192_regmap_irqs), >> >> + .num_regs = 5, >> >> + .get_irq_reg = axp192_get_irq_reg, >> > >> > Fix me: >> > >> > drivers/mfd/axp20x.c:634:35: error: initialization of 'unsigned int (*)(struct regmap_irq_chip_data *, unsigned int, int)' from incompatible pointer type 'int (*)(unsigned int, int)' [-Werror=incompatible-pointer-types] >> > 634 | .get_irq_reg = axp192_get_irq_reg, >> > | ^~~~~~~~~~~~~~~~~~ >> > drivers/mfd/axp20x.c:634:35: note: (near initialization for 'axp192_regmap_irq_chip.get_irq_reg') >> > >> >> This doesn't need fixing. You are missing the prerequisite patches. >> >> -- snip -- >> Changes in v4: >> * Drop regmap-irq patches and rebase on top of the regmap-irq >> refactoring series[1], which implements the same functionality. >> >> [1]: https://lore.kernel.org/lkml/20220623211420.918875-1-aidanmacdonald.0x0@gmail.com/ >> -- snip -- > >> Perhaps I wasn't clear enough that it was a dependency, sorry for >> any confusion. > > Any idea why the regmap-irq patches weren't in -next? Uh, sorry, I didn't pay attention and assumed this was the same error the kernel test robot was reporting against mfd-next (missing field). But the field does exist; this error is a type mismatch: initialization of 'unsigned int (*)(struct regmap_irq_chip_data *, unsigned int, int)' from incompatible pointer type 'int (*)(unsigned int, int)' So the regmap-irq patches were in -next, the problem is you were using the old patch from v3. FYI, I just sent a v5 which drops the GPIO driver, so please use the patches from that version. Thanks. Regards, Aidan