From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thierry Strudel <tstrudel@google.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] PM: domains: create debugfs nodes when adding power domains
Date: Tue, 8 Dec 2020 20:51:15 +0100 [thread overview]
Message-ID: <X8/ZM7Vm/aD9FdlG@kroah.com> (raw)
In-Reply-To: <20201208191955.2466057-1-tstrudel@google.com>
On Tue, Dec 08, 2020 at 11:19:55AM -0800, Thierry Strudel wrote:
> debugfs nodes were created in genpd_debug_init alled in late_initcall
> preventing power domains registered though loadable modules to have
> a debugfs entry.
>
> Create/remove debugfs nodes when the power domain is added/removed
> to/from the internal gpd_list.
>
> Signed-off-by: Thierry Strudel <tstrudel@google.com>
> Change-Id: I8a2e0616746afe2a6bbd9c24bc3a0eaa84725a75
You don't need this, checkpatch.pl should have warned you :)
> ---
> v2: fix forward declaration and genpd_debugfs_dir being NULL - Ulf
> v3: remove extra trailing char added by mistake in v2 - kernel test robot
> v4: cleanup includes and regroup CONFIG_DEBUG_FS CPP blocks - Greg
> drivers/base/power/domain.c | 73 +++++++++++++++++++++++--------------
> 1 file changed, 45 insertions(+), 28 deletions(-)
Looks good to me, thanks for fixing it up. Rafael, will this go through
your tree?
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2020-12-08 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 19:19 [PATCH v4] PM: domains: create debugfs nodes when adding power domains Thierry Strudel
2020-12-08 19:51 ` Greg Kroah-Hartman [this message]
2020-12-08 20:40 ` Thierry Strudel
2020-12-09 15:32 ` Rafael J. Wysocki
2020-12-10 7:16 ` Ulf Hansson
2020-12-10 18:51 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8/ZM7Vm/aD9FdlG@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tstrudel@google.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox