[PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is disabled

[PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is disabled

[Kai-Heng Feng]

Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver
parameter for mode selection") changed the driver to be disabled by
default, and this can surprise users.

Let users know what happened so they can decide what to do next.

Link: https://bugs.launchpad.net/bugs/2006942
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
v2:
 - Remove redundancy in pr_info().
 - Fix spelling and URL tag.

 drivers/cpufreq/amd-pstate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 45c88894fd8e..f965f54f7ae7 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void)
 	 * with amd_pstate=passive or other modes in kernel command line
 	 */
 	if (cppc_state == AMD_PSTATE_DISABLE) {
-		pr_debug("driver load is disabled, boot with specific mode to enable this\n");
+		pr_info("driver load is disabled, boot with specific mode to enable this\n");
 		return -ENODEV;
 	}
 
-- 
2.34.1

RE: [PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is disabled

[Yuan, Perry]

[AMD Official Use Only - General]


> -----Original Message-----
> From: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Sent: Thursday, February 23, 2023 3:03 PM
> To: Huang, Ray <Ray.Huang@amd.com>
> Cc: Limonciello, Mario <Mario.Limonciello@amd.com>; Kai-Heng Feng
> <kai.heng.feng@canonical.com>; Rafael J. Wysocki <rafael@kernel.org>; Viresh
> Kumar <viresh.kumar@linaro.org>; linux-pm@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is disabled
> 
> Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver parameter
> for mode selection") changed the driver to be disabled by default, and this can
> surprise users.
> 
> Let users know what happened so they can decide what to do next.
> 
> Link: https://bugs.launchpad.net/bugs/2006942
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> v2:
>  - Remove redundancy in pr_info().
>  - Fix spelling and URL tag.
> 
>  drivers/cpufreq/amd-pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index
> 45c88894fd8e..f965f54f7ae7 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void)
>  	 * with amd_pstate=passive or other modes in kernel command line
>  	 */
>  	if (cppc_state == AMD_PSTATE_DISABLE) {
> -		pr_debug("driver load is disabled, boot with specific mode to
> enable this\n");
> +		pr_info("driver load is disabled, boot with specific mode to
> enable
> +this\n");
>  		return -ENODEV;
>  	}
> 
> --
> 2.34.1
Thanks for the change. 

Reviewed-by : Yuan Perry <Perry.Yuan@amd.com>
 

Re: [PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is disabled

[Huang Rui]

On Thu, Feb 23, 2023 at 03:02:52PM +0800, Kai-Heng Feng wrote:
> Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver
> parameter for mode selection") changed the driver to be disabled by
> default, and this can surprise users.
> 
> Let users know what happened so they can decide what to do next.
> 
> Link: https://bugs.launchpad.net/bugs/2006942
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Please feel free to add my Acked on V2 as well.

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
> v2:
>  - Remove redundancy in pr_info().
>  - Fix spelling and URL tag.
> 
>  drivers/cpufreq/amd-pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 45c88894fd8e..f965f54f7ae7 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void)
>  	 * with amd_pstate=passive or other modes in kernel command line
>  	 */
>  	if (cppc_state == AMD_PSTATE_DISABLE) {
> -		pr_debug("driver load is disabled, boot with specific mode to enable this\n");
> +		pr_info("driver load is disabled, boot with specific mode to enable this\n");
>  		return -ENODEV;
>  	}
>  
> -- 
> 2.34.1
> 

RE: [PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is disabled

[Limonciello, Mario]

[Public]



> -----Original Message-----
> From: Huang, Ray <Ray.Huang@amd.com>
> Sent: Thursday, February 23, 2023 05:38
> To: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Cc: Limonciello, Mario <Mario.Limonciello@amd.com>; Rafael J. Wysocki
> <rafael@kernel.org>; Viresh Kumar <viresh.kumar@linaro.org>; linux-
> pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is
> disabled
> 
> On Thu, Feb 23, 2023 at 03:02:52PM +0800, Kai-Heng Feng wrote:
> > Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver
> > parameter for mode selection") changed the driver to be disabled by
> > default, and this can surprise users.
> >
> > Let users know what happened so they can decide what to do next.
> >
> > Link: https://bugs.launchpad.net/bugs/2006942
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> 
> Please feel free to add my Acked on V2 as well.
> 
> Acked-by: Huang Rui <ray.huang@amd.com>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> 
> > ---
> > v2:
> >  - Remove redundancy in pr_info().
> >  - Fix spelling and URL tag.
> >
> >  drivers/cpufreq/amd-pstate.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> > index 45c88894fd8e..f965f54f7ae7 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void)
> >  	 * with amd_pstate=passive or other modes in kernel command line
> >  	 */
> >  	if (cppc_state == AMD_PSTATE_DISABLE) {
> > -		pr_debug("driver load is disabled, boot with specific mode to
> enable this\n");
> > +		pr_info("driver load is disabled, boot with specific mode to
> enable this\n");
> >  		return -ENODEV;
> >  	}
> >
> > --
> > 2.34.1
> >

Re: [PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is disabled

[Rafael J. Wysocki]

On Thu, Feb 23, 2023 at 8:03 AM Kai-Heng Feng
<kai.heng.feng@canonical.com> wrote:
>
> Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver
> parameter for mode selection") changed the driver to be disabled by
> default, and this can surprise users.
>
> Let users know what happened so they can decide what to do next.
>
> Link: https://bugs.launchpad.net/bugs/2006942
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> v2:
>  - Remove redundancy in pr_info().
>  - Fix spelling and URL tag.
>
>  drivers/cpufreq/amd-pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 45c88894fd8e..f965f54f7ae7 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void)
>          * with amd_pstate=passive or other modes in kernel command line
>          */
>         if (cppc_state == AMD_PSTATE_DISABLE) {
> -               pr_debug("driver load is disabled, boot with specific mode to enable this\n");
> +               pr_info("driver load is disabled, boot with specific mode to enable this\n");
>                 return -ENODEV;
>         }
>
> --

Applied as 6.3-rc material, thanks!